code will not light led on uno

Projects Programming
1

i am using a ds1307 rtc and a uno. making a pretty basic light timer. i have the rtc hooked up with a sensor shield and can get it to print in the serial monitor. the problem is that when i set my if statement to turn on the led connected to pin 13 the led will not light up here is my code and still no led action

#include <WProgram.h>
#include <Wire.h>
#include <DS1307.h>
int HR;
int MIN;
int SEC;


void setup()
{
  Serial.begin(9600);
  pinMode(13, OUTPUT);
  RTC.stop();
  RTC.set(DS1307_SEC,1);        //set the seconds
  RTC.set(DS1307_MIN,50);     //set the minutes
  RTC.set(DS1307_HR,1);       //set the hours
  RTC.set(DS1307_DOW,4);       //set the day of the week
  RTC.set(DS1307_DATE,15);       //set the date
  RTC.set(DS1307_MTH,9);        //set the month
  RTC.set(DS1307_YR,11);         //set the year
  RTC.start();
}

void loop()
{
  Serial.print(RTC.get(DS1307_HR,true)); //read the hour and also update all the values by pushing in true
  Serial.print(":");
  Serial.print(RTC.get(DS1307_MIN,false));//read minutes without update (false)
  Serial.print(":");
  Serial.print(RTC.get(DS1307_SEC,false));//read seconds
  Serial.print("      ");                 // some space for a more happy life
  Serial.print(RTC.get(DS1307_DATE,false));//read date
  Serial.print("/");
  Serial.print(RTC.get(DS1307_MTH,false));//read month
  Serial.print("/");
  Serial.print(RTC.get(DS1307_YR,false)); //read year 
  Serial.println();

  delay(1000); 

  if (HR == 1, MIN == 50, SEC == 30){
    digitalWrite (13, HIGH);
  }
}
2

Use logical AND, not commas.

3

hey awol i switched the commas to logical ands and still no led light any other ideas? i know the led works cause i can use the blink example and it blinks and i have this set up like that one for the led logic commands

4

Usually my other ideas involve seeing your code (you didn't use bitwise AND, did you?), and seeing your debug output.

5

i used the && for and. as far as the debug that s the console at the bottom correct? its empty except for the binary sketch size the program compiles and runs fine the serial monitor shows the time tickin away but no led action

#include <WProgram.h>
#include <Wire.h>
#include <DS1307.h>
int HR;
int MIN;
int SEC;


void setup()
{
  Serial.begin(9600);
  pinMode(13, OUTPUT);
  RTC.stop();
  RTC.set(DS1307_SEC,1);        //set the seconds
  RTC.set(DS1307_MIN,50);     //set the minutes
  RTC.set(DS1307_HR,1);       //set the hours
  RTC.set(DS1307_DOW,4);       //set the day of the week
  RTC.set(DS1307_DATE,15);       //set the date
  RTC.set(DS1307_MTH,9);        //set the month
  RTC.set(DS1307_YR,11);         //set the year
  RTC.start();
}

void loop()
{
  Serial.print(RTC.get(DS1307_HR,true)); //read the hour and also update all the values by pushing in true
  Serial.print(":");
  Serial.print(RTC.get(DS1307_MIN,false));//read minutes without update (false)
  Serial.print(":");
  Serial.print(RTC.get(DS1307_SEC,false));//read seconds
  Serial.print("      ");                 // some space for a more happy life
  Serial.print(RTC.get(DS1307_DATE,false));//read date
  Serial.print("/");
  Serial.print(RTC.get(DS1307_MTH,false));//read month
  Serial.print("/");
  Serial.print(RTC.get(DS1307_YR,false)); //read year 
  Serial.println();

  delay(1000); 

  if (HR == 1 && MIN && 50, SEC && 30){
    digitalWrite (13, HIGH);
  }
}
6

What's the comma for?
What happened to the comparisons?

7

sry i put stuff in the qrong spot there lol here it is now

#include <WProgram.h>
#include <Wire.h>
#include <DS1307.h>
int HR;
int MIN;
int SEC;


void setup()
{
  Serial.begin(9600);
  pinMode(13, OUTPUT);
  RTC.stop();
  RTC.set(DS1307_SEC,1);        //set the seconds
  RTC.set(DS1307_MIN,50);     //set the minutes
  RTC.set(DS1307_HR,1);       //set the hours
  RTC.set(DS1307_DOW,4);       //set the day of the week
  RTC.set(DS1307_DATE,15);       //set the date
  RTC.set(DS1307_MTH,9);        //set the month
  RTC.set(DS1307_YR,11);         //set the year
  RTC.start();
}

void loop()
{
  Serial.print(RTC.get(DS1307_HR,true)); //read the hour and also update all the values by pushing in true
  Serial.print(":");
  Serial.print(RTC.get(DS1307_MIN,false));//read minutes without update (false)
  Serial.print(":");
  Serial.print(RTC.get(DS1307_SEC,false));//read seconds
  Serial.print("      ");                 // some space for a more happy life
  Serial.print(RTC.get(DS1307_DATE,false));//read date
  Serial.print("/");
  Serial.print(RTC.get(DS1307_MTH,false));//read month
  Serial.print("/");
  Serial.print(RTC.get(DS1307_YR,false)); //read year 
  Serial.println();

  delay(1000); 

  if (HR == 1 && MIN == 50 && SEC == 30){
    digitalWrite (13, HIGH);
  }
}
8

I don't see anywhere in your code that HR, MIN, and SEC get set to anything. So the if statement will always evaluate to false.

9

What do you mean by that i have declared them as global variables explain to me how they should be set then please

10 
if (HR == 1 && MIN == 50 && SEC == 30){

...

HR, MIN and SEC are never set to anything, as James C4S said.

Do you mean something like:

  if (RTC.get(DS1307_HR, false) == 1 && 
      RTC.get(DS1307_MIN, false) == 50 && 
      RTC.get(DS1307_SEC, false) == 30){
...
11

well thank you nick that was very helpfull my led light uo right when it was supposed to. i understand what you said now also. my fishies thank you vey much.