coding for pwm and high

Using Arduino Programming Questions
1

hi everyone, im rather new to all of this and have been playing for a couple of months with the basic stuff having great fun. ive now come stuck and unsure where ive gone wrong. im wanting to have 2 button inputs 1 to send leds on high and 1 to send the leds on pwm so the led are dimmer like a side/brake light bulb. ive wrote this code and have the brake light effect working but cant get the side button to do as I want. can someone please help and explain where ive gone wrong many thanks Michael

// trail of side brake pwm
// resistor 220ohm led long positive
const int led = 3;
const int leda = 5;
const int ledb = 6;
const int ledc = 9;
const int ledd = 10;
const int lede = 11;
const int brake = A1;
const int side = A0

int brakeState = 0;
int sideState = 0;
int brightness = 150;

void setup() {
// put your setup code here, to run once:
pinMode(led, OUTPUT);
pinMode(leda, OUTPUT);
pinMode(ledb, OUTPUT);
pinMode(ledc, OUTPUT);
pinMode(ledd,OUTPUT);
pinMode(lede, OUTPUT);
pinMode(side, INPUT);
pinMode(brake, INPUT);
}

void loop() {
// read the state of the pushbutton value:
brakeState = digitalRead(brake);

// check if the pushbutton is pressed. If it is, the buttonState is HIGH:
if (brakeState == HIGH) {
// turn LED on:
digitalWrite(led, HIGH);
digitalWrite(leda, HIGH);
digitalWrite(ledb, HIGH);
digitalWrite(ledc, HIGH);
digitalWrite(ledd, HIGH);
digitalWrite(lede, HIGH);

}

} else {
// turn LED off:
digitalWrite(led, LOW );
digitalWrite(leda, LOW );
digitalWrite(ledb, LOW );
digitalWrite(ledc, LOW );
digitalWrite(ledd, LOW );
digitalWrite(lede, LOW );

}
{ if (sideState == HIGH)
// turn side on
analogWrite(led, brightness );
analogWrite(leda, brightness );
analogWrite(ledb, brightness );
analogWrite(ledc, brightness );
analogWrite(ledd, brightness );
analogWrite(lede, brightness );
} else {
// turn led off
digitalWrite(led, LOW );
digitalWrite(leda, LOW );
digitalWrite(ledb, LOW );
digitalWrite(ledc, LOW );
digitalWrite(ledd, LOW );
digitalWrite(lede, LOW );
}

2

Here is a portion of your code in code tags (please take note) and Auto Formatted in the IDE

  if (sideState == HIGH)
    // turn side on
    analogWrite(led, brightness );
  analogWrite(leda, brightness );
  analogWrite(ledb, brightness );
  analogWrite(ledc, brightness );
  analogWrite(ledd, brightness );
  analogWrite(lede, brightness );

which analogWrite()s depend on sideState being HIGH and which will be executed regardless of the state of sideState ?

3

im confused to what you mean, im wanting when the button for side is pressed the leds will receive a pwm so they light up dimmer.

4

The way you have the code at present only

   analogWrite(led, brightness );

depends on testing sideState. The others will always happen

Try this

  if (sideState == HIGH)
    // turn side on
  {
    analogWrite(led, brightness );
    analogWrite(leda, brightness );
    analogWrite(ledb, brightness );
    analogWrite(ledc, brightness );
    analogWrite(ledd, brightness );
    analogWrite(lede, brightness );
  }

Now all of the analogWrite()s depend on sideState being HIGH which is what I presume you want

Note the { and } round the dependant code block

5

yes that's what I want ive done that but getting a error code on the brake state else.
exit status 1
expected unqualified-id before 'else'

// trail of side brake pwm
// resistor 220ohm led long positive
const int led = 3;
const int leda = 5;
const int ledb = 6;
const int ledc = 9;
const int ledd = 10;
const int lede = 11;
const int brake = A1;
const int side = A0;

int brakeState = 0;
int sideState =  0;
int brightness = 150;

void setup() {
 // put your setup code here, to run once:
pinMode(led, OUTPUT);
pinMode(leda, OUTPUT);
pinMode(ledb, OUTPUT);
pinMode(ledc, OUTPUT);
pinMode(ledd,OUTPUT);
pinMode(lede, OUTPUT);
pinMode(side, INPUT);
pinMode(brake, INPUT);
}

void loop() {
   // read the state of the pushbutton value:
 brakeState = digitalRead(brake);

 // check if the pushbutton is pressed. If it is, the buttonState is HIGH:
 if (brakeState == HIGH) {
   // turn LED on:
   digitalWrite(led, HIGH);
   digitalWrite(leda, HIGH);
   digitalWrite(ledb, HIGH);
   digitalWrite(ledc, HIGH);
   digitalWrite(ledd, HIGH);
   digitalWrite(lede, HIGH);
   
   }

} else {
   // turn LED off:
    digitalWrite(led, LOW );
    digitalWrite(leda, LOW );
    digitalWrite(ledb, LOW );
    digitalWrite(ledc, LOW );
    digitalWrite(ledd, LOW );
    digitalWrite(lede, LOW );
  
  }
    sideState = digitalRead(side);
    if (sideState == HIGH)
    // turn side on {
    analogWrite(led, brightness );
    analogWrite(leda, brightness );
    analogWrite(ledb, brightness );
    analogWrite(ledc, brightness );
    analogWrite(ledd, brightness );
    analogWrite(lede, brightness ); 
 }else {
    // turn led off
    digitalWrite(led, LOW );
    digitalWrite(leda, LOW );
    digitalWrite(ledb, LOW );
    digitalWrite(ledc, LOW );
    digitalWrite(ledd, LOW );
    digitalWrite(lede, LOW );

}
6

Your code is incomplete.

Please remember to use code tags when posting code

7 
 if (brakeState == HIGH) {
    // turn LED on:
    digitalWrite(led, HIGH);
    digitalWrite(leda, HIGH);
    digitalWrite(ledb, HIGH);
    digitalWrite(ledc, HIGH);
    digitalWrite(ledd, HIGH);
    digitalWrite(lede, HIGH);
    
    }

}

that looks to me to be the end of loop()

8 
// turn side on {

Whoops. You put the opening brace in a comment.

If you always put { and } alone on their own line then that will never happen

9

thank you! its worked a treat. it been very much appreciated and have learnt something new thanks again!!!

10