Comparing analog signals

Projects General Guidance
16

You only need to use the "and" condition for the in spec comparison when both things need to be true. The "or" is correct for the out of range when only one thing needs to be true.

if(potValue <= resistorValue * 0.9  ||  potValue >= resistorValue * 1.1) 
    digitalWrite(redLed, HIGH);
  else digitalWrite(redLed, LOW);
  
  if(potValue >= resistorValue * 0.9 && potValue <= resistorValue * 1.1) 
    digitalWrite(greenLed, HIGH);
  else digitalWrite(greenLed, LOW);

All the other comments about printing the analogRead() values and working with the resistor network are very relevant. Having the correct comparison code will only work if you correct values.