Condense code into....

system · August 25, 2011, 4:49pm

Could somebody give me an example or lead me in the direction to figure out how to take a huge chunk of almost reoccurring code and condense it into some sort of loop (i.e. for loop)?

I just don't know how I could condense this code to something easier to write and still have it do the same effect.
Any and all help is much appreciated and VERY needed.
Thanks

void loop() {
 //1
   LEDChannels[0][0] = 1023;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 1023;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 1023;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 1023;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 1023;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 1023;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 1023;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 1023;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 1023;
   LEDChannels[8][1] = 0;
   LEDChannels[8][2] = 0;
 
   LEDChannels[9][0] = 1023;
   LEDChannels[9][1] = 0;
   LEDChannels[9][2] = 0;
 
   WriteLEDArray();
   delay(200);
  //2 
   LEDChannels[0][0] = 200;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 500;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 700;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 1023;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 1023;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 1023;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 1023;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 1023;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 900;
   LEDChannels[8][1] = 0;
   LEDChannels[8][2] = 0;
 
   LEDChannels[9][0] = 900;
   LEDChannels[9][1] = 0;
   LEDChannels[9][2] = 0;
 
   WriteLEDArray();
   delay(200);
 //3  
   LEDChannels[0][0] = 0;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 200;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 500;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 700;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 1023;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 1023;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 1023;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 1023;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 900;
   LEDChannels[8][1] = 0;
   LEDChannels[8][2] = 0;
 
   LEDChannels[9][0] = 700;
   LEDChannels[9][1] = 0;
   LEDChannels[9][2] = 0;
 
   WriteLEDArray();
   delay(200);
//4   
   LEDChannels[0][0] = 0;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 0;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 200;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 500;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 700;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 900;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 900;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 800;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 700;
   LEDChannels[8][1] = 0;
   LEDChannels[8][2] = 00;
 
   LEDChannels[9][0] = 500;
   LEDChannels[9][1] = 0;
   LEDChannels[9][2] = 0;
 
   WriteLEDArray();
   delay(200);

//5   
   LEDChannels[0][0] = 0;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 0;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 0;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 200;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 500;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 700;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 700;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 700;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 500;
   LEDChannels[8][1] = 0;
   LEDChannels[8][2] = 0;
 
   LEDChannels[9][0] = 300;
   LEDChannels[9][1] = 0;
   LEDChannels[9][2] = 0;
 
   WriteLEDArray();
   delay(200);

system · August 25, 2011, 4:49pm

The last bit of the chunk....

//6   
   LEDChannels[0][0] = 0;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 0;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 0;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 0;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 200;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 500;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 500;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 300;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 200;
   LEDChannels[8][1] = 0;
   LEDChannels[8][2] = 0;
 
   LEDChannels[9][0] = 100;
   LEDChannels[9][1] = 0;
   LEDChannels[9][2] = 0;
 
   WriteLEDArray();
   delay(200);

//7   
   LEDChannels[0][0] = 0;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 0;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 0;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 0;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 0;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 200;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 300;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 200;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 100;
   LEDChannels[8][1] = 0;
   LEDChannels[8][2] = 0;
 
   LEDChannels[9][0] = 0;
   LEDChannels[9][1] = 250;
   LEDChannels[9][2] = 350;
 
   WriteLEDArray();
   delay(200);
   
//8   
   LEDChannels[0][0] = 0;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 0;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 0;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 0;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 0;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 0;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 350;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 250;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 0;
   LEDChannels[8][1] = 250;
   LEDChannels[8][2] = 350;
 
   LEDChannels[9][0] = 0;
   LEDChannels[9][1] = 0;
   LEDChannels[9][2] = 800;
 
   WriteLEDArray();
   delay(200);
   
//9   
   LEDChannels[0][0] = 0;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 0;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 0;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 0;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 0;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 0;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 0;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 0;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 0;
   LEDChannels[8][1] = 300;
   LEDChannels[8][2] = 420;
 
   LEDChannels[9][0] = 0;
   LEDChannels[9][1] = 0;
   LEDChannels[9][2] = 1023;
 
   WriteLEDArray();
   delay(200);
//10 
   LEDChannels[0][0] = 0;
   LEDChannels[0][1] = 0;
   LEDChannels[0][2] = 0;
 
   LEDChannels[1][0] = 0;
   LEDChannels[1][1] = 0;
   LEDChannels[1][2] = 0;
   
   LEDChannels[2][0] = 0;
   LEDChannels[2][1] = 0;
   LEDChannels[2][2] = 0;
 
   LEDChannels[3][0] = 0;
   LEDChannels[3][1] = 0;
   LEDChannels[3][2] = 0;
   
   LEDChannels[4][0] = 0;
   LEDChannels[4][1] = 0;
   LEDChannels[4][2] = 0;
 
   LEDChannels[5][0] = 0;
   LEDChannels[5][1] = 0;
   LEDChannels[5][2] = 0;
   
   LEDChannels[6][0] = 0;
   LEDChannels[6][1] = 0;
   LEDChannels[6][2] = 0;
 
   LEDChannels[7][0] = 0;
   LEDChannels[7][1] = 0;
   LEDChannels[7][2] = 0;
   
   LEDChannels[8][0] = 0;
   LEDChannels[8][1] = 0;
   LEDChannels[8][2] = 1023;
 
   LEDChannels[9][0] = 0;
   LEDChannels[9][1] = 0;
   LEDChannels[9][2] = 1023;
 
   WriteLEDArray();
   delay(800);
}

robtillaart · August 25, 2011, 5:07pm

void loop() 
{
  //1
  for (int i =0; i< 10; i++) 
  {
    LEDChannels[i][0] = 1023;
    LEDChannels[i][1] = 0;
    LEDChannels[i][2] = 0;
  }

   WriteLEDArray();
   delay(200);

  //2 
  for (int i =0; i< 10; i++)         // this loop can be skipped as all vars are "right"  due to // 1 above but keeping this is more robust.
  {
    LEDChannels[i][0] = 1023;
    LEDChannels[i][1] = 0;
    LEDChannels[i][2] = 0;
  }
  // do the ones that differ from the loop above.
  LEDChannels[0][0] = 200;
  LEDChannels[1][0] = 500;
  LEDChannels[2][0] = 700;
  LEDChannels[8][0] = 900;
  LEDChannels[9][0] = 900;
 
  WriteLEDArray();
  delay(200);

  // 3 to 6 similar

Furthermore as every WriteLedArray is followed by the delay(200) you could move the delay inside the code of the function, optionally with the parameter of delay as param of WriteLedArray .

void WriteLedArray(unsigned long del)
{
 ...
  delay(del);
}

Grumpy_Mike · August 25, 2011, 5:15pm

If something doesn't change from one WriteLEDArray(); to the next then there is no need to keep setting it to zero.
Just change the array elements you want to change and do the WriteLEDArray();

system · August 25, 2011, 5:57pm

Awesome! You fellas are wonderful.

At first look the following codes seems like it would set all the LEDChannels 0(red) brightness to 1023 and that would override the values just under but it doesn't.

for (int i =0; i< 10; i++)         // this loop can be skipped as all vars are "right"  due to // 1 above but keeping this is more robust.
  {
    LEDChannels[i][0] = 1023;
    LEDChannels[i][1] = 0;
    LEDChannels[i][2] = 0;
  }
  // do the ones that differ from the loop above.
  LEDChannels[0][0] = 200;
  LEDChannels[1][0] = 500;
  LEDChannels[2][0] = 700;
  LEDChannels[8][0] = 900;
  LEDChannels[9][0] = 900;
 
  WriteLEDArray();
  delay(200);

I now have an understanding on how to condense the code so I don't have all that tedious copy/paste with minor changes.
Now if only I can wrap my head around how to get these things to do a smooth fade in the same sequence.

Thank you very much for the help.

Topic		Replies	Views
I'm trying to tidy some very basic but bulky code Programming	14	191	February 10, 2025
Multiple LED fade Programming	23	2971	July 23, 2022
LED strip sequence PWM add pushbutton change sequence General Guidance	46	698	October 27, 2025
How to make the LEDS loop? Programming	14	832	December 12, 2023
Fade in e fade out Software	27	313	March 14, 2025

Condense code into....

Related topics