Controlling a LED

Using Arduino Programming Questions
1

Does this code look OK to you?

//declaration--
int led = 7;
//setup--
 pinMode (led, OUTPUT);

//loop--
if (digitalRead(LRelayOn) == HIGH || digitalRead(HRelayOn) == HIGH) {  //checks to see if either output is high
     digitalWrite (led,HIGH); } //turns the LED on
      else {
      digitalWrite (led,LOW); } //turns the LED off

It should check to see if either of two output pins are high, and if so turn on the LED, if not turn it off.
I'm questioning the code as I am just learning, and it isn't working!

2

Looks OK as far as it goes. How is the LED wired? Are you sure of the polarity?

3

Hang on! found the problem, the resistor should be 270 Ohm but it's a 27k! (my eyes aren't what they were!!)
Thanks

4

Ha! I have that same problem! And the resistors aren't getting any bigger! I like the 1/6 watters because they take up less space on PC boards, but I can't always read them without magnification or a meter.

5

but I can't always read them without magnification or a meter.

I never bother trying to read the color bands. I'd need to compare them to a chart, which I can never find, and then interpret the values. A meter is so much easier. If you don't have one, do yourself a big favor. Put the Arduino and all the other stuff in a box. Tape it shut, and leave it alone until you get one. They are cheap. The Arduino isn't.