Corrupted sensor MAX31855 data and Serial out

[nslattengren]

I hope this is the right forum for this question, but I have been running into trouble with my MAX31855 sensor data.

I have a custom arduino Leonardo board to control a coffee roaster. In my design the arduino connects to two MAX31855 through a shared SPI bus (different chip select per MAX31855). I am sending the sensor data through the USB-serial port to connect to a software program that uses this data for controlling heating elements, motors, and display (through I2C).

I have found when I either use the Serial.print for debugging purposes or to speak with the program; my sensor data gets corrupted (seems to divide in half). The display and serial interface show the same incorrect data. If I don't connect through Arduino serial monitor or open a UART connection sensor data is correct on my display.

I don't know the Serial.print is interrupting my SPI transaction or corrupting the register data. But if I have less debug data there errors are less common.

In my code below I don't show the entire state machine as it would blow up the code a lot.

  /*************************************************** 
Pretty crappy coffee roasting code.  That is all
Written by Nathan Slattengren.  
BSD license, all text above must be included in any redistribution
This is revision 8 of the design and supports connecting to a convection oven.  See Revision 7 for the last support of coffee roaster.
****************************************************/

#include <SPI.h>
#include <Wire.h>
#include "Adafruit_MAX31855.h"
#include "LCD16x2.h"
#include "coffee_roaster.h"

LCD16x2 lcd;

int PreviousButton;
int CurrentButton;

// Default connection is using software SPI, but comment and uncomment one of
// the two examples below to switch between software SPI and hardware SPI:

// Example creating a thermocouple instance with software SPI on any three
// digital IO pins.
#define MAXDO   0
#define MAXCS1  1
#define MAXCS2  4
#define MAXCLK 30 // The TX LED has a defined Arduino pin
#define RELAY_PIN 6
#define FAN_PIN 5
#define MOTOR_PIN 11
#define LED_GREEN 8

// initialize the Thermocouple
Adafruit_MAX31855 thermocouple1(MAXCLK, MAXCS1, MAXDO);
Adafruit_MAX31855 thermocouple2(MAXCLK, MAXCS2, MAXDO);

//Defines
float Setpoint;

//Run a fake temperature increase
boolean simulation = false;
boolean linear = true;
float Input_simulation = 75;

//Do a pre-heat before roasting?
boolean preheat = true;

unsigned long startMillis;
unsigned long now;  //Register for the current time at the start of each loop

#if defined(ARDUINO_ARCH_SAMD)
// for Zero, output on USB Serial console, remove line below if using programming port to program the Zero!
 #define Serial SerialUSB
#endif

void setup() {
  Wire.begin();
  Serial.begin(115200);
  
  pinMode(RELAY_PIN, OUTPUT);
  pinMode(FAN_PIN, OUTPUT);
  pinMode(MOTOR_PIN, OUTPUT);
  pinMode(MAXCLK, OUTPUT);
  pinMode(LED_GREEN, OUTPUT);

  analogWrite(RELAY_PIN, 0);
  analogWrite(FAN_PIN, fan_val);
  analogWrite(MOTOR_PIN, motor_val);

  //Flash the start screen
  display_start();

  noInterrupts();           // disable all interrupts
  /** initialize timer1 The point of the timer is to give 250ms trigger
  Caluclation is 1/16MHz * 15625 * 256 = 250ms
  **/
  TCCR1A = 0;
  TCCR1B = 0;
  TCNT1  = 0;
  OCR1A = 15625;            // compare match register 16MHz/256/4Hz
  TCCR1B |= (1 << WGM12);   // CTC mode
  TCCR1B |= (1 << CS12);    // 256 prescaler 
  TIMSK1 |= (1 << OCIE1A);  // enable timer compare interrupt
  interrupts();  //allows interrupts

  startMillis = millis();  //initial start time for ADC sample routine
  
  
  //wait for MAX chip to stabilize if simulation is not happening
  if (simulation) {
    delay(1000);  
    lcd.lcdClear();
  }
}

int roasting_started = 0;
int cooling_started = 0;
unsigned long time_start = 0;
int count = 0;
int SaveState = 0;
int LEDBlink = 1;
boolean RELAY = false;
int x1 = 0;

void loop() {
  digitalWrite(LED_GREEN, LEDBlink);
  LEDBlink = !LEDBlink;
  analogWrite(MOTOR_PIN, motor_val);
  analogWrite(FAN_PIN, fan_val);
  now = millis();//Grab time at start of loop

  //Routine to sample the ADC every 250ms.  The MAX31855 takes up to 100ms per sample to have stable data
  if(interrupt_trigger_flag = true){
    if(sample_temp1 == true){
      Input1 = get_temp(Input1,sample_temp1);
      x1 = round(Input1);
      if (Input1 < 10) sprintf(Input_buffer,"  %d", x1);
      else if (Input1 <= 99) sprintf(Input_buffer," %d", x1);
      else if (Input1 > 99) sprintf(Input_buffer,"%d", x1);
      }
    else {
      Input2 = get_temp(Input2,sample_temp1);
    }
    
    sample_temp1 = !sample_temp1;
    
    //Go ahead and write values to LCD
    refreshlcd();
    interrupt_trigger_flag = false;
  }
  
  if (check_buttons_flag >= 1){
    check_buttons_flag = 0;
    if (button_changed_flag == 1){
      CurrentButton = 15;
      button_changed_flag = 0;
    }
    else {
      PreviousButton = CurrentButton;
      CurrentButton = lcd.readButtons();
      if (CurrentButton != PreviousButton) {button_changed_flag = 1;      
      }
    }
  }
  else CurrentButton = 15;

  handleSerialCommand();
  
  switch (CurrentState) {
    case state_idle:{
      analogWrite(RELAY_PIN, 0);
      RELAY = false;
      motor_val = 0;
  
      if(CurrentButton == 15) CurrentState = state_idle;
      else if (CurrentButton == 14) CurrentState = state_idle_transition;
      else if (CurrentButton == 3) CurrentState = state_idle_to_debug_transition;
      else CurrentState = state_idle;
      
      thermal_power_button();
    }
    break;
    
    case state_idle_transition: {
      lcd.lcdClear();
      if (preheat == true) CurrentState = state_preroast;
      else CurrentState = state_roasting;
      idle_state_flag = false;
      fan_val = 255;
      fan[4] = "255";
      motor_val = 255;
    }
    break;

    case state_idle_to_debug_transition:{
      lcd.lcdClear();
      CurrentState = state_debug;
      idle_state_flag = false;
      char roast[4] = "00";
      int roast_val = 0;
      int fan_val = 0;
      //fan1_ramp_up(4);
    }
    break;

    case state_preroast: {
      motor_val = 0; //don't turn on motor yet
      if (roasting_started == 0) {
        roasting_started = 1;
        time_start = now;
        }
      else roast_time = (now - time_start);
      analogWrite(RELAY_PIN, roast_val);
      RELAY = true;

      thermal_power_button();
      if (!(CurrentButton & 0x02)) CurrentState = state_preroast_transition;
      else CurrentState = state_preroast;
    }
    break;

    case state_preroast_transition:
      lcd.lcdClear();
      preroast_state_flag = false;
      roasting_started = 0;
      CurrentState = state_roasting;
      roast_time = 0;
    break;
   
    case state_roasting: {
      if (roasting_started == 0) {
        roasting_started = 1;
        time_start = now;
        }
      else roast_time = (now - time_start);
      analogWrite(RELAY_PIN, roast_val);
      RELAY = true;
      
      thermal_power_button();

      if (!(CurrentButton & 0x02)) CurrentState = state_roasting_transition;
      else CurrentState = state_roasting;
    }
    break;

    case state_roasting_transition:
      lcd.lcdClear();
      roasting_state_flag = false;
      roasting_started = 0;
      CurrentState = state_cooling;
      roast_time = 0;
    break;
   
    case state_cooling: {
      analogWrite(RELAY_PIN, 0);
      RELAY = false;
      //analogWrite(FAN_PIN, 255);
      Setpoint = 45;

      if (cooling_started == 0) {
        cooling_started = 1;
        time_start = now;
      }
      else{
        cool_time = (now - time_start);
      }

      thermal_power_button();
      
      if(Input1 > Setpoint){
        if (!(CurrentButton & 0x02))
          CurrentState = state_cooling_transition;
        else
          CurrentState = state_cooling;
      }
      else if((Input1 < Setpoint) || (Input1 == Setpoint))
        CurrentState = state_cooling_transition;
      else
        CurrentState = state_cooling;
    } 
    break;

    case state_cooling_transition:
      lcd.lcdClear();
      cooling_started = 0;
      cooling_state_flag = false;
      CurrentState = state_idle;
      cool_time = 0;
      fan_val = 0;
      fan[4] = "  0";
      motor_val = 0;
    break;

    case state_debug: {
      analogWrite(RELAY_PIN, roast_val);
      RELAY = true;
      //analogWrite(FAN_PIN, fan_val);

      if(CurrentButton == 12) CurrentState = state_debug_transition;
      else CurrentState = state_debug;

      thermal_power_button();
      fan_button();
    }
    break;

    case state_debug_transition:
      lcd.lcdClear();
      debug_state_flag = false;
      CurrentState = state_cooling;
    break;
  }
}

void display_start() {
  lcd.lcdClear();
    
  lcd.lcdGoToXY(3,1);
  lcd.lcdWrite("Barrel Man v11");

  lcd.lcdGoToXY(1,2);
  lcd.lcdWrite("Coffee Roasting");
  delay(750);
}

void thermal_power_button(){
  if(!(CurrentButton & 0x08)) {
    if (roast_val == 255) roast_val = 00;
    else roast_val++;
    if (roast_val < 10) sprintf(roast, "  %d",roast_val);
    else if (roast_val < 100) sprintf(roast, " %d",roast_val);
    else sprintf(roast, "%d", roast_val);
  }
  else if (!(CurrentButton & 0x04)) {
    if (roast_val == 00) roast_val = 255;
    else roast_val--;
    if (roast_val < 10) sprintf(roast, "  %d",roast_val);
    else if (roast_val < 100) sprintf(roast, " %d",roast_val);
    else sprintf(roast, "%d", roast_val);
  }
}

void fan_button(){
  if(!(CurrentButton & 0x02)) {
    if (fan_val == 255) fan_val = 00;
    else fan_val++;
    if (fan_val < 10) sprintf(fan, "  %d",fan_val);
    else if (fan_val < 100) sprintf(fan, " %d",fan_val);
    else sprintf(fan, "%d", fan_val);
  }
  else if (!(CurrentButton & 0x01)) {
    if (fan_val == 00) fan_val = 255;
    else fan_val--;
    if (fan_val < 10) sprintf(fan, "  %d",fan_val);
    else if (fan_val < 100) sprintf(fan, " %d",fan_val);
    else sprintf(fan, "%d", fan_val);
  }
}

//This function is to convert the millis to a readable min:sec format
char conv_currtime_disp(unsigned long input_milli){
  unsigned long allSeconds=input_milli/1000;
  int secsRemaining=allSeconds%3600;
  int runMinutes=secsRemaining/60;
  int runSeconds=secsRemaining%60;
  if (roasting_started == 1) sprintf(roast_time_char,"%02d:%02d",runMinutes,runSeconds);
  else if (cooling_started == 1) sprintf(cool_time_char,"%02d:%02d",runMinutes,runSeconds);
}

void handleSerialCommand(){   

    if (Serial.available()>0){
        String msg = Serial.readStringUntil('\n');

        if (msg.indexOf("CHAN;")== 0){  //Ignore this Setting
            Serial.print("#OK");
        }
        else if (msg.indexOf("UNITS;")== 0){

            if (msg.substring(6,7)=="F"){   //Change to Farenheit
                unit_F = true;
                Serial.println("#OK Farenheit");
            }
            else if (msg.substring(6,7)=="C"){  //Change to Celsius
                unit_F = false;
                Serial.println("#OK Celsius");
            }

        }
        else if (msg.indexOf("READ")==0){   //Send Temps
           Command_READ();
        }
        
        else if (msg.indexOf("FILT")== 0){
          Serial.print("#OK");
        }
       }
}

//Send Data
void Command_READ(){    
    Serial.print("0.00,"); //ambient
    Serial.print(Input1);
    Serial.print(",");
    Serial.print(Input2);
    Serial.println(",0.00,0.00");
}


void fan1_ramp_up(int step_size) {
  fan_val = 0;
  for (int i = 0; i <= 35; i++) {
    fan_val = fan_val+step_size;
    analogWrite(FAN_PIN, fan_val);
    delay(10); //To give time for the current to settle after step
  }
  sprintf(fan, "%d", fan_val);
}

ISR(TIMER1_COMPA_vect) {
  interrupt_trigger_flag = true;
  check_buttons_flag++;
}

//The state flags are set so the second time around it doesn't refresh the entire display
void refreshlcd(){
    if (CurrentState == state_idle) {
      display_idle();
      idle_state_flag = true;
      /*Serial.print(F(",Ambient,"));
      Serial.print(thermocouple.readInternal());
      Serial.print(F(",Temp,"));
      Serial.println(Input1);
      Serial.print("Humidity:");
      Serial.print(humidity);
      Serial.println("%");*/
    }
    else if (CurrentState == state_roasting) {
      /*Serial.print(F(",Ambient,"));
      Serial.print(thermocouple.readInternal());
      Serial.print(F(",Temp,"));
      Serial.print(Input1);
      Serial.print(F(",roast value,"));
      Serial.println(roast);*/
      conv_currtime_disp(roast_time);
      display_roasting();
      roasting_state_flag = true;
    }
    else if (CurrentState == state_cooling) {
     /* Serial.print(F(",Ambient,"));
      Serial.print(thermocouple.readInternal());
      Serial.print(F(",Temp,"));
      Serial.println(Input1);*/
      conv_currtime_disp(cool_time);
      display_cooling();
      cooling_state_flag = true;
    }
    else if (CurrentState == state_preroast) {
     /* Serial.print(F(",Ambient,"));
      Serial.print(thermocouple.readInternal());
      Serial.print(F(",Temp,"));
      Serial.println(Input1);
      Serial.print(F(",roast value,"));
      Serial.println(CurrentState);*/ 
      conv_currtime_disp(roast_time);
      display_preroast();
      preroast_state_flag = true;
    }
    else if (CurrentState == state_debug) {
      display_debug();
      debug_state_flag = true;
    }
}

void display_idle() {
    if (idle_state_flag == false) {
    lcd.lcdGoToXY(1,1);
    lcd.lcdWrite("Idle  ");
    lcd.lcdGoToXY(7,1);
    lcd.lcdWrite("Temp = ");
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(1,2);
    lcd.lcdWrite("Start? ");
    lcd.lcdGoToXY(8,2);
    lcd.lcdWrite("PWR = ");
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
  else {
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
}

void display_preroast() {
  if (preroast_state_flag == false){
    lcd.lcdGoToXY(1,1);
    lcd.lcdWrite("Heat  ");
    lcd.lcdGoToXY(7,1);
    lcd.lcdWrite("Temp = ");
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(1,2);
    lcd.lcdWrite(roast_time_char);
    lcd.lcdGoToXY(6,2);
    lcd.lcdWrite(" End?");
    lcd.lcdGoToXY(12,2);
    lcd.lcdWrite("  ");
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
  else {
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(1,2);
    lcd.lcdWrite(roast_time_char);
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
}

void display_roasting() {
  if (roasting_state_flag == false){
    lcd.lcdGoToXY(1,1);
    lcd.lcdWrite("Roast ");
    lcd.lcdGoToXY(7,1);
    lcd.lcdWrite("Temp = ");
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(1,2);
    lcd.lcdWrite(roast_time_char);
    lcd.lcdGoToXY(6,2);
    lcd.lcdWrite(" Stop?");
    lcd.lcdGoToXY(12,2);
    lcd.lcdWrite("  ");
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
  else {
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(1,2);
    lcd.lcdWrite(roast_time_char);
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
}

void display_cooling() {
  if (cooling_state_flag == false){
    lcd.lcdGoToXY(1,1);
    lcd.lcdWrite("Cool ");
    lcd.lcdGoToXY(7,1);
    lcd.lcdWrite("Temp = ");
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(1,2);
    lcd.lcdWrite(cool_time_char);
    lcd.lcdGoToXY(6,2);
    lcd.lcdWrite(" Stop?");
    lcd.lcdGoToXY(12,2);
    lcd.lcdWrite("  ");
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
  else {
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(1,2);
    lcd.lcdWrite(cool_time_char);
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
}

void display_debug() {
  if (debug_state_flag == false){
    lcd.lcdGoToXY(1,1);
    lcd.lcdWrite("Debug ");
    lcd.lcdGoToXY(7,1);
    lcd.lcdWrite("Temp = ");
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(1,2);
    lcd.lcdWrite("Fan ");
    lcd.lcdGoToXY(5,2);
    lcd.lcdWrite(fan);
    lcd.lcdGoToXY(8,2);
    lcd.lcdWrite("  SSR ");
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
  else {
    lcd.lcdGoToXY(14,1);
    lcd.lcdWrite(Input_buffer);
    lcd.lcdGoToXY(5,2);
    lcd.lcdWrite(fan);
    lcd.lcdGoToXY(14,2);
    lcd.lcdWrite(roast);
  }
}

float get_temp(float temp,boolean read_sensor_one) {
  float c;
  if (!simulation){
    if (unit_F == true) {
      if(read_sensor_one == true) c = thermocouple1.readFahrenheit();
      else c = thermocouple2.readFahrenheit();
    }
    else {
      if(read_sensor_one == true) c = thermocouple1.readCelsius();
      else c = thermocouple2.readCelsius();
    }
    if (isnan(c))
    {
      c = temp; 
    }
    else c = (c + temp)/2;
  }
  else c = simulation_temp();
  return c;
}
    
float simulation_temp(void) {
  if (CurrentState == 0) {
    count = 0;
    if ((Input_simulation > 0) || (Input_simulation < 78)) Input_simulation = 77;
    else Input_simulation = (Input_simulation - Input_simulation/9);
  }
    else {
    if (RELAY == false) {
      if (Input_simulation > 77 && Input_simulation < 100 )       Input_simulation = Input_simulation-0.0089;
      else if (Input_simulation > 100 && Input_simulation < 125 ) Input_simulation = Input_simulation-0.0128;
      else if (Input_simulation > 125 && Input_simulation < 150 ) Input_simulation = Input_simulation-0.0321;
      else if (Input_simulation > 150 && Input_simulation < 200 ) Input_simulation = Input_simulation-0.081;
      else if (Input_simulation > 200 && Input_simulation < 250 ) Input_simulation = Input_simulation-0.12;
      else if (Input_simulation > 250 && Input_simulation < 300 ) Input_simulation = Input_simulation-0.14;
      else if (Input_simulation > 300 && Input_simulation < 350 ) Input_simulation = Input_simulation-0.16;
      else if (Input_simulation > 350 && Input_simulation < 400 ) Input_simulation = Input_simulation-0.18;
      else if (Input_simulation > 400 && Input_simulation < 450 ) Input_simulation = Input_simulation-0.2;
      else if (Input_simulation > 450 && Input_simulation < 500 ) Input_simulation = Input_simulation-0.22;
      else Input_simulation = Input_simulation;
    }
    else {
      if (linear) {
        if (Input_simulation < 100)                                Input_simulation = Input_simulation + 0.024;
        else if (Input_simulation > 100 && Input_simulation < 150) Input_simulation = Input_simulation + 0.022;
        else if (Input_simulation > 150 && Input_simulation < 200) Input_simulation = Input_simulation + 0.018;
        else if (Input_simulation > 200 && Input_simulation < 250) Input_simulation = Input_simulation + 0.014;
        else if (Input_simulation > 250 && Input_simulation < 300) Input_simulation = Input_simulation + 0.0081;
        else if (Input_simulation > 300 && Input_simulation < 350) Input_simulation = Input_simulation + 0.0061;
        else if (Input_simulation > 350 && Input_simulation < 375) Input_simulation = Input_simulation + 0.00321;
        else if (Input_simulation > 375 && Input_simulation < 400) Input_simulation = Input_simulation + 0.00128;
        else if (Input_simulation > 400 && Input_simulation < 425) Input_simulation = Input_simulation + 0.00089;
        else if (Input_simulation > 425 && Input_simulation < 500) Input_simulation = Input_simulation + 0.000357;
        else Input_simulation = Input_simulation;
      }
      else {
        Input_simulation = 0.0005*pow(count,3)-0.1257*pow(count,2)+11.012*count +51.339;
        count++;
        }
      }
    }
  return Input_simulation;
}

[blh64]

You don't need interrupts to read your sensors every 250ms. Look at the Blink Without Delay example in the IDE (File->examples->02.digital->Blink Without Delay) to see how to track elapsed time. Then, read this tutorial: Serial Input Basics - updated to see how to handle Serial input without waiting for an entire line to arrive before processing it.

After that, check this out: several things at the same time which explains how you can break things up to small things each time through loop()

As for your code, it is hard to comment since it is not a complete sketch and lacks import things like variable declarations, etc. It is very rarely (ever) a good idea to post code snippets.

[nslattengren]

Thanks for the feedback about the serial input. Will see if I can integrate that behavior with my code.

I added the rest of my code; it's a lot of lines. So I hope it is not overwhelming.

I originally did a lot of my code with the millis() behavior. But I started running into trouble trying to keep the serial and some other events from impacting my display/temperature readings. Maybe I need to take a fresh look at it again, but I have a lot of things happening at the same time (three PWMs for example).

[blh64]

@nslattengren

// digital IO pins.
#define MAXDO   0
#define MAXCS1  1

Problem #1 - pins 0 and 1 are used for Serial. You can not use them for your software SPI at the same time. rewire your board to use pins 2 and 3 or any other free pins.

#include "LCD16x2.h"

Link to this library? It is not in the IDE library manager list. Typically a display needs a .begin() function to get it up and running. I do not see that in your code. Is the display connected by i2c (aka Wire)?

analogWrite(RELAY_PIN, 0);

If this truly is a relay, it will never function at PWM frequencies. Relays are more of a digital switch. If you do need to turn something on/off that rapidly, you need to use a logic level MOSFET

interrupt_trigger_flag
check_buttons_flag
button_changed_flag

Are these variables declared in "coffee_roaster.h"? If so, you need to post that code as well.

I think your code could be improved if you google "Finite State Machine" and apply some of those learnings. The code has some transition states and some regular state. In the very basic framework, you have 3 functions. beginState(), updateState() and endState(). Each of these functions contains a case/switch statement to deal with the state variabled passed in

beginState - do whatever is necessary at the start of a new state. Update the global 'currentState' variable

updateState - check elapsed time or sensors or button states and possibly transition to a new state

endState - do whatever needs to happen when a state is about to exit

Then, you loop looks like this

void loop() {
  currentTime = millis();
  if ( currentTime - lastSampleTime >= sampleInterval ) {
    lastSampleTime = currentTime;
    readSensors();
  }

  readButtons();

  checkSerialInput();

  updateState(currentState);
}

I would also suggest you remove about 90% of those sprintf() statements everywhere in the code, except for in the lcd routines that actually display the values. Those other routines can just deal with the floating point number directly, etc. The function that displays them should be the function that formats them.

[nslattengren]

Hi blh64,

Wow appreciate the continued details.

I knew my state machine wasn't the best coded version. Let me see about improving it.

Problem #1 - pins 0 and 1 are used for Serial. You can not use them for your software SPI at the same time. rewire your board to use pins 2 and 3 or any other free pins.

I didn't know the serial port behaved in that way. Hmm that makes things difficult for me. It's not an easy change. (I would have to cut traces and rewire it).

If this truly is a relay, it will never function at PWM frequencies. Relays are more of a digital switch. If you do need to turn something on/off that rapidly, you need to use a logic level MOSFET

The relay pin is probably a misnomer as it is actually a SSR. So the PWM does allow me to control the amount of power going into my heating element.

Link to this library? It is not in the IDE library manager list. Typically a display needs a .begin() function to get it up and running. I do not see that in your code. Is the display connected by i2c (aka Wire)?

The display/buttons are I2C based. The buttons don't necessarily need to be I2C (I have pins available), but I didn't want to go making a custom display board for that just yet.

SHIELD-LCD16x2 - Open Source Hardware Board

I would also suggest you remove about 90% of those sprintf() statements everywhere in the code, except for in the lcd routines that actually display the values. Those other routines can just deal with the floating point number directly, etc. The function that displays them should be the function that formats them.

Everything is converted into I2C before being sent over. I think I had to format it correctly before that so it went to the right spot. I can play with it to see, but not sure I can get away from it easily.

h file

#define state_idle 0 //Idle state
#define state_idle_transition 1
#define state_idle_to_debug_transition 2
#define state_roasting 3 //Roast started
#define state_roasting_transition 4
#define state_cooling 5 //Planned cooling behavior
#define state_cooling_transition 6
#define state_preroast 7
#define state_preroast_transition 8
#define state_debug 9
#define state_debug_transition 10

#define LED_BUILTIN_TX 30

int CurrentState = 0;  

//Initialize all the state flags
boolean idle_state_flag = false;
boolean preroast_state_flag = false;
boolean roasting_state_flag = false;
boolean cooling_state_flag = false;
boolean debug_state_flag = false;
boolean interrupt_trigger_flag = false;
int check_buttons_flag = false;
boolean button_changed_flag = false;
int ADC_sample_flag = 0;
const unsigned long ADC_sample_period = 100;
boolean not_a_number_flag = false;

boolean unit_F = false;
boolean sample_temp1 = true;

//Initialize Roast type and default value
char roast[4] = "250";
int roast_val = 250;
char fan[4] = "  0";
int fan_val = 0;
int motor_val = 0;

//Intialize time counters
unsigned long roast_time = 0;
char roast_time_char[6] = "00:00";
unsigned long cool_time = 0;
char cool_time_char[6] = "00:00";

//Initialize Thermal temp in Celsius
float Input1 = 10;
float Input2 = 10;
char Input_buffer [4] = "  0";

[blh64]

This might get you going... I don't have your HW so you get to test it
A lot of the variables are gone and things just depend on the currentState.

Also, I tweaked the LCD162 library to clean up a done of warnings (const char* to char*)
coffee_roaster.h (2.0 KB)
coffee_roaster.ino (17.4 KB)
LCD16x2.cpp (5.2 KB)
LCD16x2.h (1.6 KB)

[nslattengren]

I did not expect the significant clean-up! Thank you! I do appreciate the effort you put into it.

I need to play with how you did the display since I was trying to reduce the amount of I2C traffic each go around and allow my loop to be nimble (I was considering to add a PID filter at some point).