Debug: Getting error while converting data from char to int after

Projects Programming
1

My program stores data into a buffer and then the numbers are extracted into a 2-D array before the are place into a single integer array. The code give correct output during the first run, but during the consecutive run gives garbage value along with some correct values. Can somebody debug the program

Data RECEIVED: 42#111#106#180#81#122#88#126#55#76#92#136#145#76#180#55#$

OUTPUT:42 -27679 1249 18081 81 12288 88 12655 55 76 92 -16912 14576 76 18055 55

#include<avr/io.h>
#include<stdlib.h>
#include<stdio.h>

char store_data[65]; // acts as buffer
int values[16] = {0}; // stores numbers as integer
int flag=0;
char fcall[16][3]; // used to extract number from sting as characters
int i =0, j = 0, k=1 , x=0 , z=0, m=0,n=0; 
int incomingByte=0;

void setup()
{
  Serial1.begin(9600);
}

void loop()
{
  if (Serial1.available())
  {
    flag=0;
    
    incomingByte = Serial1.read();
    
    if(incomingByte !='

)
   {
     store_data[x]=incomingByte; //store in buffer
     delay(50);
     Serial1.print(store_data[x]);
     delay(50);
     x++;
 
   if(incomingByte == '#') //# indicates end of a number ,there are 16 # in the code
     {
       k++;
     }
   }
   
   else if((k<16))
     {
       Serial1.print(" Resend Data "); //acknowledgement
       k=0;
     
     }
     else if((incomingByte =='


) && (k=16)) // $ indicates end off message
      { 
        store_data[x]=incomingByte;
        delay(50);
        Serial1.print(store_data[x]);
        delay(50);
        x++;
        Serial1.print(" Data Recieved ");  //acknowledgement
        delay(50);
        Serial1.print(k,DEC); // counts number of #
        delay(50);
        Serial1.print("   ");
        delay(50);
        Serial1.print(x,DEC); //counts number of bytes
        delay(50);
        Serial1.print("   ");
        k=0;
        x=0;
        z=0;
        flag = 1; 
      
      }
  


   if (flag)
   {
     while(z<65)
     {  
       if(store_data[z] == '

) // $ - End of message
      {
        for(m=0;m<16;m++)
        {
          Serial1.print(values[m],DEC);
          Serial1.print(" ");
          delay(100);
          z=65;
        }
       
        int values[16] = {0};
        fcall[i][j] = 0;
        i = 0;
        j = 0;
        x=0;
        flag=0;
      }
      else if(store_data[z] == '#') // # - End of a particular value
      {
        values[i]=atoi(fcall[i]); //converts character to number
        fcall[i][j] = 0;
        i++;
        j = 0;
        delay(2);
      }
      else
      {
        fcall[i][j] = store_data[z]; //extracts number from string bit by bit
        delay(10);
        j++;
      }
      z++;
   }
 }
 }
}

2

The first thing that I would suggest is to repost your code and put it into [ code ] tags to prevent the current unreadable format including the HTML bullets.

3

I see AWOL took care of those code tags. Thanks, AWOL! :slight_smile:

This could cause a bit of trouble if it is doing what I think it is.

char fcall[16][3]; // used to extract number from sting as characters

If you are storing more than two characters, it will cause problems. Note all problems occur when the number is longer than two digits. It requires an additional character for the terminating zero.

4

Well-spotted SurferTim!

5

So can you please tell me what could i do?? I have a max of 3 digit number.

6

See reply #2

7

I did not understand what do you mean by "requires an additional character for the terminating zero". Sorry but i am a newbie.

8

C strings need space for each character plus a terminating zero to mark the end of the string. So, a 3 character string requires 4 spaces to store it in. Your fcall array only allows for 3 spaces hence the problem with 3 character strings in your code.

9

hey thank you guys but i got the answer.

10

The answer is:

char fcall[16][4]; // used to extract number from sting as characters