Does power cycling shorten Arduino lifetime

ardly:
How often would you have to cycle the power to an Arduino to have any significant impact on the lifetime of the device?

Depends on the environent.

Whilst power cylling on its own should not have a significant impact on lifetime in itself, it could have an impact if as a result of the power cycling the 'Arduino' goes through significant temperature cycling, continuously heating up from very cold for instance.