Hi folks,
Been doing a few bits with Arduino for years and generally have got along fine (Historically I've done VB, VC, bash, perl, php, c++ coding) but this latest program is really getting to me!
The basic idea for the code is as follows:
Watch for movement from a bank of 5 PIR sensors connected to analog0 through 4
If movement, stop the sequencer and switch on the relevant digital output (digital outputs 7 through 12), wait a few moments then turn it off again and wait a short delay for any further PIR movement.
If movement has just stopped, wait within a blinking program for a short period (switching between output 11 and 12 alternatively, around 1 change per second)
If no movement, run a specific sequence of outputs
So not wholly complicated but a few different 'parts' to the code which has got me a little confused.
The whole of my code is below, and at the moment the PIR function is erratic, in that it doesn't always detect movement, and when it does it turns the output off quickly and then waits (blinking program) then returns to the sequence.
I think the main issue is my PIR detection code, so that is probably where I need the pointers. Does anybody know how I could tidy this up a little?
/* Christmas lights 2013 */
/* Andy Brown */
/* define inputs (14 is analog0 15 is analog1) */
int pir[] = {14,15,16,17,18};
int led[] = {7,8,9,10,11,12};
int ledstate[] = {LOW,LOW,LOW,LOW,LOW,LOW};
int val = 0; // variable for reading the pin status
int movement_trigger = 0;
int normal_sequence = 0;
int anymovement = 0;
void setup() {
pinMode(led[0], OUTPUT);
pinMode(led[1], OUTPUT);
pinMode(led[2], OUTPUT);
pinMode(led[3], OUTPUT);
pinMode(led[4], OUTPUT);
pinMode(led[5], OUTPUT);
pinMode(pir[0], INPUT); // declare sensor as input
pinMode(pir[1], INPUT);
pinMode(pir[2], INPUT);
pinMode(pir[3], INPUT);
pinMode(pir[4], INPUT);
ledstate[0] = LOW;
ledstate[1] = LOW;
ledstate[2] = LOW;
ledstate[3] = LOW;
ledstate[4] = LOW;
ledstate[5] = LOW;
digitalWrite(led[0], HIGH);
digitalWrite(led[1], HIGH);
digitalWrite(led[2], HIGH);
digitalWrite(led[3], HIGH);
digitalWrite(led[4], HIGH);
digitalWrite(led[5], HIGH);
Serial.begin(9600);
}
void loop(){
/* Check each PIR */
for (int i=0; i <= 5; i++){
val = digitalRead(pir[i]);
if (val == HIGH) {
if (ledstate[i] == HIGH) {
if (anymovement == 0) {
digitalWrite(led[0], HIGH);
digitalWrite(led[1], HIGH);
digitalWrite(led[2], HIGH);
digitalWrite(led[3], HIGH);
digitalWrite(led[4], HIGH);
digitalWrite(led[5], HIGH);
};
Serial.println("PIR (on) detection:");
Serial.println(i);
digitalWrite(led[i], LOW);
movement_trigger = 1;
ledstate[i] = LOW;
};
} else {
if (ledstate[i] == LOW) {
anymovement=0;
Serial.println("PIR (off) detection:");
Serial.println(i);
digitalWrite(led[i], HIGH);
ledstate[i] = HIGH;
movement_trigger = 2;
};
};
};
/* If nothing happened then we do the sequencer */
if (movement_trigger > 1) { /* 2 means it just turned off */
movement_trigger += 1;
};
if (movement_trigger < 20) {
if ( (movement_trigger % 2) == 0) {
digitalWrite(led[4], HIGH);
digitalWrite(led[5], LOW);
} else {
digitalWrite(led[4], LOW);
digitalWrite(led[5], HIGH);
};
};
if (movement_trigger > 20 || movement_trigger == 0) {
sequencer();
};
delay ( 400 );
/*docoloursequence();*/
}
void sequencer() {
/* Do the sequence */
/* normal_sequence = 0 all on
1 = 0 2 4
2 = 1 3 5
3 = 0 5 3
4 = 2 1 4
5 = 012345 flicker */
Serial.println("Sequence");
Serial.println(normal_sequence);
switch(normal_sequence) {
case 35:
case 36:
digitalWrite(led[0], HIGH);
digitalWrite(led[1], HIGH);
digitalWrite(led[2], HIGH);
digitalWrite(led[3], HIGH);
digitalWrite(led[4], HIGH);
digitalWrite(led[5], HIGH);
break;
case 33:
case 34:
digitalWrite(led[0], HIGH);
digitalWrite(led[1], LOW);
digitalWrite(led[2], HIGH);
digitalWrite(led[3], LOW);
digitalWrite(led[4], LOW);
digitalWrite(led[5], LOW);
break;
case 31:
case 32:
digitalWrite(led[0], HIGH);
digitalWrite(led[1], HIGH);
digitalWrite(led[2], HIGH);
digitalWrite(led[3], HIGH);
digitalWrite(led[4], HIGH);
digitalWrite(led[5], HIGH);
break;
case 29:
case 30:
digitalWrite(led[0], HIGH);
digitalWrite(led[1], LOW);
digitalWrite(led[2], HIGH);
digitalWrite(led[3], LOW);
digitalWrite(led[4], LOW);
digitalWrite(led[5], HIGH);
break;
case 25:
case 26:
case 27:
case 28:
digitalWrite(led[0], LOW);
digitalWrite(led[1], LOW);
digitalWrite(led[2], LOW);
digitalWrite(led[3], LOW);
digitalWrite(led[4], LOW);
digitalWrite(led[5], HIGH);
break;
case 21:
case 22:
case 23:
case 24:
digitalWrite(led[0], HIGH);
digitalWrite(led[1], LOW);
digitalWrite(led[2], LOW);
digitalWrite(led[3], LOW);
digitalWrite(led[4], HIGH);
digitalWrite(led[5], LOW);
break;
case 17:
case 18:
case 19:
case 20:
digitalWrite(led[0], HIGH);
digitalWrite(led[1], HIGH);
digitalWrite(led[2], LOW);
digitalWrite(led[3], LOW);
digitalWrite(led[4], HIGH);
digitalWrite(led[5], LOW);
break;
case 13:
case 14:
case 15:
case 16:
digitalWrite(led[0], HIGH);
digitalWrite(led[1], HIGH);
digitalWrite(led[2], HIGH);
digitalWrite(led[3], LOW);
digitalWrite(led[4], LOW);
digitalWrite(led[5], HIGH);
break;
case 9:
case 10:
case 11:
case 12:
digitalWrite(led[0], HIGH);
digitalWrite(led[1], HIGH);
digitalWrite(led[2], LOW);
digitalWrite(led[3], HIGH);
digitalWrite(led[4], HIGH);
digitalWrite(led[5], HIGH);
break;
case 5:
case 6:
case 7:
case 8:
digitalWrite(led[0], HIGH);
digitalWrite(led[1], LOW);
digitalWrite(led[2], HIGH);
digitalWrite(led[3], HIGH);
digitalWrite(led[4], LOW);
digitalWrite(led[5], HIGH);
break;
case 0:
case 1:
case 2:
case 3:
case 4:
digitalWrite(led[0], LOW);
digitalWrite(led[1], HIGH);
digitalWrite(led[2], HIGH);
digitalWrite(led[3], HIGH);
digitalWrite(led[4], HIGH);
digitalWrite(led[5], LOW);
break;
};
normal_sequence++;
if (normal_sequence > 36) {normal_sequence=0;};
};
Thanks in advance folks!
Andy
