Error compiling for ATmega1284

Leetut · July 9, 2021, 11:29am

my sketch compiles for 328p but not Atmega1284
I'm using usbasp(mighty core)
blink uploads and works fine
anyone know how to fix this?

/Users/lee/Library/Arduino15/packages/MightyCore/hardware/avr/2.1.3/cores/MCUdude_corefiles/Arduino.h:126:22: error: statement-expressions are not allowed outside functions nor in template-argument lists
 #define min(a,b)     ({ typeof (a) _a = (a); typeof (b) _b = (b); _a < _b ? _a : _b; })
                      ^
/Users/lee/Desktop/fvduino Atmega1284 Breadboard/fvduino/fvduino.ino:240:23: note: in expansion of macro 'min'
 const uint8_t NALGO = min(99, sizeof(algodata) / sizeof(AlgoDatum));
                       ^~~
Using library EEPROM at version 2.0 in folder: /Users/lee/Library/Arduino15/packages/MightyCore/hardware/avr/2.1.3/libraries/EEPROM 
Using library ButtonEvents-master at version 1.0.1 in folder: /Users/lee/Documents/Arduino/libraries/ButtonEvents-master 
Using library Bounce2 at version 2.56 in folder: /Users/lee/Documents/Arduino/libraries/Bounce2 
Using library Adafruit_NeoPixel at version 1.7.0 in folder: /Users/lee/Documents/Arduino/libraries/Adafruit_NeoPixel 
exit status 1
Error compiling for board ATmega1284.

fvduino.ino (33.1 KB)

PieterP · July 9, 2021, 11:47am

Looks like a bug in the MightyCore, min and max shouldn't be non-standard statement-expressions, but function templates:

github.com

arduino/ArduinoCore-API/blob/173e8eadced2ad32eeb93bcbd5c49f8d6a055ea6/api/Common.h#L122-L147


      
          #ifdef __cplusplus
            template<class T, class L> 
            auto min(const T& a, const L& b) -> decltype((b < a) ? b : a)
            {
              return (b < a) ? b : a;
            }
          
          
  template<class T, class L> 
            auto max(const T& a, const L& b) -> decltype((b < a) ? b : a)
            {
              return (a < b) ? b : a;
            }
          #else
          #ifndef min
          #define min(a,b) \
             ({ __typeof__ (a) _a = (a); \
                 __typeof__ (b) _b = (b); \
               _a < _b ? _a : _b; })
          #endif
          #ifndef max

This file has been truncated. show original

pert · July 9, 2021, 12:17pm

In order to make all relevant information available to all who are interested in this subject, I'll share a link to @Leetut's issue report in the MightyCore repo:

github.com/MCUdude/MightyCore

min/max bug

opened 12:13PM - 09 Jul 21 UTC

closed 05:23PM - 24 Apr 22 UTC

leetut

my code won't compile using mightycore, I was told its because of a bug in the …MightyCore? min and max shouldn't be non-standard statement-expressions, but function templates: ``` template<class T, class L> auto min(const T& a, const L& b) -> decltype((b < a) ? b : a) { return (b < a) ? b : a; } template<class T, class L> auto max(const T& a, const L& b) -> decltype((b < a) ? b : a) { return (a < b) ? b : a; } #else #ifndef min #define min(a,b) \ ({ __typeof__ (a) _a = (a); \ __typeof__ (b) _b = (b); \ _a < _b ? _a : _b; }) #endif #ifndef max ``` my compile error: ```/Users/lee/Library/Arduino15/packages/MightyCore/hardware/avr/2.1.3/cores/MCUdude_corefiles/Arduino.h:126:22: error: statement-expressions are not allowed outside functions nor in template-argument lists #define min(a,b) ({ typeof (a) _a = (a); typeof (b) _b = (b); _a < _b ? _a : _b; }) ^ /Users/lee/Desktop/fvduino Atmega1284 Breadboard/fvduino/fvduino.ino:240:23: note: in expansion of macro 'min' const uint8_t NALGO = min(99, sizeof(algodata) / sizeof(AlgoDatum)); ^~~ Using library EEPROM at version 2.0 in folder: /Users/lee/Library/Arduino15/packages/MightyCore/hardware/avr/2.1.3/libraries/EEPROM Using library ButtonEvents-master at version 1.0.1 in folder: /Users/lee/Documents/Arduino/libraries/ButtonEvents-master Using library Bounce2 at version 2.56 in folder: /Users/lee/Documents/Arduino/libraries/Bounce2 Using library Adafruit_NeoPixel at version 1.7.0 in folder: /Users/lee/Documents/Arduino/libraries/Adafruit_NeoPixel exit status 1 Error compiling for board ATmega1284. ``` anyway to fix this?

system · November 6, 2021, 12:17pm

This topic was automatically closed 120 days after the last reply. New replies are no longer allowed.