Error expected '}' at end of input

Projects Programming
1

Hi,

I would like to get a set of eyes on some code I am writing to control windows in a car. I am going to be using a mega and that's why my pin count goes so high. I for the life of me do not see where I missed entering a bracket or where I missed a bracket. When I verify the code, I get this error...

In file included from C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino/Arduino.h:23:0,

from C:\Users\joshua.amune\OneDrive\Documents\Camaro\Wiring\Window\Arduino_Window\Arduino_Window.ino:34:

c:\program files (x86)\arduino\hardware\tools\avr\avr\include\stdlib.h: In function 'void setup()':

c:\program files (x86)\arduino\hardware\tools\avr\avr\include\stdlib.h:54:8: error: expected unqualified-id before string constant

extern "C" {

^

Arduino_Window:163: error: expected '}' at end of input

}

^

exit status 1
expected '}' at end of input

Any help is appreciated.
Thanks

//Input/Output pin setup
int Win_1_Rel_Up = 10;
int Win_1_Rel_Down = 11;
int Win_1_Rel_Up_Sig = 12;
int Win_1_Rel_Down_Sig = 13;
int Win_3_Rel_Up = 30;
int Win_3_Rel_Down = 31;
int Win_3_Rel_Up_Sig = 32;
int Win_3_Rel_Down_Sig = 33;

int Win_4_Rel_Up = 40;
int Win_4_Rel_Down = 41;
int Win_Lock = 14;
int Win_1_Control = 15;
int Win_2_Control = 16;
int Win_3_Control = 17;
int Win_4_Control = 18;

int Win_2_Rel_Up = 20;
int Win_2_Rel_Down = 21;
int Win_2_Rel_Up_Sig = 22;
int Win_2_Rel_Down_Sig = 23;

int Win_4_Rel_Up_Sig = 42;
int Win_4_Rel_Down_Sig = 43;

//Variables
int Win_2_Lock = 0;
int Win_3_Lock = 0;
int Win_4_Lock = 0;

void setup()
{
#include "Arduino.h"
pinMode(Win_1_Rel_Up, OUTPUT);
pinMode(Win_1_Rel_Down, OUTPUT);
pinMode(Win_1_Rel_Up_Sig, INPUT_PULLUP);
pinMode(Win_1_Rel_Down_Sig, INPUT_PULLUP);
pinMode(Win_Lock, INPUT_PULLUP);
pinMode(Win_1_Control, INPUT_PULLUP);
pinMode(Win_2_Control, INPUT_PULLUP);
pinMode(Win_3_Control, INPUT_PULLUP);
pinMode(Win_4_Control, INPUT_PULLUP);

pinMode(Win_2_Rel_Up, OUTPUT);
pinMode(Win_2_Rel_Down, OUTPUT);
pinMode(Win_2_Rel_Up_Sig, INPUT_PULLUP);
pinMode(Win_2_Rel_Down_Sig, INPUT_PULLUP);

pinMode(Win_3_Rel_Up, OUTPUT);
pinMode(Win_3_Rel_Down, OUTPUT);
pinMode(Win_3_Rel_Up_Sig, INPUT_PULLUP);
pinMode(Win_3_Rel_Down_Sig, INPUT_PULLUP);

pinMode(Win_4_Rel_Up, OUTPUT);
pinMode(Win_4_Rel_Down, OUTPUT);
pinMode(Win_4_Rel_Up_Sig, INPUT_PULLUP);
pinMode(Win_4_Rel_Down_Sig, INPUT_PULLUP);
}

void loop()
{
#include "Arduino.h"
//Window Lock
if(digitalRead(Win_Lock) == LOW)
{
Win_2_Lock = 1;
Win_3_Lock = 1;
Win_4_Lock = 1;
}

//Window 1 Control - Driver's Window
//Window 1 Up
if(digitalRead(Win_1_Rel_Up_Sig) == LOW && (digitalRead(Win_Lock) == LOW || digitalRead(Win_1_Control) == LOW))
{
digitalWrite(Win_1_Rel_Up, LOW);
}
//Window 1 Down
else if(digitalRead(Win_1_Rel_Down_Sig) == LOW && (digitalRead(Win_Lock) == LOW || digitalRead(Win_1_Control) == LOW))
{
digitalWrite(Win_1_Rel_Down, LOW);
}

//Window 2 Up
else if(digitalRead(Win_1_Rel_Up_Sig) == LOW && digitalRead(Win_2_Control) == LOW)
{
digitalWrite(Win_2_Rel_Up, LOW);
Win_2_Lock = 1;
}
//Window 2 Down
else if(digitalRead(Win_1_Rel_Down_Sig) == LOW && digitalRead(Win_2_Control) == LOW)
{
digitalWrite(Win_2_Rel_Down, LOW);
Win_2_Lock = 1;
}

//Window 3 Up
else if(digitalRead(Win_1_Rel_Up_Sig) == LOW && digitalRead(Win_3_Control) == LOW)
{
digitalWrite(Win_3_Rel_Up, LOW);
Win_3_Lock = 1;
}
//Window 3 Down
else if(digitalRead(Win_1_Rel_Down_Sig) == LOW && digitalRead(Win_3_Control) == LOW)
{
digitalWrite(Win_3_Rel_Down, LOW);
Win_3_Lock = 1;
}

//Window 4 Up
else if(digitalRead(Win_1_Rel_Up_Sig) == LOW && digitalRead(Win_4_Control) == LOW)
{
digitalWrite(Win_4_Rel_Up, LOW);
Win_4_Lock = 1;
}
//Window 4 Down
else if(digitalRead(Win_1_Rel_Down_Sig) == LOW && digitalRead(Win_4_Control) == LOW)
{
digitalWrite(Win_4_Rel_Down, LOW);
Win_4_Lock = 1;
}

//Window 2 Control - Passenger Window
//Window 2 Up
if(digitalRead(Win_2_Rel_Up_Sig) == LOW && Win_2_Lock == 0)
{
digitalWrite(Win_2_Rel_Up, LOW);
}
//Window 2 Down
else if(digitalRead(Win_2_Rel_Down_Sig) == LOW && Win_2_Lock == 0)
{
digitalWrite(Win_2_Rel_Down, LOW);
}

//Window 3 Control - Driver Rear Window
//Window 3 Up
if(digitalRead(Win_3_Rel_Up_Sig) == LOW && Win_3_Lock == 0)
{
digitalWrite(Win_3_Rel_Up, LOW);
}
//Window 3 Down
else if(digitalRead(Win_3_Rel_Down_Sig) == LOW && Win_3_Lock == 0)
{
digitalWrite(Win_3_Rel_Down, LOW);
}

//Window 4 Control - Passenger Rear Window
//Window 4 Up
if(digitalRead(Win_4_Rel_Up_Sig) == LOW && Win_4_Lock == 0)
{
digitalWrite(Win_4_Rel_Up, LOW);
}
//Window 4 Down
else if(digitalRead(Win_4_Rel_Down_Sig) == LOW && Win_4_Lock == 0)
{
digitalWrite(Win_4_Rel_Down, LOW);
}

//Window Lock clean up
Win_2_Lock = 0;
Win_3_Lock = 0;
Win_4_Lock = 0;
}

2

This goes at the top of your sketch, you have it in loop():
#include "Arduino.h"

Always use code tags when showing your sketch to us.
use the </> icon in the posting menu.

.

3

Try using "auto formatter" it MAY show you which starting bracket "{" has no matching ending bracket "}".
Second way is to select the starting bracket using mouse and scroll down for matching ending bracket.
Tru that on working pair first to see how it works.
Jim
'

4

LarryD:
This goes at the top of your sketch, you have it in loop():
#include "Arduino.h"

Always use code tags when showing your sketch to us.
use the </> icon in the posting menu.

.

Thanks!!!!!! That was it.