Expected '(' before 'digitalRead'

[iwanttolearnarduino]

Hello, so basically im completely new to arduino and programming overall. I tried to make simple traffic light using arduino. I ran in to issue with function 'if' and 'digitalwrite'. The code is not complete yet this is all i have. Thanks in advance

int button = 0;

void setup() {
pinMode(2, OUTPUT);
pinMode(3, OUTPUT);
pinMode(4, OUTPUT);
pinMode(5, INPUT);
}

void loop() {
 if digitalRead (5, HIGH); {
 int button = random(10, 5000);
 }
  delay(button);
 digitalWrite(4, HIGH);
  delay(50);
 digitalWrite(4, LOW);
 digitalWrite(3, HIGH);
  delay(50);
 digitalWrite(3, LOW);
 digitalWrite(4, HIGH);
  delay(1000);
}

[DaveX]

This has two problems:

@iwanttolearnarduino

 if digitalRead (5, HIGH); {

if - Arduino Reference

You need parentheses around the if clause, and you need to eliminate the null statement following the if by eliminating the semicolon:

 if (digitalRead (5, HIGH)) {

[horace]

if requires () around the test expression

 if (digitalRead (5, HIGH)) {
    button = random(10, 5000);
 }

also removed the ; which would terminate the if
also you redefine button inside the {} which will create a local variable

[DaveX]

@horace

also you redefine button inside the {} which will create a local variable

Oops -- three problems.

[ToddL1962]

@iwanttolearnarduino

 if digitalRead (5, HIGH); {
 int button = random(10, 5000);
 }

Try:

 if (digitalRead (5) == HIGH)
 {
    button = random(10, 5000);
 }