Hey, I have been having some trouble with this code, the goal is to have 4 buttons that each play a Christmas song and flash some lights with it. I have found some merry Christmas code, but I had to modify it, but it is giving me an error. Here is my code with the error below.
void setup() {
pinMode(2, OUTPUT); pinMode(3, OUTPUT);
pinMode(8, OUTPUT); pinMode(9, OUTPUT);
pinMode(10, OUTPUT); pinMode(11, OUTPUT);
pinMode(12, OUTPUT); pinMode(13, OUTPUT);
pinMode(4, INPUT_PULLUP);//black button
pinMode(5, INPUT_PULLUP);//green button
pinMode(6, INPUT_PULLUP);//yellow button
pinMode(7, INPUT_PULLUP);//blue button
pinMode(8, INPUT_PULLUP);//time button A.K.A red
pinMode(3, OUTPUT); //buzzer
}
#define NOTE_B0 31
#define NOTE_C1 33
#define NOTE_CS1 35
#define NOTE_D1 37
#define NOTE_DS1 39
#define NOTE_E1 41
#define NOTE_F1 44
#define NOTE_FS1 46
#define NOTE_G1 49
#define NOTE_GS1 52
#define NOTE_A1 55
#define NOTE_AS1 58
#define NOTE_B1 62
#define NOTE_C2 65
#define NOTE_CS2 69
#define NOTE_D2 73
#define NOTE_DS2 78
#define NOTE_E2 82
#define NOTE_F2 87
#define NOTE_FS2 93
#define NOTE_G2 98
#define NOTE_GS2 104
#define NOTE_A2 110
#define NOTE_AS2 117
#define NOTE_B2 123
#define NOTE_C3 131
#define NOTE_CS3 139
#define NOTE_D3 147
#define NOTE_DS3 156
#define NOTE_E3 165
#define NOTE_F3 175
#define NOTE_FS3 185
#define NOTE_G3 196
#define NOTE_GS3 208
#define NOTE_A3 220
#define NOTE_AS3 233
#define NOTE_B3 247
#define NOTE_C4 262
#define NOTE_CS4 277
#define NOTE_D4 294
#define NOTE_DS4 311
#define NOTE_E4 330
#define NOTE_F4 349
#define NOTE_FS4 370
#define NOTE_G4 392
#define NOTE_GS4 415
#define NOTE_A4 440
#define NOTE_AS4 466
#define NOTE_B4 494
#define NOTE_C5 523
#define NOTE_CS5 554
#define NOTE_D5 587
#define NOTE_DS5 622
#define NOTE_E5 659
#define NOTE_F5 698
#define NOTE_FS5 740
#define NOTE_G5 784
#define NOTE_GS5 831
#define NOTE_A5 880
#define NOTE_AS5 932
#define NOTE_B5 988
#define NOTE_C6 1047
#define NOTE_CS6 1109
#define NOTE_D6 1175
#define NOTE_DS6 1245
#define NOTE_E6 1319
#define NOTE_F6 1397
#define NOTE_FS6 1480
#define NOTE_G6 1568
#define NOTE_GS6 1661
#define NOTE_A6 1760
#define NOTE_AS6 1865
#define NOTE_B6 1976
#define NOTE_C7 2093
#define NOTE_CS7 2217
#define NOTE_D7 2349
#define NOTE_DS7 2489
#define NOTE_E7 2637
#define NOTE_F7 2794
#define NOTE_FS7 2960
#define NOTE_G7 3136
#define NOTE_GS7 3322
#define NOTE_A7 3520
#define NOTE_AS7 3729
#define NOTE_B7 3951
#define NOTE_C8 4186
#define NOTE_CS8 4435
#define NOTE_D8 4699
#define NOTE_DS8 4978
#define REST 0
int c = 130.81; int d = 146.83; int e = 164.81; int f = 174.61; int g = 196; int a = 220; int b = 246.94;
int button_state;
int button = 5;
int yellowbutton = 6;
int blackbutton = 4;
int greenbutton = 5;
int bluebutton = 7;
int buttonstate2;
int buttonstate3;
int buttonstate4;
int buttonstate;
int durationlength = 500;
int button_state1;
// merry christmas
int mcnotes [195] = {NOTE_C5,
NOTE_F5, NOTE_F5, NOTE_G5, NOTE_F5, NOTE_E5, NOTE_D5, NOTE_D5, NOTE_D5,
NOTE_G5, NOTE_G5, NOTE_A5, NOTE_G5, NOTE_F5, NOTE_E5, NOTE_C5, NOTE_C5,
NOTE_A5, NOTE_A5, NOTE_AS5, NOTE_A5, NOTE_G5, NOTE_F5, NOTE_D5, NOTE_C5, NOTE_C5,
NOTE_D5, NOTE_G5, NOTE_E5, NOTE_F5, NOTE_C5, NOTE_F5, NOTE_F5, NOTE_G5, NOTE_F5, NOTE_E5,
NOTE_D5, NOTE_D5, NOTE_D5, NOTE_G5, NOTE_G5, NOTE_A5, NOTE_G5, NOTE_F5,
NOTE_E5, NOTE_C5, NOTE_C5, NOTE_A5, NOTE_A5, NOTE_AS5, NOTE_A5, NOTE_G5,
NOTE_F5, NOTE_D5, NOTE_C5, NOTE_C5, NOTE_D5, NOTE_G5, NOTE_E5,
NOTE_F5, NOTE_C5, NOTE_F5, NOTE_F5, NOTE_F5, NOTE_E5, NOTE_E5,
NOTE_F5, NOTE_E5, NOTE_D5, NOTE_C5, NOTE_A5, NOTE_AS5, NOTE_A5, NOTE_G5,
NOTE_C6, NOTE_C5, NOTE_C5, NOTE_C5, NOTE_D5, NOTE_G5, NOTE_E5, NOTE_F5, NOTE_C5,
NOTE_F5, NOTE_F5, NOTE_G5, NOTE_F5, NOTE_E5, NOTE_D5, NOTE_D5, NOTE_D5, NOTE_G5, NOTE_G5,
NOTE_A5, NOTE_G5, NOTE_F5, NOTE_E5, NOTE_C5, NOTE_C5, NOTE_A5, NOTE_A5, NOTE_AS5, NOTE_A5,
NOTE_G5, NOTE_F5, NOTE_D5, NOTE_C5, NOTE_C5, NOTE_D5, NOTE_G5, NOTE_E5,
NOTE_F5, NOTE_C5, NOTE_F5, NOTE_F5, NOTE_F5, NOTE_E5, NOTE_E5, NOTE_F5, NOTE_E5, NOTE_D5,
NOTE_C5, NOTE_A5, NOTE_AS5, NOTE_A5, NOTE_G5,
NOTE_C6, NOTE_C5, NOTE_C5, NOTE_C5, NOTE_D5, NOTE_G5, NOTE_E5
NOTE_F5, NOTE_C5, NOTE_F5, NOTE_F5, NOTE_G5, NOTE_F5, NOTE_E5,
NOTE_D5, NOTE_D5, NOTE_D5, NOTE_G5, NOTE_G5, NOTE_A5, NOTE_G5, NOTE_F5,
NOTE_E5, NOTE_C5, NOTE_C5, NOTE_A5, NOTE_A5, NOTE_AS5, NOTE_A5, NOTE_G5, NOTE_F5, NOTE_D5,
NOTE_C5, NOTE_C5,
NOTE_D5, NOTE_G5, NOTE_E5, NOTE_F5, NOTE_C5, NOTE_F5, NOTE_F5, NOTE_G5, NOTE_F5, NOTE_E5,
NOTE_D5, NOTE_D5, NOTE_D5, NOTE_G5, NOTE_G5, NOTE_A5, NOTE_G5, NOTE_F5,
NOTE_E5, NOTE_C5, NOTE_C5, NOTE_A5, NOTE_A5, NOTE_AS5, NOTE_A5, NOTE_G5,
NOTE_F5, NOTE_D5, NOTE_C5, NOTE_C5, NOTE_D5, NOTE_G5, NOTE_E5, NOTE_F5, REST,
};
int mcdurations[195] = {4,
4, 8, 8, 8, 8, 4, 4, 4,
4, 8, 8, 8, 8, 4, 4, 4,
4, 8, 8, 8, 8, 4, 4, 8, 8,
4, 4, 4, 2, 4, 4, 8, 8, 8, 8,
4, 4, 4, 4, 8, 8, 8, 8,
4, 4, 4, 4, 8, 8, 8, 8,
4, 4, 8, 8, 4, 4, 4,
2, 4, 4, 4, 4, 2, 4,
4, 4, 4, 2, 4, 4, 4, 4,
4, 4, 8, 8, 4, 4, 4, 2, 4,
4, 8, 8, 8, 8, 4, 4, 4, 4, 8,
8, 8, 8, 4, 4, 4, 4, 8, 8, 8,
8, 4, 4, 8, 8, 4, 4, 4,
2, 4, 4, 4, 4, 2, 4, 4, 4, 4,
2, 4, 4, 4, 4,
4, 4, 8, 8, 4, 4, 4,
2, 4, 4, 8, 8, 8, 8,
4, 4, 4, 4, 8, 8, 8, 8,
4, 4, 4, 4, 8, 8, 8, 8, 4, 4,
8, 8,
4, 4, 4, 2, 4, 4, 8, 8, 8, 8,
4, 4, 4, 4, 8, 8, 8, 8,
4, 4, 4, 4, 8, 8, 8, 8,
4, 4, 8, 8, 4, 4, 4, 2, 4
};
//silent night
float jtw[30] = {b, f, f, g, f, e, d, d, d, g, g, a, g, f, e, e, e, a, a, b, a, g, f, d, b, b, d, g, e, f };
int jtwdurations[30] = {400, 400, 800, 800, 800, 800, 400, 400, 400, 400, 800, 800, 800, 800, 400, 400, 400, 400, 800, 800, 800, 800, 400, 400,
800, 800, 400, 400, 400, 200
};
int jtw2[27] = {8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8};
int jtw3[27] = {9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9};
int jtwnote[27] = {10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10};
int jtw1[27] = {11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11};
int jtw4[27] = {12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12};
int jtw5[27] = {13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13};
//jingle bells
float jbnote[25] = {e, e, e, e, e, e, e, g, c, d, e, f, f, f, f, f, e, e, e, e, d, d, e, d, g};
int jbduration[25] = {400, 400, 800, 400, 400, 800, 400, 400, 400, 400, 1600, 400, 400, 400, 400, 400, 400, 400, 400, 400, 400, 400, 400, 1200,
1600
};
int jb3[25] = {9, 9, 9, 0, 0, 0, 0, 0, 0, 0, 9, 0, 9, 0, 0, 9, 0, 0, 9, 0, 9, 0, 0, 9, 0};
int jb[25] = {0, 10, 10, 10, 0, 0, 0, 0, 10, 10, 10, 0, 10, 0, 10, 0, 10, 0, 10, 0, 0, 10, 0, 10, 0};
int jb1[25] = {0, 0, 11, 11, 11, 0, 11, 11, 11, 11, 11, 0, 11, 0, 0, 11, 11, 11, 11, 0, 0, 0, 11, 11, 0};
int jb4[25] = {0, 12, 12, 12, 0, 0, 0, 12, 12, 12, 12, 0, 12, 0, 12, 0, 12, 0, 12, 0, 0, 12, 0, 12, 0};
int jb5[25] = {13, 13, 13, 0, 0, 0, 0, 0, 0, 13, 13, 0, 13, 0, 0, 13, 0, 0, 13, 0, 13, 0, 0, 13, 0};
void loop() {
buttonstate = digitalRead(8);
if (buttonstate == LOW) {
for (int n = 0; n == 1; n = n + 1) {
durationlength = durationlength + 500;
}
}
button_state = digitalRead(bluebutton);
if (button_state == LOW) {
for (int n = 0; n < 25; n = n + 1) {
digitalWrite(jb[n], HIGH); digitalWrite(jb1[n], HIGH); digitalWrite(jb3[n], HIGH); digitalWrite(jb4[n], HIGH); digitalWrite(jb5[n], HIGH);
tone (3, jbnote[n] * 2, jbduration[n]);
delay(jbduration[n]);
delay(50);
digitalWrite(jb[n], LOW); digitalWrite(jb1[n], LOW); digitalWrite(jb3[n], LOW); digitalWrite(jb4[n], LOW); digitalWrite(jb5[n], LOW);
durationlength = 500;
}
}
buttonstate2 = digitalRead(blackbutton);
int n;
if (buttonstate2 == LOW) {
button_state = digitalRead(7);
if (button_state1 == LOW) {
for (int x = 0; x < 195; x = x + 1) {
tone (3, mcnote[x] * 2, mcduration[x]);
delay(jtwdurations[x]);
delay(50);
}
}
}
buttonstate3 = digitalRead(yellowbutton);
if (buttonstate3 == LOW) {
for(int y = 0; y < 195; y = y + 1) {
digitalWrite(jtwnote[y], HIGH); digitalWrite(jtw1[y], HIGH); digitalWrite(jtw3[y], HIGH);
digitalWrite(jtw4[y], HIGH); digitalWrite(jtw5[y], HIGH);
tone (3, jtw[y] * 2, jtwdurations[y]);
delay(jtwdurations[y]);
delay(50);
digitalWrite(jtwnote[y], LOW); digitalWrite(jtw1[y], LOW); digitalWrite(jtw3[y], LOW);
digitalWrite(jtw4[y], LOW); digitalWrite(jtw5[y], LOW);
}
buttonstate4 = digitalRead(greenbutton);
if (buttonstate4 == LOW) {
tone(3, 500, durationlength);
delay(durationlength);
durationlength = 500;
}
}
error
Arduino: 1.8.18 (Mac OS X), Board: "Arduino Uno"
music_code:67:18: error: expected '}' before numeric constant
#define NOTE_F5 698
^
/Users/jennyjohartney/Downloads/settings_and_integers/music_code.ino:135:23: note: in expansion of macro 'NOTE_F5'
NOTE_F5, NOTE_C5, NOTE_F5, NOTE_F5, NOTE_G5, NOTE_F5, NOTE_E5,
^~~~~~~
music_code:67:18: error: expected ',' or ';' before numeric constant
#define NOTE_F5 698
^
/Users/jennyjohartney/Downloads/settings_and_integers/music_code.ino:135:23: note: in expansion of macro 'NOTE_F5'
NOTE_F5, NOTE_C5, NOTE_F5, NOTE_F5, NOTE_G5, NOTE_F5, NOTE_E5,
^~~~~~~
music_code:143:22: error: expected declaration before '}' token
};
^
exit status 1
expected '}' before numeric constant
This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.