Function definition does not declare parameters

Projects Programming
1

Hi, im pretty new with the C++ language. I already searched what this error can mean but this is pretty common so maybe you guys see whats wrong in my program

/*
  Pick & Place Systeem 
 Groep 2
 David Robbrecht, Anthony Dayer, Ward Van Grimbergen, Thomas Carlier
 //____________________________________ 
 //------------------------------------
 Het Systeem:
 
 We beschikken over 4 motoren:
 -Stappenmotor (X-richting)
 -DC_motor (Y-richting)
 -DC_motor knex (Z-richting)
 -DC_motor lego (Grijpbeweging)
 
 De vakken hebben elk een naam als volgt:
 A1 A2 A3
 B1 B2 B3
 C1 C2 C3
 D1 D2 D3 
 Alle letters & cijfers hebben hun eigen LED, zo worden er telkens per bestemming 2 LED's gestuurd en gezocht door de sensoren.
 De grijper komt steeds terug naar eenzelfde beginpositie (A1)
 
 Analog in A0: Lichtsensor X-as
 Analog in A1: Lichtsensor Y-as
 PIN 1: LED_A
 PIN 2: LED_B
 PIN 3: LED_C
 PIN 4: LED_D
 PIN 5: LED_1
 PIN 6: LED_2 
 PIN 7: LED_3 
 PIN 8: Stepper_1 (x-richting)
 PIN 9: Stepper_2 (x-richting)
 PIN 10: DC_links (y-richting)
 PIN 11: DC_rechts (y-richting)
 PIN 12: DC_up (z-richting)
 PIN 13: DC_down (z-richting)
 PIN 14: DC_dicht (grijpbeweging)
 PIN 15: DC_open (grijpbeweging) 
 
SHOOT
*/
//____________________________________
//------------------------------------
// Led's:

int sensorX = A0;
int sensorY = A1;
int LED_A = 1;
int LED_B = 2;
int LED_C = 3;
int LED_D = 4;
int LED_1 = 5;
int LED_2 = 6;
int LED_3 = 7;
int DC_links = 10;
int DC_rechts = 11;
int DC_up = 12;
int DC_down = 13;
int DC_dicht = 14;
int DC_open = 15;
char pick = 'A1';
char place = 'A1';
//____________________________________
// Stepper:

#include <Stepper.h>

#define motorSteps 200     // change this depending on the number of steps
// per revolution of your motor
#define motorPin1 8
#define motorPin2 9
Stepper myStepper(motorSteps, motorPin1,motorPin2); 
//____________________________________
//------------------------------------
void setup{}
{
  // led's:

  pinMode{LED_A, OUTPUT};
  pinMode{LED_B, OUTPUT};
  pinMode{LED_C, OUTPUT};
  pinMode{LED_D, OUTPUT};
  pinMode{LED_1, OUTPUT};
  pinMode{LED_2, OUTPUT};
  pinMode{LED_3, OUTPUT};

  //____________________________________
  // DC's

  pinMode{DC_links, OUTPUT};
  pinMode{DC_rechts, OUTPUT};
  pinMode{DC_up, OUTPUT};
  pinMode{DC_down, OUTPUT};
  pinMode{DC_dicht, OUTPUT};
  pinMode{DC_open, OUTPUT};  
  //___________________________________
  // stepper:
  // set the motor speed at 60 RPMS:
  myStepper.setSpeed(60);

  // Initialize the Serial port:
  Serial.begin(9600);


}
//__________________________________________________________________
//HET PROGRAMMA
//------------------------------------------------------------------
void loop() {
  
  if (pick = 'A1') // reeds beginpositie!!!!!!!
   {   
   digitalWrite(LED_A, HIGH);
   digitalWrite(LED_1, HIGH);
   
   digitalWrite{DC_down, HIGH};
   delay{1000};
   digitalWrite{DC_down, LOW};
   digitalWrite{DC_dicht, HIGH};
   digitalWrite{DC_up; HIGH};
   delay{1000}
   digitalWrite{DC_up; LOW};
   
   
   }
   
   if (pick = 'A2')
   {
   digitalWrite(LED_A, HIGH);
   digitalWrite(LED_2, HIGH);
   
   }
   
   if (pick = 'A3')
   {
   digitalWrite(LED_A, HIGH);
   digitalWrite(LED_3, HIGH);  
   }
   
   if (pick = 'B1')
   {
   digitalWrite(LED_B, HIGH);
   digitalWrite(LED_1, HIGH);  
   }
   
   if (pick = 'B2')
   {
   digitalWrite(LED_B, HIGH);
   digitalWrite(LED_2, HIGH);  
   }
   
   if (pick = 'B3')
   {
   digitalWrite(LED_B, HIGH);
   digitalWrite(LED_3, HIGH);  
   }
   
   if (pick = 'C1')
   {
   digitalWrite(LED_C, HIGH);
   digitalWrite(LED_1, HIGH);  
   }
   
   if (pick = 'C2')
   {
   digitalWrite(LED_C, HIGH);
   digitalWrite(LED_2, HIGH);  
   }
   
   if (pick = 'C3')
   {
   digitalWrite(LED_C, HIGH);
   digitalWrite(LED_3, HIGH);  
   }
   
   if (pick = 'D1')
   {
   digitalWrite(LED_D, HIGH);
   digitalWrite(LED_1, HIGH);  
   }
   if (pick = 'D2')
   {
   digitalWrite(LED_D, HIGH);
   digitalWrite(LED_2, HIGH);  
   }
   
   if (pick = 'D3')
   {
   digitalWrite(LED_D, HIGH);
   digitalWrite(LED_3, HIGH);  
   }
   
   if (place = 'A1')
   {
   digitalWrite(LED_A, HIGH);
   digitalWrite(LED_1, HIGH);  
   }
   
   if (place = 'A2')
   {
   digitalWrite(LED_A, HIGH);
   digitalWrite(LED_2, HIGH);  
   }
   
   if (place = 'A3')
   {
   digitalWrite(LED_A, HIGH);
   digitalWrite(LED_3, HIGH);  
   }
   
   if (place = 'B1')
   {
   digitalWrite(LED_B, HIGH);
   digitalWrite(LED_1, HIGH);  
   }
   
   if (place = 'B2')
   {
   digitalWrite(LED_B, HIGH);
   digitalWrite(LED_2, HIGH);  
   }
   
   if (place = 'B3')
   {
   digitalWrite(LED_B, HIGH);
   digitalWrite(LED_3, HIGH);  
   }
   
   if (place = 'C1')
   {
   digitalWrite(LED_C, HIGH);
   digitalWrite(LED_1, HIGH);  
   }
   
   if (place = 'C2')
   {
   digitalWrite(LED_C, HIGH);
   digitalWrite(LED_2, HIGH);  
   }
   
   if (place = 'C3')
   {
   digitalWrite(LED_C, HIGH);
   digitalWrite(LED_3, HIGH);  
   }
   
   if (place = 'D1')
   {
   digitalWrite(LED_D, HIGH);
   digitalWrite(LED_1, HIGH);  
   }
   if (place = 'D2')
   {
   digitalWrite(LED_D, HIGH);
   digitalWrite(LED_2, HIGH);  
   }
   
   if (place = 'D3')
   {
   digitalWrite(LED_D, HIGH);
   digitalWrite(LED_3, HIGH);  
   }
   
}
//  _____________________________________
    //
  // Step forward 100 steps:
  Serial.println("Forward");
  myStepper.step(100);
  delay(500);

  // Step backward 100 steps:
  Serial.println("Backward");
  myStepper.step(-100);
  delay(500); 
}
2 
void setup() // Use () Parentheses, not {} braces
{
  // led's:

  pinMode(LED_A, OUTPUT);// Use () Parentheses, not {} braces
.
.
.

Regards,

Dave

3

There are a lots of errors in my opinion.

If you want to work with 'string' (arrays of char), you can not use declaration like :

char pick = 'A1';
char place = 'A1';

It makes nonsens. the right declaration should be :

char pick[]="A1";
char place[]="A1";

the second thing is every time you're doing a comparison :

if (pick = 'A1') // reeds beginpositie!!!!!!!
{
digitalWrite(LED...
}

This is NOT a comparison, this is an assignment and it will always return true ! In that case every compiler would execute :

Assign 'A' to the char pick.
As 'A' is not equal to 0x00, the if (pick='A1') will be always true !

there many ways to code it, like :

if (strstr(pick, "A1))
{
}

(strstr is in the string.h library and will compare 2 strings. If the second string is a part of the first one, then the function will return a pointer of the occurence of the second string into the one and therefor will be not null.)

or

if (pick[0]=='A' && pick[1]=='1')
{
}

in that case we compare byte by byte the string. One of the advantage is : if the first comparison is not valid, the second one will be not evaluated.

Be carreful, to compare a variable to a another you MUST use '==' instead of '='.

Best Regards

and so on.

You can also use : switch... case to realize all of your comparison.

Like :

switch(pick[0])
{
case 'A':
  {
    switch(pick[1])
    {
    case '1': 
      {
        /*stuff for 'A1'*/
      } 
      break;
    case '2': 
      {
        /*stuff for 'A2'*/
      } 
      break;
    case '3': 
      {
        /*stuff for 'A3'*/
      } 
      break;

    }
  } 
  break;
case 'B':
  {
    ...
  } 
  break;
case 'C':
  {
    ...
  } 
  break;
}
4

Wow, thank you very very much! i'm not very familiar with the case structure but i'll try the
if (strstr(place, "D1")
{
digitalWrite(LED_D, HIGH);
digitalWrite(LED_1, HIGH);
}

All help is welcome!

Thanks
David