Help Find Error "}"

rockettownstem · May 6, 2025, 10:09pm

I am writing a code for a countdown timer for our church VBS. 13 relays for 12 lights and the extra for a buzzer. there is the "low" code that just runs lights down three times, then flashes all lights three times, then repeats. If A0 is switched HIGH, then just the top light (13) is on. When A0 is HIGH, and A1 is pressed, then the countdown runs for 60 seconds. I keep getting an error, but I cannot find the issue. I will attach the code. Thank you for your help.

void setup() {
  // put your setup code here, to run once:
pinMode (A0, INPUT); //analog input to toggle switch -ready mode-resistor to ground on return side
pinMode (A1, INPUT); //analog input to push button for start- resistor to ground on return side
pinMode (A5, OUTPUT); //analog buzzer at end of countdown
pinMode (13, OUTPUT); //to relay = Get Ready - 
pinMode (12, OUTPUT); // to relay countdown light 10
pinMode (11, OUTPUT); // to relay countdown light 9
pinMode (10, OUTPUT); // to relay countdown light 8
pinMode (9, OUTPUT); // to relay countdown light 7
pinMode (8, OUTPUT); // to relay countdown light 6
pinMode (7, OUTPUT); // to relay countdown light 5
pinMode (6, OUTPUT); // to relay countdown light 4
pinMode (5, OUTPUT); // to relay countdown light 3
pinMode (4, OUTPUT); // to relay countdown light 2
pinMode (3, OUTPUT); // to relay countdown light 1
pinMode (2, OUTPUT); // to relay countdown TIMES UP plus buzzer
}

void loop() {
  // put your main code here, to run repeatedly:

if (digitalRead (A0) == HIGH){
digitalWrite(13, HIGH); // toggle switch on countdown mode (high) to relay 13 - is on until push button activates timer.


if (digitalRead (A1) == HIGH){
digitalWrite(13, LOW); //push button activates countdown timer, turning off 13 and working down timer to relays at 6 seconds each for 60 second game time.
digitalWrite(12, HIGH);
delay (6000);
digitalWrite(12, LOW);
digitalWrite(11, HIGH);
delay (6000);
digitalWrite(11, LOW);
digitalWrite(10, HIGH);
delay (6000);
digitalWrite(10, LOW);
digitalWrite(9, HIGH);
delay (6000);
digitalWrite(9, LOW);
digitalWrite(8, HIGH);
delay (6000);
digitalWrite(8, LOW);
digitalWrite(7, HIGH);
delay (6000);
digitalWrite(7, LOW);
digitalWrite(6, HIGH);
delay (6000);
digitalWrite(6, LOW);
digitalWrite(5, HIGH);
delay (6000);
digitalWrite(5, LOW);
digitalWrite(4, HIGH);
delay (6000);
digitalWrite(4, LOW);
digitalWrite(3, HIGH);
delay (6000);
digitalWrite(3, LOW);
digitalWrite(2, HIGH); //hold for 4 seconds, playing buzzer and light for TIMES UP, then reset to 13
digitalWrite(A5, LOW);
delay (4000);
digitalWrite(2, LOW); //times up
digitalWrite(A5, LOW);
}

if (digitalRead (A0) == LOW){
digitalWrite(13, HIGH); //
digitalWrite(10, HIGH);
digitalWrite(7, HIGH);
digitalWrite(4, HIGH);
delay (125);
digitalWrite(13, LOW); //relay to light 13 off
digitalWrite(10, LOW);
digitalWrite(7, LOW);
digitalWrite(4, LOW);
digitalWrite(12, HIGH);
digitalWrite(9, HIGH);//relay to light  12 on
digitalWrite(6, HIGH);
digitalWrite(3, HIGH);
delay (125); //  quarter second delay
digitalWrite(12, LOW);// relay to light  12 off
digitalWrite(9, LOW);
digitalWrite(6, LOW);
digitalWrite(3, LOW);
digitalWrite(11, HIGH);
digitalWrite(8, HIGH);
digitalWrite(5, HIGH);
digitalWrite(2, HIGH);
delay (120);
digitalWrite(11, LOW);
digitalWrite(8, LOW);
digitalWrite(5, LOW);
digitalWrite(2, LOW);
digitalWrite(13, HIGH); //
digitalWrite(10, HIGH);
digitalWrite(7, HIGH);
digitalWrite(4, HIGH);
delay (125);
digitalWrite(13, LOW); //relay to light 13 off
digitalWrite(10, LOW);
digitalWrite(7, LOW);
digitalWrite(4, LOW);
digitalWrite(12, HIGH);
digitalWrite(9, HIGH);//relay to light  12 on
digitalWrite(6, HIGH);
digitalWrite(3, HIGH);
delay (125); //  quarter second delay
digitalWrite(12, LOW);// relay to light  12 off
digitalWrite(9, LOW);
digitalWrite(6, LOW);
digitalWrite(3, LOW);
digitalWrite(11, HIGH);
digitalWrite(8, HIGH);
digitalWrite(5, HIGH);
digitalWrite(2, HIGH);
delay (120);
digitalWrite(11, LOW);
digitalWrite(8, LOW);
digitalWrite(5, LOW);
digitalWrite(2, LOW);
digitalWrite(13, HIGH); //
digitalWrite(10, HIGH);
digitalWrite(7, HIGH);
digitalWrite(4, HIGH);
delay (125);
digitalWrite(13, LOW); //relay to light 13 off
digitalWrite(10, LOW);
digitalWrite(7, LOW);
digitalWrite(4, LOW);
digitalWrite(12, HIGH);
digitalWrite(9, HIGH);//relay to light  12 on
digitalWrite(6, HIGH);
digitalWrite(3, HIGH);
delay (125); //  quarter second delay
digitalWrite(12, LOW);// relay to light  12 off
digitalWrite(9, LOW);
digitalWrite(6, LOW);
digitalWrite(3, LOW);
digitalWrite(11, HIGH);
digitalWrite(8, HIGH);
digitalWrite(5, HIGH);
digitalWrite(2, HIGH);
delay (120);
digitalWrite(11, LOW);
digitalWrite(8, LOW);
digitalWrite(5, LOW);
digitalWrite(2, LOW);
digitalWrite(13, HIGH);   // all flashing
digitalWrite(12, HIGH);
digitalWrite(11, HIGH);
digitalWrite(10, HIGH);
digitalWrite(9, HIGH);
digitalWrite(8, HIGH);
digitalWrite(7, HIGH);
digitalWrite(6, HIGH);
digitalWrite(5, HIGH);
digitalWrite(4, HIGH);
digitalWrite(3, HIGH);
digitalWrite(2, HIGH);
delay (120);
digitalWrite(13, LOW);
digitalWrite(12, LOW);
digitalWrite(11, LOW);
digitalWrite(10, LOW);
digitalWrite(9, LOW);
digitalWrite(8, LOW);
digitalWrite(7, LOW);
digitalWrite(6, LOW);
digitalWrite(5, LOW);
digitalWrite(4, LOW);
digitalWrite(3, LOW);
digitalWrite(2, LOW);
delay (120);
digitalWrite(13, HIGH);
digitalWrite(12, HIGH);
digitalWrite(11, HIGH);
digitalWrite(10, HIGH);
digitalWrite(9, HIGH);
digitalWrite(8, HIGH);
digitalWrite(7, HIGH);
digitalWrite(6, HIGH);
digitalWrite(5, HIGH);
digitalWrite(4, HIGH);
digitalWrite(3, HIGH);
digitalWrite(2, HIGH);
delay (120);
digitalWrite(13, LOW);
digitalWrite(12, LOW);
digitalWrite(11, LOW);
digitalWrite(10, LOW);
digitalWrite(9, LOW);
digitalWrite(8, LOW);
digitalWrite(7, LOW);
digitalWrite(6, LOW);
digitalWrite(5, LOW);
digitalWrite(4, LOW);
digitalWrite(3, LOW);
digitalWrite(2, LOW);
delay (120);
digitalWrite(13, HIGH);
digitalWrite(12, HIGH);
digitalWrite(11, HIGH);
digitalWrite(10, HIGH);
digitalWrite(9, HIGH);
digitalWrite(8, HIGH);
digitalWrite(7, HIGH);
digitalWrite(6, HIGH);
digitalWrite(5, HIGH);
digitalWrite(4, HIGH);
digitalWrite(3, HIGH);
digitalWrite(2, HIGH);
delay (120);
digitalWrite(13, LOW);
digitalWrite(12, LOW);
digitalWrite(11, LOW);
digitalWrite(10, LOW);
digitalWrite(9, LOW);
digitalWrite(8, LOW);
digitalWrite(7, LOW);
digitalWrite(6, LOW);
digitalWrite(5, LOW);
digitalWrite(4, LOW);
digitalWrite(3, LOW);
digitalWrite(2, LOW);
delay (120);


}
type or paste code here

sonofcy · May 6, 2025, 10:20pm

Add two } at the end.

sonofcy · May 6, 2025, 10:21pm

Here is the formatted correct version

void setup() {
  // put your setup code here, to run once:
  pinMode(A0, INPUT);   //analog input to toggle switch -ready mode-resistor to ground on return side
  pinMode(A1, INPUT);   //analog input to push button for start- resistor to ground on return side
  pinMode(A5, OUTPUT);  //analog buzzer at end of countdown
  pinMode(13, OUTPUT);  //to relay = Get Ready -
  pinMode(12, OUTPUT);  // to relay countdown light 10
  pinMode(11, OUTPUT);  // to relay countdown light 9
  pinMode(10, OUTPUT);  // to relay countdown light 8
  pinMode(9, OUTPUT);   // to relay countdown light 7
  pinMode(8, OUTPUT);   // to relay countdown light 6
  pinMode(7, OUTPUT);   // to relay countdown light 5
  pinMode(6, OUTPUT);   // to relay countdown light 4
  pinMode(5, OUTPUT);   // to relay countdown light 3
  pinMode(4, OUTPUT);   // to relay countdown light 2
  pinMode(3, OUTPUT);   // to relay countdown light 1
  pinMode(2, OUTPUT);   // to relay countdown TIMES UP plus buzzer
}

void loop() {
  // put your main code here, to run repeatedly:

  if (digitalRead(A0) == HIGH) {
    digitalWrite(13, HIGH);  // toggle switch on countdown mode (high) to relay 13 - is on until push button activates timer.


    if (digitalRead(A1) == HIGH) {
      digitalWrite(13, LOW);  //push button activates countdown timer, turning off 13 and working down timer to relays at 6 seconds each for 60 second game time.
      digitalWrite(12, HIGH);
      delay(6000);
      digitalWrite(12, LOW);
      digitalWrite(11, HIGH);
      delay(6000);
      digitalWrite(11, LOW);
      digitalWrite(10, HIGH);
      delay(6000);
      digitalWrite(10, LOW);
      digitalWrite(9, HIGH);
      delay(6000);
      digitalWrite(9, LOW);
      digitalWrite(8, HIGH);
      delay(6000);
      digitalWrite(8, LOW);
      digitalWrite(7, HIGH);
      delay(6000);
      digitalWrite(7, LOW);
      digitalWrite(6, HIGH);
      delay(6000);
      digitalWrite(6, LOW);
      digitalWrite(5, HIGH);
      delay(6000);
      digitalWrite(5, LOW);
      digitalWrite(4, HIGH);
      delay(6000);
      digitalWrite(4, LOW);
      digitalWrite(3, HIGH);
      delay(6000);
      digitalWrite(3, LOW);
      digitalWrite(2, HIGH);  //hold for 4 seconds, playing buzzer and light for TIMES UP, then reset to 13
      digitalWrite(A5, LOW);
      delay(4000);
      digitalWrite(2, LOW);  //times up
      digitalWrite(A5, LOW);
    }

    if (digitalRead(A0) == LOW) {
      digitalWrite(13, HIGH);  //
      digitalWrite(10, HIGH);
      digitalWrite(7, HIGH);
      digitalWrite(4, HIGH);
      delay(125);
      digitalWrite(13, LOW);  //relay to light 13 off
      digitalWrite(10, LOW);
      digitalWrite(7, LOW);
      digitalWrite(4, LOW);
      digitalWrite(12, HIGH);
      digitalWrite(9, HIGH);  //relay to light  12 on
      digitalWrite(6, HIGH);
      digitalWrite(3, HIGH);
      delay(125);             //  quarter second delay
      digitalWrite(12, LOW);  // relay to light  12 off
      digitalWrite(9, LOW);
      digitalWrite(6, LOW);
      digitalWrite(3, LOW);
      digitalWrite(11, HIGH);
      digitalWrite(8, HIGH);
      digitalWrite(5, HIGH);
      digitalWrite(2, HIGH);
      delay(120);
      digitalWrite(11, LOW);
      digitalWrite(8, LOW);
      digitalWrite(5, LOW);
      digitalWrite(2, LOW);
      digitalWrite(13, HIGH);  //
      digitalWrite(10, HIGH);
      digitalWrite(7, HIGH);
      digitalWrite(4, HIGH);
      delay(125);
      digitalWrite(13, LOW);  //relay to light 13 off
      digitalWrite(10, LOW);
      digitalWrite(7, LOW);
      digitalWrite(4, LOW);
      digitalWrite(12, HIGH);
      digitalWrite(9, HIGH);  //relay to light  12 on
      digitalWrite(6, HIGH);
      digitalWrite(3, HIGH);
      delay(125);             //  quarter second delay
      digitalWrite(12, LOW);  // relay to light  12 off
      digitalWrite(9, LOW);
      digitalWrite(6, LOW);
      digitalWrite(3, LOW);
      digitalWrite(11, HIGH);
      digitalWrite(8, HIGH);
      digitalWrite(5, HIGH);
      digitalWrite(2, HIGH);
      delay(120);
      digitalWrite(11, LOW);
      digitalWrite(8, LOW);
      digitalWrite(5, LOW);
      digitalWrite(2, LOW);
      digitalWrite(13, HIGH);  //
      digitalWrite(10, HIGH);
      digitalWrite(7, HIGH);
      digitalWrite(4, HIGH);
      delay(125);
      digitalWrite(13, LOW);  //relay to light 13 off
      digitalWrite(10, LOW);
      digitalWrite(7, LOW);
      digitalWrite(4, LOW);
      digitalWrite(12, HIGH);
      digitalWrite(9, HIGH);  //relay to light  12 on
      digitalWrite(6, HIGH);
      digitalWrite(3, HIGH);
      delay(125);             //  quarter second delay
      digitalWrite(12, LOW);  // relay to light  12 off
      digitalWrite(9, LOW);
      digitalWrite(6, LOW);
      digitalWrite(3, LOW);
      digitalWrite(11, HIGH);
      digitalWrite(8, HIGH);
      digitalWrite(5, HIGH);
      digitalWrite(2, HIGH);
      delay(120);
      digitalWrite(11, LOW);
      digitalWrite(8, LOW);
      digitalWrite(5, LOW);
      digitalWrite(2, LOW);
      digitalWrite(13, HIGH);  // all flashing
      digitalWrite(12, HIGH);
      digitalWrite(11, HIGH);
      digitalWrite(10, HIGH);
      digitalWrite(9, HIGH);
      digitalWrite(8, HIGH);
      digitalWrite(7, HIGH);
      digitalWrite(6, HIGH);
      digitalWrite(5, HIGH);
      digitalWrite(4, HIGH);
      digitalWrite(3, HIGH);
      digitalWrite(2, HIGH);
      delay(120);
      digitalWrite(13, LOW);
      digitalWrite(12, LOW);
      digitalWrite(11, LOW);
      digitalWrite(10, LOW);
      digitalWrite(9, LOW);
      digitalWrite(8, LOW);
      digitalWrite(7, LOW);
      digitalWrite(6, LOW);
      digitalWrite(5, LOW);
      digitalWrite(4, LOW);
      digitalWrite(3, LOW);
      digitalWrite(2, LOW);
      delay(120);
      digitalWrite(13, HIGH);
      digitalWrite(12, HIGH);
      digitalWrite(11, HIGH);
      digitalWrite(10, HIGH);
      digitalWrite(9, HIGH);
      digitalWrite(8, HIGH);
      digitalWrite(7, HIGH);
      digitalWrite(6, HIGH);
      digitalWrite(5, HIGH);
      digitalWrite(4, HIGH);
      digitalWrite(3, HIGH);
      digitalWrite(2, HIGH);
      delay(120);
      digitalWrite(13, LOW);
      digitalWrite(12, LOW);
      digitalWrite(11, LOW);
      digitalWrite(10, LOW);
      digitalWrite(9, LOW);
      digitalWrite(8, LOW);
      digitalWrite(7, LOW);
      digitalWrite(6, LOW);
      digitalWrite(5, LOW);
      digitalWrite(4, LOW);
      digitalWrite(3, LOW);
      digitalWrite(2, LOW);
      delay(120);
      digitalWrite(13, HIGH);
      digitalWrite(12, HIGH);
      digitalWrite(11, HIGH);
      digitalWrite(10, HIGH);
      digitalWrite(9, HIGH);
      digitalWrite(8, HIGH);
      digitalWrite(7, HIGH);
      digitalWrite(6, HIGH);
      digitalWrite(5, HIGH);
      digitalWrite(4, HIGH);
      digitalWrite(3, HIGH);
      digitalWrite(2, HIGH);
      delay(120);
      digitalWrite(13, LOW);
      digitalWrite(12, LOW);
      digitalWrite(11, LOW);
      digitalWrite(10, LOW);
      digitalWrite(9, LOW);
      digitalWrite(8, LOW);
      digitalWrite(7, LOW);
      digitalWrite(6, LOW);
      digitalWrite(5, LOW);
      digitalWrite(4, LOW);
      digitalWrite(3, LOW);
      digitalWrite(2, LOW);
      delay(120);
    }
  }
}

rockettownstem · May 7, 2025, 12:09am

Thank you

JoeHuber · May 7, 2025, 12:24am

The Arduino IDE will help you find similar issues in the future.

Use the AutoFormat item in the Tools menu.
Note the Grey vertical lines to the left of your code. They show the extent of each code block which generally start and end with a { and } pair.
Visually note that your original code did not have a closing } at the bottom if the left two lines.
If you click on one { the IDE will highlight the match }. This is very helpful when you have several nested levels of code blocks.
Also note clicking on either a ( or ) will highlight the matching nested item of the pair.

It goes without saying that { }, ( ) and [ ] are always used in matched pairs and when you miss one the compiler can get very off track looking for the missing half of the pair.

rockettownstem · May 7, 2025, 12:21pm

I appreciate your help.

Topic		Replies	Views
Countdown timer misbehaving Programming	5	464	December 6, 2022
Help requested : Countdown timer Programming	2	7396	May 6, 2021
Need help adding a countdown function General Guidance	10	1359	May 5, 2021
Help using If statements (ithink) Programming	11	1694	May 5, 2021
need help with making this code please! :) Programming	7	859	May 5, 2021

Help Find Error "}"

Related topics