help with - 2 digit 7 segment display and 2 74hc595

Projects General Guidance
22

but i don't know how good it is

Code of this kind is generally not usable in a real project as it requires fast and fairly constant loop() execution. You should put it inside of a timer isr so its execution is independent of loop() timing.