How to use two switch to control an AC bulb using Arduino

[afotech]

I was trying to use a Bluetooth module and a touch sensor with my Arduino to control an AC bulb using relay....... and I was finding it difficult to write the correct coding....

Please can someone help me check my mistakes or even a better solution please

#define ctsPin 2
int ledPin =13;
char Incoming_Value = 0;

void setup()
{
    Serial.begin(9600);
    pinMode(ledPin, OUTPUT);
    pinMode(ctsPin, INPUT);
    
}
void loop()
    {
    checkButton();
    loop1();
    loop2();
}
void checkButton();
{
    int button state = digitalRead(INPUT)
    if(button state == HIGH)
    { loop1();}
        else
      {
         loop2();
      }
}
void loop1()
{
    int ctsValue = digitalRead(ctsPin);
    if(ctsValue == HIGH)
    {
    digitalWrite(ledPin, HIGH);
    Serial.println("TOUCHED");
}
else 
{
    digitalWrite(ledPin, LOW);
    Serial.println("not touched");
    
}
delay(100);
}

void loop2()
{
    if(Serial.available()>0)
    {
        InComing_Value = Serial.read();
      Serial.println(Incoming_Value);
      Serial.print("\n");
      if(Incoming_Value =='1') 
      digitalWrite(ledPin, HIGH);
      else if(Incoming_Value =='0')
        dogitalWrite(ledPin, LOW);
        }
}

[gcjr]

@afotech

int button state = digitalRead(INPUT)

• what is "INPUT"? shouldn't there be a pin defined and configures as "INPUT" or "INPUT_PULLUP"?
• variable names can't have spaces, "int button state". could be "button_state" or "buttonState"
• don't see any reference to a relay unless you're using the ledPin as a stand in

[afotech]

Yes I am using the ledPin for the output and the only output is the relay

Thank you

I have corrected it by deleting the space but still facing some challenges

#define ctsPin 2
int ledPin =13;
char Incoming_Value = 0;

void setup()
{
    Serial.begin(9600);
    pinMode(ledPin, OUTPUT);
    pinMode(ctsPin, INPUT);
    
}
void loop()
    {
    checkButton();
    loop1();
    loop2();
}
void checkButton()
{
    int buttonState = digitalRead(INPUT)
    if(buttonState == HIGH)
    { loop1();
        }
        else
      {
         loop2();
      }
}
void loop1()
{
    int ctsValue = digitalRead(ctsPin);
    if(ctsValue == HIGH)
    {
    digitalWrite(ledPin, HIGH);
    Serial.println("TOUCHED");
}
else 
{
    digitalWrite(ledPin, LOW);
    Serial.println("not touched");
    
}
delay(100);
}

void loop2()
{
    if(Serial.available()>0)
    {
      int  InComing_Value = Serial.read();
      Serial.println(Incoming_Value);
      Serial.print("\n");
      if(Incoming_Value =='1') 
      digitalWrite(ledPin, HIGH);
      else if(Incoming_Value =='0')
        digitalWrite(ledPin, LOW);
        }
   
}

[ToddL1962]

I many problems with the code itself. Also, it will be difficult for anyone to write the "correct coding" without knowing how everything is wired and what you expect to receive via serial in order to control the bulb.

What button are you checking here? INPUT does not define a button pin. button state is not a valid variable name either. buttonState would be a valid variable name, however.

void checkButton();
{
  int button state = digitalRead(INPUT)
  if (button state == HIGH)
  {
    loop1();
  }
  else
  {
    loop2();
  }
}

[gcjr]

good that you tried using sub-functions but it's common to over complicate the problem

consider

const byte LedPin = 13;
const byte CtsPin = 2;

byte ctsState;

// -----------------------------------------------------------------------------
void loop ()
{
    // check for button(?) press
    byte cts = digitalRead (CtsPin);
    if (ctsState != cts) {  // state change
        ctsState = cts;
        delay (10);         // debounce

        if (LOW == cts)     // pressed
            digitalWrite (LedPin, ! digitalRead (LedPin));  // toggle
    }

    // -------------------------------------
    // check for serial input
    if (Serial.available ()) {
        char c = Serial.read ();
        Serial.println (c);

        if ('1' == c)
            digitalWrite (LedPin, HIGH);
        else if ('0' == c)
            digitalWrite (LedPin, LOW);
    }
}

// -----------------------------------------------------------------------------
void setup ()
{
    Serial.begin (9600);

    pinMode (LedPin, OUTPUT);
    pinMode (CtsPin, INPUT);
    ctsState = digitalRead (CtsPin);
}

Capitalize constants

[afotech]

I used the INPUT so as if I am using the Bluetooth module it will refer to it as in and likewise the touch sensor

[afotech]

@gcjr

'1' == c)
            digitalWrite (LedPin, HIGH);
        else if ('0' == c)

The 1==c
0==c

Is the c both in lower case letters ?

[gcjr]

@afotech

Is the c both in lower case letters ?

@gcjr

char c = Serial.read ();

yes lower case 'c'. often better to keep local variables short. 'i', 'n' are often integers, 'f' for float, 'c' for chars, 's' for c-strings

[afotech]

Actually the "INPUT" is any output from both the Bluetooth module and the touch sensor to the Arduino as an INPUT........

[afotech]

Okay thanks alot

[ToddL1962]

@afotech

Actually the "INPUT" is any output from both the Bluetooth module and the touch sensor to the Arduino as an INPUT........

Well the identifier INPUT is defined by the Arduino core to indicate a pin mode as in:

pinMode(ctsPin, INPUT);

However, digitalRead(INPUT) makes no sense since INPUT does NOT define a pin number.

[afotech]

Yes noted..... thank you so much

[afotech]

Thanks alot for the code you gave me....it work ed.......I need to learn alot