HTTPClient Problem

Hi everybody,
I just want to know why this code is not working, I want to turn on or off LED in a Timer by using HTTPClient...

#include <WiFi.h>
#include <HTTPClient.h>
#include <Timer.h>


const char* ssid     = "Mehran";
const char* password = "************";

WiFiServer server(80);
Timer t;

void setup()
{
    Serial.begin(115200);
    pinMode(2, OUTPUT);      // set the LED pin mode
    pinMode(5, OUTPUT);      // set the LED pin mode
    pinMode(18, OUTPUT);     // set the LED pin mode

    delay(10);

    // We start by connecting to a WiFi network

    Serial.println();
    Serial.println();
    Serial.print("Connecting to ");
    Serial.println(ssid);

    WiFi.begin(ssid, password);

    while (WiFi.status() != WL_CONNECTED) {
        delay(500);
        Serial.print(".");
    }

    Serial.println("");
    Serial.println("WiFi connected.");
    Serial.println("IP address: ");
    Serial.println(WiFi.localIP());
    
    server.begin();
    
    t.every(5000, TurnLED);
}

bool timer = true;

void TurnLED()
{
      timer = false;
      Serial.println("Timer Started");
      
      HTTPClient http;
      String serverPath = "http://192.168.1.100/H18";
      http.begin(serverPath.c_str());
      http.GET();
}

void loop(){

  if(timer)
  {
      Serial.println("Update Timer");
      t.update();
  }
   
  WiFiClient client = server.available();   // listen for incoming clients
  if (client) {                             // if you get a client,
    Serial.println("New Client.");           // print a message out the serial port
    String currentLine = "";                // make a String to hold incoming data from the client
    while (client.connected()) {            // loop while the client's connected
      if (client.available()) {             // if there's bytes to read from the client,
        char c = client.read();             // read a byte, then
        Serial.write(c);                    // print it out the serial monitor
        Serial.println(c);
        if (c == '\n') {                    // if the byte is a newline character

          // if the current line is blank, you got two newline characters in a row.
          // that's the end of the client HTTP request, so send a response:
          if (currentLine.length() == 0) {
            // HTTP headers always start with a response code (e.g. HTTP/1.1 200 OK)
            // and a content-type so the client knows what's coming, then a blank line:
            client.println("HTTP/1.1 200 OK");
            client.println("Content-type:text/html");
            client.println();

            // the content of the HTTP response follows the header:
            
            client.print("Click <a href=\"/H2\">here</a> to turn the LED on pin 2 Off.
");
            client.print("Click <a href=\"/L2\">here</a> to turn the LED on pin 2 on.
");
            
            client.print("Click <a href=\"/H18\">here</a> to turn the LED on pin 18 Off.
");
            client.print("Click <a href=\"/L18\">here</a> to turn the LED on pin 18 on.
");

            client.print("Click <a href=\"/H5\">here</a> to turn the LED on pin 5 Off.
");
            client.print("Click <a href=\"/L5\">here</a> to turn the LED on pin 5 on.
");

            // The HTTP response ends with another blank line:
            client.println();
            // break out of the while loop:
            break;
          } else {    // if you got a newline, then clear currentLine:
            currentLine = "";
          }
        } else if (c != '\r') {  // if you got anything else but a carriage return character,
          currentLine += c;      // add it to the end of the currentLine
        }

        // Check to see if the client request was "GET /H" or "GET /L":

        if (currentLine.endsWith("GET /H2")) {
          digitalWrite(2, HIGH);               // GET /H turns the LED on
          Serial.println("--------------------------------------------------------");
          Serial.println("H2");
          timer = true;
        }
        
        if (currentLine.endsWith("GET /L2")) {
          digitalWrite(2, LOW);   
          Serial.println("--------------------------------------------------------");
          Serial.println("L2");
        }

        
        if (currentLine.endsWith("GET /H5")) {
          digitalWrite(5, HIGH);               // GET /H turns the LED on
          Serial.println("--------------------------------------------------------");
          Serial.println("H5");
        }
        
        if (currentLine.endsWith("GET /L5")) {
          digitalWrite(5, LOW);   
          Serial.println("--------------------------------------------------------");
          Serial.println("L5");
        }
        
        // GET /L turns the LED off
        if (currentLine.endsWith("GET /H18")) {
          digitalWrite(18, HIGH);                // GET /L turns the LED off
          Serial.println("--------------------------------------------------------");
          Serial.println("H18");
        }
        
        if (currentLine.endsWith("GET /L18")) {
          digitalWrite(18, LOW);                // GET /L turns the LED off
          Serial.println("--------------------------------------------------------");
          Serial.println("L18");
        }
      
    }
    
  }
  
   // close the connection:
    client.stop();
    Serial.println("Client Disconnected.");
  } 
}

I just want to know why this code is not working

in that case you should tell us what it is doing at the moment. Does TurnLED() get called every 5 seconds ?

bool timer = true;

void TurnLED()
{
      timer = false;

timer gets initialized as true, but gets set to false the first time around, and never gets set to 'true' thereafter. Is that what you meant ?

Yes the TurnLED() method is working after 5 seconds but in loop() after

if (client) {
while (client.connected()) {
if (client.available()) {
char c = client.read();

in c variable i just have the character 'G' not "GET /H18" its seems the while loop breaking and i cant get the H18 ...
i just want the device send a command to himself by wifi..

I hope I was able to get what I meant
Thank you for helping..

well your read only the single character at a time,

char c = client.read();             // read a byte, then
        Serial.write(c);                    // print it out the serial monitor
        Serial.println(c);

and print it twice followed by a newline.
Your sketch seems to read all characters available, and check for '\n' and '\r' and do some things according to their presence and otherwise add it to currentLine += c;      // add it to the end of the currentLinebut it is not very transparant.

how about you first read the whole line

while (client.connected()) {            // loop while the client's connected
      while (client.available()) {             // if there's bytes to read from the client,
         char c = client.read();             // read a byte, then
         if  (c != '\n') && (c != '\r')) (
          currentLine += c;
         }
         else {                 
           Serial.println(currentline);
           currentline = "";
         }
      }

Just to make sure that your are receiving what you want before you start on processing.

"well your read only the single character at a time"
I know this but while loop breaking after first character..
And this code never happen!

if  (c != '\n') && (c != '\r')) (
          currentLine += c;
         }

the problem solved :slight_smile:

thank you