iam unable to call two functions inside the while loop?

Other Hardware Motors, Mechanics, Power and CNC
1

the forward function is working well,but the call for "reverse" function is not working.

#include<Stepper.h>

int ms1 = 10;
int ms2 = 9;
int ms3 = 8;
int stepin = 6;
int dirnpin = 7;
int steps;
int reset = 4;
int k;
int value;
int stepstomoveback;
int fstepvalue;

void setup() 
{ 
pinMode(reset,OUTPUT);
digitalWrite(reset,HIGH);
pinMode(ms1,OUTPUT);
pinMode(ms2,OUTPUT);
pinMode(ms3,OUTPUT);
pinMode(stepin,OUTPUT);
pinMode(dirnpin,OUTPUT);
Serial.begin(9600);
Serial.println("enter number of times u want to call the function");
 }

void loop() {
digitalWrite(ms1,HIGH);
digitalWrite(ms2,HIGH);
digitalWrite(ms3,HIGH);

while(Serial.available()>0)
  {
 int number = Serial.parseInt();
 Serial.println(number);
  value = 100*number;
  stepstomoveback = (value - fstepvalue);
 
    for(int k =0;k<=number;)
   { forward(100);
    Serial.println(1);
    delay(10);
     k=k+1;
    }
  reverse(value);
  }
}

int forward(int steps)
{
  for(int j = 0;j<steps;j++)
    {
    digitalWrite(stepin,LOW);
    digitalWrite(dirnpin,HIGH);
    delay(5);
    digitalWrite(stepin,HIGH);
    digitalWrite(dirnpin,LOW);
    delay(5);
    }
  }


int reverse(int v)
  { 
    for(int j = 0;j<steps;j++)
    {
    digitalWrite(stepin,LOW);
    digitalWrite(dirnpin,LOW);
    delay(5);
    digitalWrite(stepin,HIGH);
    digitalWrite(dirnpin,HIGH);
    delay(5);
    Serial.println("run");
    }
  }
2

I don't immediately see any reason why the reverse() function won't be called.

I suspect the problem is that nowhere in the reverse() function do you use the value passed to it and stored in the variable v.

Separately, I can't see any reason to have separate functions for fwd and rev when the only difference is the setting of the direction pin. Why not have a single moveMotor() function that takes two parameters direction and number of steps?

Separately (again) it is more usual to write a FOR loop() like this

for(int k = 0; k <= number; k ++)

...R

3

The reverse function is buggy, it uses the variable steps for the loop rather than v, the argument passed to it.

Why is steps declared globally anyway? If a variable is only used locally you shouldn't declare it globally.

4

yes, i changed it now and the function call works and motor rotates.

5

Separately, I can't see any reason to have separate functions for fwd and rev when the only difference is the setting of the direction pin. Why not have a single moveMotor() function that takes two parameters direction and number of steps?

yes i have to do some more stuff so i need to have two functions.

i have one other problem.

#include<Stepper.h>

int ms1 = 10;
int ms2 = 9;
int ms3 = 8;
int stepin = 6;
int dirnpin = 7;
int steps;
int reset = 4;
int k;
int value;
int stepstomoveback;
int fstepvalue;


void setup() 
{ 
pinMode(reset,OUTPUT);
digitalWrite(reset,HIGH);
pinMode(ms1,OUTPUT);
pinMode(ms2,OUTPUT);
pinMode(ms3,OUTPUT);
pinMode(stepin,OUTPUT);
pinMode(dirnpin,OUTPUT);
Serial.begin(9600);
Serial.println("enter number of times u want to call the function");
 }

void loop() {
digitalWrite(ms1,HIGH);
digitalWrite(ms2,HIGH);
digitalWrite(ms3,HIGH);

while(Serial.available()>0)
  {
 int number = Serial.parseInt();
 Serial.println(number);
  value = 100*number;
 
    for(int k =0;k<=number;)
   { forward(100);
    Serial.println(1);
    delay(10);
     k=k+1;
    }
 
   reverse(value);
  }
  
}

int forward(int steps)
{
  for(int j = 0;j<steps;j++)
    {
    digitalWrite(stepin,LOW);
    digitalWrite(dirnpin,HIGH);
    delay(5);
    digitalWrite(stepin,HIGH);
    digitalWrite(dirnpin,LOW);
    delay(5);
    }
    Serial.println("forward spin");
  }

  int reverse(int steps)
{
  for(int j = 0;j<steps;j++)
    {
    digitalWrite(stepin,LOW);
    digitalWrite(dirnpin,HIGH);
    delay(5);
    digitalWrite(stepin,HIGH);
    digitalWrite(dirnpin,LOW);
    delay(5);
    Serial.println("reverse spin");
    }
  }

here after i enter the value the reverse() function runs,i know why it happens.
is there any way to make the forward function run first and then make the reverse function run.
where can i put the condition for it?

6

Your code is very difficult to read. Please use the Auto Format tool to indent it consistently. That makes it much easier to see how the different parts relate to each other.

The reverse() function probably runs first when Serial.parseInt() produces a zero.

IMHO the program needs a complete re-write. Separate the business of getting serial data from the business of moving the motors. Receive the data (if there is any) and save it in a variable. Then check the value of the variable before deciding what to do with the motors. The code in loop() might be something like this

void loop() {
   receiveSerialData();
   checkSerialData();
   moveMotors();
}

Have a look at these links
Serial Input Basics - simple reliable non-blocking ways to receive data.
Planning and Implementing a Program

...R

7

thanks for the help,your idea of getting serial data and then making the motor run is good,in the upcoming projects ill try them.

anyway i figured out a different approach how to make the motors run how i need it to,it works
thanks