If statement not working for serial monitor.

Hi all its me again I am facing another problem where if I enter the correct answer so TRUE all capital in the serial monitor it still says "You typed it incorrectly type TRUE or FALSE all capital even though I typed it correctly and it dosent break the while loop so if the question is wrong it will loop the question you got wrong another thing is that when it says the message when you get the value wrong that it prints on the same line even though I did Serial.println. Anyway heres my sketch I am going to add 2 sketches 1 is my main program and will be put into a zip file since it has lots of lines of code and the other one is where the problem is coming from which will be posted.

void questions() {
  const int TRUE = truebutton;
  const int FALSE = falsebutton;
  String question1, question2, question3, question4, question5, question6, question7, question8,
         question9, question10;
  int rightanswer1, rightanswer2, rightanswer3, rightanswer4, rightanswer5, rightanswer6, rightanswer7,
      rightanswer8, rightanswer9, rightanswer10;
  int wronganswer1, wronganswer2, wronganswer3, wronganswer4, wronganswer5, wronganswer6, wronganswer7,
      wronganswer8, wronganswer9, wronganswer10;
  Serial.println("Enter question 1 (No long questions)");
  while (Serial.available() == 0) {}
  question1 = Serial.readString();
  do{
  Serial.print("Enter the right answer");
  while (Serial.available() == 0) {}
  rightanswer1 = Serial.parseInt();
  if (rightanswer1 == TRUE || rightanswer1 == FALSE) {
    break;
  }
  else if(rightanswer1 != TRUE || rightanswer1 != FALSE){
    Serial.println("You typed it incorrectly type TRUE or FALSE all capital.");
  }
  }
  while(true);
  do{
  Serial.println("Enter the wrong answer");
  while (Serial.available() == 0) {}
  wronganswer1 = Serial.parseInt();
  if(wronganswer1==TRUE || wronganswer1==FALSE){
    break;
  }
  else if(wronganswer1 != TRUE || wronganswer1 !=FALSE){
    Serial.println("You typed it incorrectly type TRUE or FALSE all capital.");
  }
  }
  while(true);
}

Thankyou, Brock :slight_smile:

trueorfalsegame-200330a.zip (2.39 KB)

I enter the correct answer so TRUE all capital in the serial monitor

Where exactly are you testing what was entered in the Serial monitor ?

Please post your complete program here rather than attaching it. Many people won't or can't download a .zip file

#include <LiquidCrystal_I2C.h>
LiquidCrystal_I2C lcd(0x27, 20, 4);
int enableallquestions = 0; //Disable questions change the 1 to 0 (DEBUGGING ONLY)
int enablebuttondebugging = 0;
const int redled = 13;
const int blueled = 12;
const int greenled = 11;
const int statusled = 7;
const int falsebutton = 10;
const int truebutton = 9;
const int buzzer = 8;
const int activebuzzer = 6;
void setup() {
  Serial.begin(9600);
  lcd.init();
  lcd.backlight();
  pinMode(redled, OUTPUT);
  pinMode(greenled, OUTPUT);
  pinMode(blueled, OUTPUT);
  pinMode(statusled, OUTPUT);
  pinMode(buzzer, OUTPUT);
  pinMode(activebuzzer, OUTPUT);
  pinMode(falsebutton, INPUT_PULLUP);
  pinMode(truebutton, INPUT_PULLUP);
}
void questions() {
  const int TRUE = truebutton;
  const int FALSE = falsebutton;
  String question1, question2, question3, question4, question5, question6, question7, question8,
         question9, question10;
  int rightanswer1, rightanswer2, rightanswer3, rightanswer4, rightanswer5, rightanswer6, rightanswer7,
      rightanswer8, rightanswer9, rightanswer10;
  int wronganswer1, wronganswer2, wronganswer3, wronganswer4, wronganswer5, wronganswer6, wronganswer7,
      wronganswer8, wronganswer9, wronganswer10;
  Serial.println("Enter question 1 (No long questions)");
  while (Serial.available() == 0) {}
  question1 = Serial.readString();
  do{
  Serial.print("Enter the right answer");
  while (Serial.available() == 0) {}
  rightanswer1 = Serial.parseInt();
  if (rightanswer1 == TRUE || rightanswer1 == FALSE) {
    break;
  }
  else if(rightanswer1 != TRUE || rightanswer1 != FALSE){
    Serial.println("You typed it incorrectly type TRUE or FALSE all capital.");
  }
  }
  while(true);
  do{
  Serial.println("Enter the wrong answer");
  while (Serial.available() == 0) {}
  wronganswer1 = Serial.parseInt();
  if(wronganswer1==TRUE || wronganswer1==FALSE){
    break;
  }
  else if(wronganswer1 != TRUE || wronganswer1 !=FALSE){
    Serial.println("You typed it incorrectly type TRUE or FALSE all capital.");
  }
  }
  while(true);
}
void maingamecode() {
  boolean questiondone = false;
  const int TRUE = truebutton;
  const int FALSE = falsebutton;
    String question1, question2, question3, question4, question5, question6, question7, question8,
         question9, question10;
  int rightanswer1, rightanswer2, rightanswer3, rightanswer4, rightanswer5, rightanswer6, rightanswer7,
      rightanswer8, rightanswer9, rightanswer10;
  int wronganswer1, wronganswer2, wronganswer3, wronganswer4, wronganswer5, wronganswer6, wronganswer7,
      wronganswer8, wronganswer9, wronganswer10;
      questions();
      
  while (questiondone == false) {
   // Serial.print("fff");
    digitalWrite(statusled, HIGH);
    lcd.setCursor(0, 0);
    lcd.print(question1); //Question 1
    if (digitalRead(rightanswer1) == 0) {
      digitalWrite(statusled, LOW);
      digitalWrite(greenled, HIGH);
      delay(3000);
      for (int x = 0; x < 5; x++) {
        digitalWrite(greenled, HIGH);
        delay(100);
        digitalWrite(greenled, LOW);
        delay(100);
        digitalWrite(blueled, HIGH);
        delay(100);
        digitalWrite(blueled, LOW);
        delay(100);
        digitalWrite(redled, HIGH);
        delay(100);
        digitalWrite(redled, LOW);
        delay(100);
        digitalWrite(redled, HIGH);
        delay(100);
        digitalWrite(redled, LOW);
        delay(100);
        digitalWrite(blueled, HIGH);
        delay(100);
        digitalWrite(blueled, LOW);
        delay(100);
        digitalWrite(greenled, HIGH);
        delay(100);
        digitalWrite(greenled, LOW);
        delay(100);
      }
      rightanswertone();
    }
    else if (digitalRead(wronganswer1) == 0) {
      digitalWrite(statusled, LOW);
      digitalWrite(redled, HIGH);
      digitalWrite(activebuzzer, HIGH);
      delay(3000);
      digitalWrite(redled, LOW);
      digitalWrite(activebuzzer, LOW);
    }
  }
}
void rightanswertone() {
#define NOTE_B0  31
#define NOTE_C1  33
#define NOTE_CS1 35
#define NOTE_D1  37
#define NOTE_DS1 39
#define NOTE_E1  41
#define NOTE_F1  44
#define NOTE_FS1 46
#define NOTE_G1  49
#define NOTE_GS1 52
#define NOTE_A1  55
#define NOTE_AS1 58
#define NOTE_B1  62
#define NOTE_C2  65
#define NOTE_CS2 69
#define NOTE_D2  73
#define NOTE_DS2 78
#define NOTE_E2  82
#define NOTE_F2  87
#define NOTE_FS2 93
#define NOTE_G2  98
#define NOTE_GS2 104
#define NOTE_A2  110
#define NOTE_AS2 117
#define NOTE_B2  123
#define NOTE_C3  131
#define NOTE_CS3 139
#define NOTE_D3  147
#define NOTE_DS3 156
#define NOTE_E3  165
#define NOTE_F3  175
#define NOTE_FS3 185
#define NOTE_G3  196
#define NOTE_GS3 208
#define NOTE_A3  220
#define NOTE_AS3 233
#define NOTE_B3  247
#define NOTE_C4  262
#define NOTE_CS4 277
#define NOTE_D4  294
#define NOTE_DS4 311
#define NOTE_E4  330
#define NOTE_F4  349
#define NOTE_FS4 370
#define NOTE_G4  392
#define NOTE_GS4 415
#define NOTE_A4  440
#define NOTE_AS4 466
#define NOTE_B4  494
#define NOTE_C5  523
#define NOTE_CS5 554
#define NOTE_D5  587
#define NOTE_DS5 622
#define NOTE_E5  659
#define NOTE_F5  698
#define NOTE_FS5 740
#define NOTE_G5  784
#define NOTE_GS5 831
#define NOTE_A5  880
#define NOTE_AS5 932
#define NOTE_B5  988
#define NOTE_C6  1047
#define NOTE_CS6 1109
#define NOTE_D6  1175
#define NOTE_DS6 1245
#define NOTE_E6  1319
#define NOTE_F6  1397
#define NOTE_FS6 1480
#define NOTE_G6  1568
#define NOTE_GS6 1661
#define NOTE_A6  1760
#define NOTE_AS6 1865
#define NOTE_B6  1976
#define NOTE_C7  2093
#define NOTE_CS7 2217
#define NOTE_D7  2349
#define NOTE_DS7 2489
#define NOTE_E7  2637
#define NOTE_F7  2794
#define NOTE_FS7 2960
#define NOTE_G7  3136
#define NOTE_GS7 3322
#define NOTE_A7  3520
#define NOTE_AS7 3729
#define NOTE_B7  3951
#define NOTE_C8  4186
#define NOTE_CS8 4435
#define NOTE_D8  4699
#define NOTE_DS8 4978
#define REST      0


  // change this to make the song slower or faster
  int tempo = 180;

  // change this to whichever pin you want to use

  // notes of the moledy followed by the duration.
  // a 4 means a quarter note, 8 an eighteenth , 16 sixteenth, so on
  // !!negative numbers are used to represent dotted notes,
  // so -4 means a dotted quarter note, that is, a quarter plus an eighteenth!!
  int melody[] = {

    // Nokia Ringtone
    // Score available at https://musescore.com/user/29944637/scores/5266155

    NOTE_E5, 8, NOTE_D5, 8, NOTE_FS4, 4, NOTE_GS4, 4,
    NOTE_CS5, 8, NOTE_B4, 8, NOTE_D4, 4, NOTE_E4, 4,
    NOTE_B4, 8, NOTE_A4, 8, NOTE_CS4, 4, NOTE_E4, 4,
    NOTE_A4, 2,
  };

  // sizeof gives the number of bytes, each int value is composed of two bytes (16 bits)
  // there are two values per note (pitch and duration), so for each note there are four bytes
  int notes = sizeof(melody) / sizeof(melody[0]) / 2;

  // this calculates the duration of a whole note in ms
  int wholenote = (60000 * 4) / tempo;

  int divider = 0, noteDuration = 0;
  // iterate over the notes of the melody.
  // Remember, the array is twice the number of notes (notes + durations)
  for (int thisNote = 0; thisNote < notes * 2; thisNote = thisNote + 2) {

    // calculates the duration of each note
    divider = melody[thisNote + 1];
    if (divider > 0) {
      // regular note, just proceed
      noteDuration = (wholenote) / divider;
    } else if (divider < 0) {
      // dotted notes are represented with negative durations!!
      noteDuration = (wholenote) / abs(divider);
      noteDuration *= 1.5; // increases the duration in half for dotted notes
    }

    // we only play the note for 90% of the duration, leaving 10% as a pause
    tone(buzzer, melody[thisNote], noteDuration * 0.9);

    // Wait for the specief duration before playing the next note.
    delay(noteDuration);

    // stop the waveform generation before the next note.
    noTone(buzzer);
  }
}
void loop() {
  maingamecode();
}

Im making it so you can change questions from the serial monitor

brockie14:
Im making it so you can change questions from the serial monitor

I have no idea what that means. Please explain

ur talking about this right??

  Serial.println("Enter question 1 (No long questions)");
  while (Serial.available() == 0) {}
  question1 = Serial.readString();
  do{
  Serial.print("Enter the right answer");
  while (Serial.available() == 0) {}
  rightanswer1 = Serial.parseInt();
  if (rightanswer1 == TRUE || rightanswer1 == FALSE) {
    break;
  }
  else if(rightanswer1 != TRUE || rightanswer1 != FALSE){
    Serial.println("You typed it incorrectly type TRUE or FALSE all capital.");
  }
  }
  while(true);
  do{
  Serial.println("Enter the wrong answer");
  while (Serial.available() == 0) {}
  wronganswer1 = Serial.parseInt();
  if(wronganswer1==TRUE || wronganswer1==FALSE){
    break;
  }
  else if(wronganswer1 != TRUE || wronganswer1 !=FALSE){
    Serial.println("You typed it incorrectly type TRUE or FALSE all capital.");
  }
  }
  while(true);

or what about this??

void maingamecode() {
  boolean questiondone = false;
  const int TRUE = truebutton;
  const int FALSE = falsebutton;
    String question1, question2, question3, question4, question5, question6, question7, question8,
         question9, question10;
  int rightanswer1, rightanswer2, rightanswer3, rightanswer4, rightanswer5, rightanswer6, rightanswer7,
      rightanswer8, rightanswer9, rightanswer10;
  int wronganswer1, wronganswer2, wronganswer3, wronganswer4, wronganswer5, wronganswer6, wronganswer7,
      wronganswer8, wronganswer9, wronganswer10;
      questions();
      
  while (questiondone == false) {
   // Serial.print("fff");
    digitalWrite(statusled, HIGH);
    lcd.setCursor(0, 0);
    lcd.print(question1); //Question 1
    if (digitalRead(rightanswer1) == 0) {
      digitalWrite(statusled, LOW);
      digitalWrite(greenled, HIGH);
      delay(3000);
      for (int x = 0; x < 5; x++) {
        digitalWrite(greenled, HIGH);
        delay(100);
        digitalWrite(greenled, LOW);
        delay(100);
        digitalWrite(blueled, HIGH);
        delay(100);
        digitalWrite(blueled, LOW);
        delay(100);
        digitalWrite(redled, HIGH);
        delay(100);
        digitalWrite(redled, LOW);
        delay(100);
        digitalWrite(redled, HIGH);
        delay(100);
        digitalWrite(redled, LOW);
        delay(100);
        digitalWrite(blueled, HIGH);
        delay(100);
        digitalWrite(blueled, LOW);
        delay(100);
        digitalWrite(greenled, HIGH);
        delay(100);
        digitalWrite(greenled, LOW);
        delay(100);
      }
      rightanswertone();
    }
    else if (digitalRead(wronganswer1) == 0) {
      digitalWrite(statusled, LOW);
      digitalWrite(redled, HIGH);
      digitalWrite(activebuzzer, HIGH);
      delay(3000);
      digitalWrite(redled, LOW);
      digitalWrite(activebuzzer, LOW);
    }
  }
}

I must admit I am confused as to what you are doing

Please explain it in English sentences and be very clear as to what is entered, where it is entered and where it is stored if it is stored

what about this??

What I see is a program crying out to use arrays

Do a Serial.print(rightanswer1) right after your Serial.parseInt()

What do you get?

Okay I’m basically making a true or false game right? Now I want to make it so you can change the questions and answers from the serial monitor which makes it so U don’t need to change the source code and the values are going to be stored in the variables which the program will acces but when I type the correct answer like TRUE or FALSE it says the message when you don’t type TRUE or FALSE right so if you type it lowercase and it won’t break out of the loop when answer is all capital

I'll do it tomorrow I'm off to bed lol

when I type the correct answer like TRUE or FALSE it says the message when you don't type TRUE or FALSE right

Where in the code is the test whether you entered the text TRUE or FALSE ?

Read the code in the second sketch that's why I uploaded my sketch. It's in the questions function where it says Serial.println("Enter right answer");
It's underneath that statement and you should see a if statement that is like if(rightanswer1!=TRUE || rightanswer1!=FALSE){
Serial.println"you entered the wrong value type TRUE or FALSE all capital.

Look at your questions() function. truebutton and falsebutton are constants which are 9 and 10, respectively. These are pin numbers. In your code you set TRUE and FALSE equal to truebutton and falsebutton, respectively. You use Serial.parseInt() to get the answer and then compare to TRUE and FALSE. Therefore you must enter 9 or 10 into the serial monitor NOT "TRUE" or "FALSE".

void questions() {
  const int TRUE = truebutton;
  const int FALSE = falsebutton;
  String question1, question2, question3, question4, question5, question6, question7, question8,
         question9, question10;
  int rightanswer1, rightanswer2, rightanswer3, rightanswer4, rightanswer5, rightanswer6, rightanswer7,
      rightanswer8, rightanswer9, rightanswer10;
  int wronganswer1, wronganswer2, wronganswer3, wronganswer4, wronganswer5, wronganswer6, wronganswer7,
      wronganswer8, wronganswer9, wronganswer10;
  Serial.println("Enter question 1 (No long questions)");
  while (Serial.available() == 0) {}
  question1 = Serial.readString();
  do {
    Serial.print("Enter the right answer");
    while (Serial.available() == 0) {}
    rightanswer1 = Serial.parseInt();
    if (rightanswer1 == TRUE || rightanswer1 == FALSE) {
      break;
    }
    else if (rightanswer1 != TRUE || rightanswer1 != FALSE) {
      Serial.println("You typed it incorrectly type TRUE or FALSE all capital.");
    }
  }
  while (true);
  do {
    Serial.println("Enter the wrong answer");
    while (Serial.available() == 0) {}
    wronganswer1 = Serial.parseInt();
    if (wronganswer1 == TRUE || wronganswer1 == FALSE) {
      break;
    }
    else if (wronganswer1 != TRUE || wronganswer1 != FALSE) {
      Serial.println("You typed it incorrectly type TRUE or FALSE all capital.");
    }
  }
  while (true);
}

You have the following variables defined locally in the questions() function and also locally in the maingamecode() function. These are two different scopes for these variables. I assume you want these defined globally. However, it is usually a bad idea to use String on an avr-based Arduino.

  String question1, question2, question3, question4, question5, question6, question7, question8,
         question9, question10;
  int rightanswer1, rightanswer2, rightanswer3, rightanswer4, rightanswer5, rightanswer6, rightanswer7,
      rightanswer8, rightanswer9, rightanswer10;
  int wronganswer1, wronganswer2, wronganswer3, wronganswer4, wronganswer5, wronganswer6, wronganswer7,
      wronganswer8, wronganswer9, wronganswer10;

Your code would be much cleaner if you used arrays.