I found your code extremely difficult to read because of the way long lines of code and comments are all jumbled up. To my mind this re-formatted version is much easier to read, but could probably be improved further
/* Solitaire Project
Build Version: 0.11
Build Status: Unfinished, created structure for all variables
Build Objectives: Use structures to create a streamlined method for independent flashes of various duty-cycles
*/
const int locationNumber = 3;
//the number of given locations we're tracking, in this case 3
int locationDistance[] = {712, 104, 1107};
//the distance in metres to each location
float locationBearing[] = {202, 172, 5};
//the bearing of the locations relative to north
int userBearing;
//currently unused/set to 0, but will eventually be derived from a compass IMU bearing in relation to the location bearings to give real-time bearing updates relative to the user
int pulseTime = 100;
//the length in millis for any given pulse
struct locations {
//the structure array defining the variables that define the strength and frequency of a given locations pulse signature
int locationDelay[locationNumber];
//the delay between pulses that's derived from the locationDistance
unsigned long previousMillis[locationNumber];
//previous amount of time between actions for each location
bool pulseON[locationNumber];
//the status of the pin, whether its ON or OFF
int bearingStrength[locationNumber];
//the PWM value for each output, derived from how close the user bearing (currently north) is to the locations bearing
int pinNumber[locationNumber];
int bearingStrengthTotal;
//the aggregate total of all of these outputs, used to define the final PWM value to the pin
} locations[] = {
//define the two types, the RIGHT-hand pin, and the LEFT-hand pin
{{}, {}, {}, {}, 0, 0}, //RIGHT
{{}, {}, {}, {}, 0, 0}, //LEFT
/*
^^^ INDEX VALUES FOR ^^^
{{0,0,0}, {0,0,0}, {0,0,0}, {0,0,0}, 0 }, //RIGHT
{{0,0,0}, {0,0,0}, {0,0,0}, {0,0,0}, 0 }, //LEFT
*/
};
void setup() {
Serial.begin (9600);
//begin serial
for (int thisSide = 0; thisSide <= 2; thisSide++) {
for (int thisLocation = 0; thisLocation < locationNumber; thisLocation++) {
//turn off all outputs
locations[thisSide].pulseON[thisLocation] = false;
}
}
}
void loop() {
for (int thisLocation = 0; thisLocation < locationNumber; thisLocation++) {
//begin by pushing each location's bearing through an equation that defines it's individual PWM value for each side
locations[0].bearingStrength[thisLocation] = ((float(255) / 100) * (100 - (locationBearing[thisLocation] / 180) * 100));
if (locations[0].bearingStrength[thisLocation] <= 0) {
locations[0].bearingStrength[thisLocation] = 0;
locations[0].pinNumber[thisLocation] = 10;
//also sets the pins for every location
}
locations[1].bearingStrength[thisLocation] = ((float(255) / 100) * ((((locationBearing[thisLocation]) - 180) / 180) * 100));
//there's two equations; if the bearing is >180, the LEFT hand pin has a PWM of 0 for that location, and vice versa
if (locations[1].bearingStrength[thisLocation] <= 0) {
locations[1].bearingStrength[thisLocation] = 0;
locations[1].pinNumber[thisLocation] = 9;
}
}
for (int thisSide = 0; thisSide <= 2; thisSide++) {
unsigned long currentMillis = millis();
for (int thisLocation = 0; thisLocation < locationNumber; thisLocation++) {
//for each location, set the delay in millis to equal the distance in metres
locations[thisSide].locationDelay[thisLocation] = locationDistance[thisLocation];
if ((currentMillis - locations[thisSide].previousMillis[thisLocation] >= pulseTime) && (locations[thisSide].pulseON[thisLocation] == true)) {
//check if the pulse has run long enough
locations[thisSide].pulseON[thisLocation] = !locations[thisSide].pulseON[thisLocation];
//set the status of the pulse to OFF
locations[thisSide].bearingStrengthTotal = locations[thisSide].bearingStrengthTotal - locations[thisSide].bearingStrength[thisLocation];
//minus the current PWM value for that location off the aggregate total for that side, effectively turning that pulse OFF
if (locations[thisSide].bearingStrengthTotal <= 0) {
locations[thisSide].bearingStrengthTotal = 0; //if the result ends up less than 0, bump it back up to zero
}
locations[thisSide].previousMillis[thisLocation] = currentMillis;
//set the time for that location
analogWrite(locations[thisSide].pinNumber[thisLocation], locations[thisSide].bearingStrengthTotal);
//UPDATE THE PIN WITH THE NEW AGGREGATE TOTAL PWM VALUE OF ALL LOCATIONS FOR THE GIVEN SIDE
}
else if ((currentMillis - locations[thisSide].previousMillis[thisLocation] >= locations[thisSide].locationDelay[thisLocation]) && (locations[thisSide].pulseON[thisLocation] == false)) {
//check if the delay has run long enough
locations[thisSide].pulseON[thisLocation] = !locations[thisSide].pulseON[thisLocation];
//set the status of the pulse to ON
locations[thisSide].bearingStrengthTotal = locations[thisSide].bearingStrengthTotal + locations[thisSide].bearingStrength[thisLocation];
//add the current PWM value for that location to the aggregate total for that side, effectively turning that pulse ON
if (locations[thisSide].bearingStrengthTotal >= 255) {
locations[thisSide].bearingStrengthTotal = 255;
//if the total goes above 255, keep it from going any higher than 255
}
locations[thisSide].previousMillis[thisLocation] = currentMillis;
//set the time for each location
analogWrite(locations[thisSide].pinNumber[thisLocation], locations[thisSide].bearingStrengthTotal);
//UPDATE THE PIN WITH THE NEW AGGREGATE TOTAL PWM VALUE OF ALL LOCATIONS FOR THE GIVEN SIDE
}
}
}
}
It seems to me that the first FOR in loop() only deals with things that never change and should probably be in setup().
This line (in the second FOR)
unsigned long currentMillis = millis();
is almost certainly in the wrong place. I suspect it should be the first line in loop() so that the same value of currentMillis is used in all the tests.
It would be a big help if you could provide a description in English of how the code is intended to work
...R