Issues with attachInterrupt

The final design has the 5V signal coming from elsewhere in the overall circuit. The power supply was just for testing but it provided the proper functioning, so I don't see a hugh issue with that. Am i missing something?