Hi Guys
I am making a mini 3-key piano. I want a code such that if PB is pressed the pitch is the output.
I tried it but I failed. I had used the tone() library.
I tried it but I failed. I had used the tone() library.
Post the code that did not do what you want and explain what it did when you ran it.
The Full code
#include "pitches.h"
int spkr=8;
int b1=12;
int b2=11;
int b3=10;
int tune[]={NOTE_C4,NOTE_G4,NOTE_C5};
void setup()
{
pinMode(b1,INPUT);
pinMode(b2,INPUT);
pinMode(b3,INPUT);
}
void loop()
{
int state1=digitalRead(b1);
int state2=digitalRead(b2);
int state3=digitalRead(b3);
int times=1;
if (state1==HIGH)
{
tone(spkr,tune[1],times);
}
if (state2==HIGH)
{
tone(spkr,tune[2],times);
}
if (state3==HIGH)
{
tone(spkr,tune[3],times);
}
}
and also the pitches.h
/*************************************************
* Public Constants
*************************************************/
#define NOTE_B0 31
#define NOTE_C1 33
#define NOTE_CS1 35
#define NOTE_D1 37
#define NOTE_DS1 39
#define NOTE_E1 41
#define NOTE_F1 44
#define NOTE_FS1 46
#define NOTE_G1 49
#define NOTE_GS1 52
#define NOTE_A1 55
#define NOTE_AS1 58
#define NOTE_B1 62
#define NOTE_C2 65
#define NOTE_CS2 69
#define NOTE_D2 73
#define NOTE_DS2 78
#define NOTE_E2 82
#define NOTE_F2 87
#define NOTE_FS2 93
#define NOTE_G2 98
#define NOTE_GS2 104
#define NOTE_A2 110
#define NOTE_AS2 117
#define NOTE_B2 123
#define NOTE_C3 131
#define NOTE_CS3 139
#define NOTE_D3 147
#define NOTE_DS3 156
#define NOTE_E3 165
#define NOTE_F3 175
#define NOTE_FS3 185
#define NOTE_G3 196
#define NOTE_GS3 208
#define NOTE_A3 220
#define NOTE_AS3 233
#define NOTE_B3 247
#define NOTE_C4 262
#define NOTE_CS4 277
#define NOTE_D4 294
#define NOTE_DS4 311
#define NOTE_E4 330
#define NOTE_F4 349
#define NOTE_FS4 370
#define NOTE_G4 392
#define NOTE_GS4 415
#define NOTE_A4 440
#define NOTE_AS4 466
#define NOTE_B4 494
#define NOTE_C5 523
#define NOTE_CS5 554
#define NOTE_D5 587
#define NOTE_DS5 622
#define NOTE_E5 659
#define NOTE_F5 698
#define NOTE_FS5 740
#define NOTE_G5 784
#define NOTE_GS5 831
#define NOTE_A5 880
#define NOTE_AS5 932
#define NOTE_B5 988
#define NOTE_C6 1047
#define NOTE_CS6 1109
#define NOTE_D6 1175
#define NOTE_DS6 1245
#define NOTE_E6 1319
#define NOTE_F6 1397
#define NOTE_FS6 1480
#define NOTE_G6 1568
#define NOTE_GS6 1661
#define NOTE_A6 1760
#define NOTE_AS6 1865
#define NOTE_B6 1976
#define NOTE_C7 2093
#define NOTE_CS7 2217
#define NOTE_D7 2349
#define NOTE_DS7 2489
#define NOTE_E7 2637
#define NOTE_F7 2794
#define NOTE_FS7 2960
#define NOTE_G7 3136
#define NOTE_GS7 3322
#define NOTE_A7 3520
#define NOTE_AS7 3729
#define NOTE_B7 3951
#define NOTE_C8 4186
#define NOTE_CS8 4435
#define NOTE_D8 4699
#define NOTE_DS8 4978
Apart from any problems with wiring (how are the switches wired ?) you have a programming problem
int tune[] = {NOTE_C4, NOTE_G4, NOTE_C5}; //declare an array of notes tune[0], tune[1] and tune[2]
Later in the program you use tune[3] which is not defined.
if (state3 == HIGH)
{
tone(spkr, tune[3], times);
}
Okay... So can you post the full code please..???
I wired the pins 12,11,10 to three different push buttons with the same +5V VCC. The pin 8 is to the SPKR + and GND to the SPKR -
So what pulls down the button pins to ground when the button is not pushed?
This is why most Arduino projects use buttons between the pin and ground. The necessary resistor is onboard the Arduino already, if you use the INPUT_PULLUP pin mode.
I suggest that you make changes as follows
Wire the push buttons between the input pins and GND
Set the pinMode()s of the inputs to INPUT_PULLUP instead of INPUT. This will ensure that the inputs are always in a known state but will also require a change in the program as follows.
Change the tests for the input states from HIGH to LOW
Change the tune array index values from 1 to 3 to 0 to 2 so that you read from tune[0], tune[1] and tune[2]
Increase the value of the times variable because at the moment each note is only playing for one millisecond
Add some code to turn off the tone at the end of the loop() function.
Okay! Now I am planning to make a full sized 36-Key Keyboard. I have an Arduino Mega ADK.
The datasheet says 54 digital I/O pins but what about the TX and RX??
The Mega has 4 sets of TX and RX and 2 sets of SDA and SCL. Can I use them as the normal I/O inputs??
Those pins were already counted when they counted 54. They are normal I/O pins but they also have additional functions.
What are those additional functions??
Can I code it as
state1=digitalRead(1)
etc..??
Okay ,
When I press 'n' keys at once I want the Arduino to calculate the average of the key freq.
How do I do it?
For example: No.of Keys Frequencies Average(i.e. Output Freq.)
2 262,294 278
What are those additional functions??
SPI, I2C, PWM, etc.
Can I code it as
Code what? Reading from a pin? If so, then, yes that is the way to do it, IF you include the ; on the end.
When I press 'n' keys at once I want the Arduino to calculate the average of the key freq.
How do I do it?
Keys don't have frequencies.
SagarDev:
Okay ,When I press 'n' keys at once I want the Arduino to calculate the average of the key freq.
How do I do it?For example: No.of Keys Frequencies Average(i.e. Output Freq.)
2 262,294 278
averageFrequency = (Frequency1 + Frequency2)/2
So do you mean that I need to define 36 if statements for no.of keys ???