Keypad and password

system · September 7, 2009, 6:20pm

it would like to use a keypad to start a led but it doesn't work,
when the password isn't correct the led is on. and when the password is correct its also on i already checked the tutorials but i can't get fuirther then this any help would be nice

_{#include <Keypad.h>}

_{int ledgroen = 3; // green led}
_{int ledorangje = 4; // orange led}
_{int ledrood = 13; // red led}
_{int doorState = 2;}
_{char PW[] = "1234";}
_{char CANCEL_KEY = '#';}
_{const byte ROWS = 4; // Four rows}
_{const byte COLS = 3; // Three columns}
_{// Define the Keymap}
_{char keys[ROWS][COLS] = {}
_{{'1','2','3'},}
_{{'4','5','6'},}
_{{'7','8','9'},}
_{'','0','#'}
_};
_{// Connect keypad ROW0, ROW1, ROW2 and ROW3 to these Arduino pins.}
_{byte rowPins[ROWS] = { 9, 8, 7, 6 };// Connect keypad COL0, COL1 and COL2 to these Arduino pins.}
_{byte colPins[COLS] = { 12, 11, 10 };}
_{// Create the Keypad}
_{Keypad kpd = Keypad( makeKeymap(keys), rowPins, colPins, ROWS, COLS );}
_{void setup()}
_{

_{pinMode(ledgroen, OUTPUT);}
_{pinMode(ledorangje, OUTPUT);}
_{pinMode(ledrood, OUTPUT);}
_{Serial.begin(9600);}
_}

_{void loop()}
_{

_{switch (doorState) {}
_{case 1:}
_{digitalWrite(ledrood, LOW);}
_delay(500);
_{digitalWrite(ledgroen, HIGH);}
_break;
_{case 2:}
_{digitalWrite(ledrood, HIGH);}
_break;
_}

_{char PW[] = "12345";}
_{char CANCEL_KEY = '}';
_{// returns true when all PW keys are pressed in sequence}
_{// returns false when number of keys in pW pressed but don't exactly match the PW}
_{// CANCEL_KEY erases all previous digits input}
_{char key = kpd.getKey();}

_{if(key) // same as if(key != NO_KEY)}
_{

_{switch (key)}
_{
_{case '#':}
_{
_{char key = kpd.getKey();}

_{doorState= 1;}
_}
_{// digitalWrite(ledrood, LOW);}
_{// digitalWrite(ledgroen, HIGH);}
_break;
_{case '*':}

_{Serial.print("CLEAR");}
_{digitalWrite(ledrood, HIGH);}
_{delay (1000);}
_{digitalWrite(ledrood, LOW);}
_break;
_default:
_{Serial.print(key);}
_{digitalWrite(ledorangje, HIGH);}
_{delay (1000);}
_{digitalWrite(ledorangje, LOW);}
_}
_}

_}

Grumpy_Mike · September 8, 2009, 9:04am

Your variable doorState is not being initialised. Also it is only ever set to a value of one. This is where you are going wrong.

system · September 8, 2009, 11:47am

i already tryed many other tings like this

^{case '#':}
^{

^{char key = kpd.getKey();}
^{if(key == 12345) // and many other tings}
^{

^{doorState= 1;}
^}
^}
^{// digitalWrite(ledrood, LOW);}
^{// digitalWrite(ledgroen, HIGH);}
^break;

system · September 8, 2009, 11:56am

You've declared PW twice, but you don't refer to either instance anywhere, nor do you have any kind of index mechanism to decide which key you are currently meant to be matching.

system · September 8, 2009, 11:57am

could you give me a example i'm not 100 % sure what you mean

system · September 8, 2009, 12:04pm

There is nowhere in your code where you compare a keycode against any member of the array PW.

You need to set an index to zero, see it the current keycode == PW[index].
If it is, you increment "index", if it doesn't you set a flag to say invalid code.
Don't simply give up and light the RED LED when you get the first wrong code, 'cos that's a really simple way to crack your code
The rest is left as an exercise for the reader

system · September 8, 2009, 12:10pm

take it long to write it else it would be nice if you could help me a hand with the code but thanks anyway for the replays

system · September 8, 2009, 12:23pm

what about this he count the numbers but he says 0 matchcount

^{#include <Keypad.h>}

^{int ledgroen = 3;}
^{int ledorangje = 4;}
^{int ledrood = 13;}
^{int doorState = 2;}
^{char PW[] = "12345";}
^{char CANCEL_KEY = '';}
^{const byte ROWS = 4; // Four rows}
^{const byte COLS = 3; // Three columns}
^{// Define the Keymap}
^{char keys[ROWS][COLS] = {}
^{{'1','2','3'},}
^{{'4','5','6'},}
^{{'7','8','9'},}
^{'','0','#'}
^};
^{// Connect keypad ROW0, ROW1, ROW2 and ROW3 to these Arduino pins.}
^{byte rowPins[ROWS] = { 9, 8, 7, 6 };// Connect keypad COL0, COL1 and COL2 to these Arduino pins.}
^{byte colPins[COLS] = { 12, 11, 10 };}
^{// Create the Keypad}
^{Keypad kpd = Keypad( makeKeymap(keys), rowPins, colPins, ROWS, COLS );}
^{void setup()}
^{

^{pinMode(ledgroen, OUTPUT);}
^{pinMode(ledorangje, OUTPUT);}
^{pinMode(ledrood, OUTPUT);}
^{Serial.begin(9600);}
^}

^{void loop()}
^{

^{switch (doorState) {}
^{case 1:}
^{delay (500);}
^{digitalWrite(ledrood, LOW);}
^delay(500);
^{digitalWrite(ledgroen, HIGH);}
^break;
^{case 2:}
^{digitalWrite(ledrood, HIGH);}
^break;
^}
^{// returns true when all PW keys are pressed in sequence}
^{// returns false when number of keys in pW pressed but don't exactly match the PW}
^{// CANCEL_KEY erases all previous digits input}
^{char key = kpd.getKey();}

^if(key)
^{

^{switch (key)}
^{
^{case '#':}
^{
^{Serial.print("#");}
^{int count; // how many keys we have}
^{int matchCount; // how many keys match}

^{for( count=0, matchCount=0; count < sizeof(PW)-1; count++){}
^{char key;// = kpd.get_key();}
^{if(key != '\0'){}
^{if(key == PW[count++])}
^{matchCount++;}
^{else if(key == CANCEL_KEY)}
^{count = matchCount = 0;}
^}
^}
^{// here when the same number of keys pressed as characters in the PW}
^{Serial.print(matchCount);}
^{if( matchCount == count)}
^{doorState= 1;}
^else
^{doorState= 2;}
^}

^break;
^{case '*':}
^break;
^default:
^{Serial.print(key);}
^{digitalWrite(ledorangje, HIGH);}
^{delay (1000);}
^{digitalWrite(ledorangje, LOW);}
^}
^}

^}

system · September 8, 2009, 12:30pm

You need to add maybe another 10 lines (and chop out the stuff you don't need) and you're there.

Make the last character of PW a '#'.
Declare a variable "index" and set it to zero.
In the '*' case, set index to zero.

In the default case, check to see if "key == PW [index]", if it does, increment index (but make sure it doesn't point past the end of PW).
In the '#' case, if index is pointing to a '#' character, you're there, so open the door.

[EDIT] The last attempt can't ever work - go back to your original posted code.
Please use the # icon to post code.

system · September 8, 2009, 12:34pm

I have actually made a Password library for this exact purpose.

I think it might help you clean up you code:
http://www.arduino.cc/playground/Code/Password

Example 'HelloPassword':

//http://www.arduino.cc/playground/uploads/Code/Password.zip
#include <Password.h>

Password password = Password( "1234" );

void setup(){
  Serial.begin(9600);
 
  password.append('1');   //add 1 to the guessed password
  password.append('2');   //add 2 to the guessed password
  password << '3' << '4'; //add 3 and 4 to the guessed password
  Serial.println( password.evaluate() ? "true":"false" ); //should print true, since 1234 == 1234
  
  password.reset(); //reset the guessed password to NULL
  Serial.println( password.evaluate() ? "true":"false" ); //should print false, since 1234 != NULL
  
  password.set("qwerty"); //set target password to qwerty
  Serial.println( password.is("qwerty") ? "true":"false" ); //should print true, since qwerty == qwerty
  Serial.println( password == "qwirty" ? "true":"false" ); //should print false, since qwerty != qwirty
}

void loop(){/*nothing to loop*/}

And here is the previously mentioned application:

//http://www.arduino.cc/playground/uploads/Code/Password.zip
#include <Password.h>
//http://www.arduino.cc/playground/uploads/Code/Keypad.zip
#include <Keypad.h>

Password password = Password( "1234" );

const byte rows = 4; //four rows
const byte cols = 4; //four columns
const byte rowPins[] = {2,3,4,5}; //connect to the row pinouts of the keypad
const byte colPins[] = {6,7,8,9}; //connect to the column pinouts of the keypad

Keypad keypad = Keypad(rowPins,colPins,rows,cols);

const byte ledPin = 13;

void setup(){
pinMode(ledPin, OUTPUT); // sets the digital pin as output
digitalWrite(ledPin, LOW); // sets the LED off
Serial.begin(9600);
keypad.addEventListener(keypadEvent); //add an event listener for this keypad
}

void loop(){
keypad.getKey();
}

//take care of some special events
void keypadEvent(KeypadEvent eKey){
switch (eKey){
case '*': guessPassword(); break;
case '#': password.reset(); break;
default:
password.append(eKey);
}
}

void guessPassword(){
if (password.evaluate()){
digitalWrite(ledPin,HIGH);
}else{
digitalWrite(ledPin,LOW);
}
}

system · September 8, 2009, 12:41pm

ok this is my code now.
But when i enter a number he dont change anymore so once i pressed 1 he stay showing 1 what ever i press

^{#include <Keypad.h>}

^{int ledgroen = 3;}
^{int ledorangje = 4;}
^{int ledrood = 13;}
^{int doorState = 2;}
^{int index= 0;}
^{char PW[] = "12345#";}
^{char CANCEL_KEY = '';}
^{const byte ROWS = 4; // Four rows}
^{const byte COLS = 3; // Three columns}
^{// Define the Keymap}
^{char keys[ROWS][COLS] = {}
^{{'1','2','3'},}
^{{'4','5','6'},}
^{{'7','8','9'},}
^{'','0','#'}
^};
^{// Connect keypad ROW0, ROW1, ROW2 and ROW3 to these Arduino pins.}
^{byte rowPins[ROWS] = { 9, 8, 7, 6 };// Connect keypad COL0, COL1 and COL2 to these Arduino pins.}
^{byte colPins[COLS] = { 12, 11, 10 };}
^{// Create the Keypad}
^{Keypad kpd = Keypad( makeKeymap(keys), rowPins, colPins, ROWS, COLS );}
^{void setup()}
^{

^{pinMode(ledgroen, OUTPUT);}
^{pinMode(ledorangje, OUTPUT);}
^{pinMode(ledrood, OUTPUT);}
^{Serial.begin(9600);}
^}
^{void loop()}
^{
^{char key = kpd.getKey();}

^{switch (doorState) {}
^{case 1:}
^{delay (500);}
^{digitalWrite(ledrood, LOW);}
^delay(500);
^{digitalWrite(ledgroen, HIGH);}
^break;
^{case 2:}
^{digitalWrite(ledrood, HIGH);}
^break;
^}
^{// returns true when all PW keys are pressed in sequence}
^{// returns false when number of keys in pW pressed but don't exactly match the PW}
^{// CANCEL_KEY erases all previous digits input}
^if(key)
^{

^{switch (key)}
^{
^{case '#':}
^{
^{Serial.print("#");}
^{int count; // how many keys we have}
^{int matchCount; // how many keys match}

^{for( count=0, matchCount=0; count < sizeof(PW)-1; count++){}
^{char key;// = kpd.get_key();}
^{if(key != '\0'){}
^{if(key == PW[count++])}
^{matchCount++;}
^{else if(key == CANCEL_KEY)}
^{count = matchCount = 0;}
^}
^}
^{// here when the same number of keys pressed as characters in the PW}
^{Serial.print(matchCount);}
^{if( matchCount == count)}
^{doorState= 1;}
^else
^{doorState= 2;}
^}

^break;
^{case '*':}
^{index= 0;}
^break;
^default:

^{char key = kpd.getKey();}

^{Serial.print(PW[index]);}
^{if(key == PW[index])}
^{
^{doorState= 1;}
^}
^{doorState= 2;}

^}
^}

^}

system · September 8, 2009, 12:42pm

nice im gonn

system · September 8, 2009, 12:42pm

nice im gonna try it out

system · September 8, 2009, 1:02pm

Great it changed the code abit and it works but only have 1 problem when 1 press 1 key he send it 2 times

Digger450 · September 8, 2009, 5:57pm

You probably need to add some debounce time. Try adding this line to setup:

keypad.setDebounceTime(250);

system · September 9, 2009, 1:57pm

when i do that he just delay the second press but he still send it 2 times

Topic		Replies	Views
Keypad Read Programming	10	2500	May 5, 2021
Password Libary with Keypad General Discussion	3	1764	May 5, 2021
Password Activated LED; code not working. Programming	5	1093	May 5, 2021
Password activated LED Programming	1	807	May 5, 2021
Difficulty getting LED to light up correctly Programming	21	456	May 12, 2024

Keypad and password

Related topics