Learning to Make libraries but code hangs

          if (x < _pumpCycle) {

delay(_pumpDelayOff);
          }



That most definitely is a delay. Many of them, since it's inside a loop. Coincidentally, a loop where x is checked to be less than _pumpCycle, so the if() is also unnecessary.