LED flash once after button push

Projects Programming
1

Hi!

I have been trying to teach myself programming and really making use of the forums on here. I'm currently working with a code that will have an LED flash for about 1 sec after a button push/signal but no luck. The only code i have worked is using delay...but I am really trying to avoid that. here's what the code looks like:
//////(with delay)

char INBYTE;
int LED = 13; // LED on pin 13

void setup() {
Serial.begin(9600);
pinMode(LED, OUTPUT);
}

void loop() {
Serial.println("Press 1 to turn Arduino pin 13 LED ON or 0 to turn it OFF:");
while (!Serial.available()); // stay here so long as COM port is empty
INBYTE = Serial.read(); // read next available byte

if( INBYTE == '1' ) {digitalWrite(LED, HIGH); // if it's a 1 (one) turn LED on
}
delay(500);
{

digitalWrite(LED, LOW);
}
}

/////////// Here's the other code i would love to get working(without delay)

char INBYTE;
int ledPin = 13;

void setup()
{
Serial.begin(9600);
pinMode(ledPin, OUTPUT);

}

void loop() {
Serial.println("Press 1 to turn Arduino pin 13 LED ON for 1 sec");
while (!Serial.available());
INBYTE = Serial.read();

{
unsigned long lastTimeInput = 0;
if( INBYTE == '1' )
lastTimeInput = millis();
digitalWrite(ledPin, HIGH);

if (millis() - lastTimeInput >= 1000UL)
digitalWrite(ledPin, LOW);
}

}

Can anyone help me with this please. Thanks!!

2

You need to pay attention to where you put your {} braces.

const byte ledPin = 13;

void setup()
{
  Serial.begin(9600);
  pinMode(ledPin, OUTPUT);
  Serial.println(F("Press 1 to turn Arduino pin 13 LED ON for 1 sec"));
}

void loop() 
{
  static unsigned long lastTimeInput;
  if (Serial.available())    
  {
    char INBYTE = Serial.read();   

    if( INBYTE == '1' ) 
    {
      lastTimeInput = millis();
      digitalWrite(ledPin, HIGH);
    }
}  

  if (millis() - lastTimeInput >= 1000UL)
  {
    digitalWrite(ledPin, LOW);
  }
}
3

You should pay attention to conventions, too. All upper case name are for constants. Constants do not appear on the left of an equal sign.

For the record, LEDs attached to Arduino pins do not flash. The pins are turned on and off. Using proper terminology to describe your issue will go a long way towards getting answers that you can use.

4

Thanks AWOL!

And yes, I should pay attention to where I place my brackets and convention. It's my 2nd month doing this. Any suggestions on how i can be better at coding?

5

One of the simplest tips I have is, if you start to write a control structure ("if", "for", "while") or a function definition, always write the opening and closing braces for that structure at the correct indentation level.

6

AWOL:
One of the simplest tips I have is, if you start to write a control structure ("if", "for", "while") or a function definition, always write the opening and closing braces for that structure at the correct indentation level.

I'll second that.

7

Personally, I think you're making this wayyyyy to complecated. Here's what you should do:

int serialRead;

void setup()
{
  pinMode(13, OUTPUT);
  Serial.begin(9600);
}

void loop()
{
  Serial.println(Press 1 and click "send" to turn the LED on for 1 second);
  serialRead = Serial.read();
  if(serialRead == 1)
  {
    digitalWrite(13, HIGH);
    delay(1000);
    digitalWrite(13, LOW);
    serialRead = 0;
  }
  if(serialRead == 0)
  {
    digitalWrite(13, LOW
  }
}
8 
if(serialRead == 1)

Personally, I think you're making things waaaayy too non-functioning :wink:

9

Here's what you should do

You tested that, right?

You at least compiled that, didn't you?