Making the standard UDP Net Time Client compile and work

I am trying t get the standard UDP Net TIme Client (from the IDE library) to compile and work.

However I keep geting the following errors;

(1) Compiler error

In file included from D:\AppDev\Arduino\hardware\arduino\avr\cores\arduino/Udp.h:39:0,

from D:\DatArduino\Sketches\libraries\Ethernet\src/EthernetUdp.h:40,

from D:\DatArduino\Sketches\libraries\Ethernet\src/Dns.h:8,

from D:\DatArduino\Sketches\UDP Experiments\UdpNetTimeClient\UdpNetTimeClient.ino:21:

D:\AppDev\Arduino\hardware\arduino\avr\cores\arduino/IPAddress.h: In function 'void loop()':

D:\AppDev\Arduino\hardware\arduino\avr\cores\arduino/IPAddress.h:54:5: note: candidate is: IPAddress::operator uint32_t() const

operator uint32_t() const { return _address.dword; };

^

D:\AppDev\Arduino\hardware\arduino\avr\cores\arduino/IPAddress.h:54:5: note: no known conversion from 'uint32_t {aka long unsigned int}' to 'char*'

(2) Runtime error

Udp Begin = 0 // Note : See line 63 of the code //

Here is the code listing

/*

Udp NTP Client

Get the time from a Network Time Protocol (NTP) time server
Demonstrates use of UDP sendPacket and ReceivePacket
For more on NTP time servers and the messages needed to communicate with them,
see Network Time Protocol - Wikipedia

created 4 Sep 2010
by Michael Margolis
modified 9 Apr 2012
by Tom Igoe
modified 02 Sept 2015
by Arturo Guadalupi

This code is in the public domain.

*/
//#include <Dhcp.h>
#include <Dns.h>
#include <Ethernet.h>
#include <EthernetClient.h>
#include <EthernetServer.h>
#include <EthernetUdp.h>

#include <SPI.h>

// Enter a MAC address for your controller below.
// Newer Ethernet shields have a MAC address printed on a sticker on the shield.

byte mac[] = {0xDE, 0xAD, 0xBE, 0xEF, 0xFE, 0xED};
//IPAddress localIP(192, 168, 100, 101);
// IPAddress localIP(192, 168, 100, 50);

IPAddress myIP( 192, 168, 100, 100 ); // IP Address of Ethernet Shield.
IPAddress dnsServer( 203, 134, 64, 66 );
IPAddress gateway( 192, 168, 10, 251 );
IPAddress subnet( 255, 255, 255, 0 );

IPAddress timeServerIP( 129,6,15,28 );

unsigned int localPort = 8888; // local port to listen for UDP packets

//byte timeServerIP[] = { 129,6,15,28};
//IPAddress timeServerIP; // NTP server time.nist.gov
const char *ntpServerName = "time.nist.gov";

const int NTP_PACKET_SIZE = 48; // NTP time stamp is in the first 48 bytes of the message
byte packetBuffer[ NTP_PACKET_SIZE]; //buffer to hold incoming and outgoing packets

// A UDP instance to let us send and receive packets over UDP
EthernetUDP Udp;

void setup()
{
Ethernet.begin(mac, myIP, dnsServer, gateway, subnet); // Open serial communications and wait for port to open.
Udp.begin(localPort);

Serial.begin(9600);
Serial.println("Set-up Commencing");

Serial.print("Udp Begin = ");
Serial.println(Udp.begin(mac) );

Serial.print("MAC Address = ");
for (int i =0; i < 6; i++)
{
Serial.print( mac*);*

  • Serial.print(" ");*
  • }*
  • Serial.println("");*
  • Serial.print("Local Port Address = ");*
  • Serial.println(myIP );*
  • Serial.print("Time Server = ");*
  • Serial.print(ntpServerName);*
  • Serial.print(" Time Server IP = ");*
  • Serial.println(timeServerIP);*
  • while (!Serial)*
  • {*
  • ; // wait for serial port to connect. Needed for native USB port only*
  • }*
  • if (Serial)*
  • {*
  • Serial.println("Serial port connection succeeded");*
  • }*
  • else*
  • {*
  • Serial.println("Serial port connection failed");*
  • }*
  • // start Ethernet and UDP*

// Serial.println(Ethernet.begin(mac) );
// if (Ethernet.begin(mac) == 0)
// {
// Serial.println("Failed to configure Ethernet");
// for (;:wink: // no point in carrying on, so do nothing forevermore:
// ;
// }
// EthernetUdp.begin(localPort);

  • Serial.println("Setup completed successfully");*
    } // End setup
    void loop()
    {
    // sendNTPpacket(ntpServerName); // Send an NTP packet to a time server.
  • sendNTPpacket(timeServerIP); // Send an NTP packet to a time server.*
  • Serial.println("At send NTP Packet");*
  • // wait to see if a reply is available*
  • delay(1000);*
  • if (Udp.parsePacket())*
  • {*
  • Serial.println("Inside UDP Parse Packet");*
  • // We've received a packet, read the data from it*
  • Udp.read(packetBuffer, NTP_PACKET_SIZE); // read the packet into the buffer*
  • // the timestamp starts at byte 40 of the received packet and is four bytes,*
  • // or two words, long. First, extract the two words:*
  • unsigned long highWord = word(packetBuffer[40], packetBuffer[41]);*
  • unsigned long lowWord = word(packetBuffer[42], packetBuffer[43]);*
  • // combine the four bytes (two words) into a long integer*
  • // this is NTP time (seconds since Jan 1 1900):*
  • unsigned long secsSince1900 = highWord << 16 | lowWord;*
  • Serial.print("Seconds since Jan 1 1900 = ");*
  • Serial.println(secsSince1900);*
  • // now convert NTP time into everyday time:*
  • Serial.print("Unix time = ");*
  • // Unix time starts on Jan 1 1970. In seconds, that's 2208988800:*
  • const unsigned long seventyYears = 2208988800UL;*
  • // subtract seventy years:*
  • unsigned long epoch = secsSince1900 - seventyYears;*
  • Serial.println(epoch); // print Unix time.*
  • // print the hour, minute and second:*
  • Serial.print("The UTC time is "); // UTC is the time at Greenwich Meridian (GMT)*
  • Serial.print((epoch % 86400L) / 3600); // print the hour (86400 equals secs per day)*
  • Serial.print(':');*
  • if (((epoch % 3600) / 60) < 10)*
  • {*
  • // In the first 10 minutes of each hour, we'll want a leading '0'*
  • Serial.print('0');*
  • }*
  • Serial.print((epoch % 3600) / 60); // print the minute (3600 equals secs per minute)*
  • Serial.print(':');*
  • if ((epoch % 60) < 10)*
  • {*
  • // In the first 10 seconds of each minute, we'll want a leading '0'*
  • Serial.print('0');*
  • }*
  • Serial.println(epoch % 60); // print the second*
  • }*
  • // wait ten seconds before asking for the time again*
  • delay(10000);*
  • Ethernet.maintain();*
    } // End loop
    void sendNTPpacket(char* address) // send an NTP request to the time server at the given address.
    {
  • // set all bytes in the buffer to 0*
  • memset(packetBuffer, 0, NTP_PACKET_SIZE);*
  • // Initialize values needed to form NTP request*
  • // (see URL above for details on the packets)*
  • packetBuffer[0] = 0b11100011; // LI, Version, Mode*
  • packetBuffer[1] = 0; // Stratum, or type of clock*
  • packetBuffer[2] = 6; // Polling Interval*
  • packetBuffer[3] = 0xEC; // Peer Clock Precision*
  • // 8 bytes of zero for Root Delay & Root Dispersion*
  • packetBuffer[12] = 49;*
  • packetBuffer[13] = 0x4E;*
  • packetBuffer[14] = 49;*
  • packetBuffer[15] = 52;*
  • // all NTP fields have been given values, now*
  • // you can send a packet requesting a timestamp:*
  • Udp.beginPacket(address, 123); //NTP requests are to port 123*
  • Udp.write(packetBuffer, NTP_PACKET_SIZE);*
  • Udp.endPacket();*
    } // End sendNTPpacket
    Can someone please assist me by telling me wht the issue is?

Can someone please assist me by telling me wht the issue is?

You have more than one issue. First, you don't know what you are talking about. You can't have a run-time error involving code that won't even compile. If you are talking about different code, where is the code that won't compile?

Second, you can't read. There are stickies at the top of the forum that describe HOW to post code. The way you did it is WRONG. Your code does NOT look like that. Of that I am 100% certain.

Third, you seem to have spelling issues. "wht"? What is that?

Paul,

Thank you for your reply.
To address your points one at a time;

  1. "... dont know what your are talking about". Usually I would agree with you, namely a compiler error terminates the program. Howver in this case the program kept running - strange as that might seem !!! I copied the compiler error and run time from the Uno IDE via copy and past - so there proof is right there before you.

  2. Yes, I posted the code incorrectly - thank you for bring that to my attention. I posted this question at 02:30 i the morning, - I should have left it until the next day and been more thorough - lesson learnt!!

  3. Spelling issue - I can't believe that you couldn't interrupret the correct word, surely its obvious (by the context of the sentence) "wat" was supposed to be "what". I also do not believee that you have NEVER made a simple spelling error - so be careful before throwing stones !!!

While you have raised some valid points (which I will address) - I do not believe that you have maintained the spirit and cordial tone usually afforded others in this forum. To suggest that I "... don't know what I am taling about", - is just plain rude !!!. Yoiu have no knowledge of my background and expereince.

Thanking you again for your comments (i.e. the constructive ones).

Howver in this case the program kept running - strange as that might seem !!!

Rubbish. The compiler converts cpp files to object files. The linker converts the object files to a hex file. The uploader uploads the hex file to the Arduino, where it begins running. If the compiler fails to compile any file, the linker is NOT called. If the linker is not called avrdude is NOT called. What runs on the Arduino is NOT the code that failed to compile.

I copied the compiler error and run time from the Uno IDE via copy and past - so there proof is right there before you.

You posted proof that the linker was not called and that avrdude did not upload code to the Arduino, and you think that constitutes proof that the program that failed to compile was running on some other computer? I disagree vehemently.

I also do not believee that you have NEVER made a simple spelling error

Doesn't your browser have a spell checker?

So, are you going to post the code correctly, so we can help resolve the issues?