matrix rgb led strip

Hi i have a problem with code, when i upload a code i get a comunicate :

In file included from C:\Users\kaspe\Desktop\FRF9LJ5IVO3SD4B (1)\lol\lol.ino:15:0:

C:\Users\kaspe\Documents\Arduino\libraries\FastLED/FastLED.h:12:2: warning: #warning FastLED version 3.001.000 (Not really a warning, just telling you here.) [-Wcpp]

 #warning FastLED version 3.001.000  (Not really a warning, just telling you here.)

  ^

C:\Users\kaspe\Desktop\FRF9LJ5IVO3SD4B (1)\lol\lol.ino: In function 'loop':

C:\Users\kaspe\Desktop\FRF9LJ5IVO3SD4B (1)\lol\lol.ino:84:58: warning: iteration 10 invokes undefined behavior [-Waggressive-loop-optimizations]

         for(unsigned char x = grenzen[i]; x < grenzen[i+1];x++){

                                                          ^

C:\Users\kaspe\Desktop\FRF9LJ5IVO3SD4B (1)\lol\lol.ino:82:5: note: containing loop

     for(unsigned char i = 0; i < 11; i++){

     ^

Project link : https://www.instructables.com/id/Arduino-Spectrum-Analyzer-on-a-10x10-RGB-LED-Matri/

code:

/*
Written by FischiMc and SupaStefe

This sketch uses a 10x10 RGB LED-Matrix as a spectrum analyzer
It uses a FTT Library to analyze an audio signal connected to the
pin A7 of an Arduino nano. Everytime a column gets higher than
10 pixels the color of each column changes.
*/

#define LOG_OUT 0         //set output of FFT library to linear not logarithmical
#define LIN_OUT 1
#define FFT_N 256         //set to 256 point fft

#include <FFT.h>          //include the FFT library
#include <FastLED.h>      //include the FastLED Library
#include <math.h>         //include library for mathematic funcions
#define DATA_PIN 3        //DATA PIN WHERE YOUR LEDS ARE CONNECTED
#define NUM_LEDS 100      //amount of LEDs in your matrix
CRGB leds[NUM_LEDS];
float faktoren[10] = {1, 1.1, 1.15, 1.25, 1.45, 1.55, 1.75, 1.8, 2, 3};       //factors to increase the height of each column
unsigned char hs[10] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0};                        //height of each column
float hue = 0;                                                                //hue value of the colors

void setBalken(unsigned char column, unsigned char height){                   //calculation of the height of each column
    unsigned char h = (unsigned char)map(height, 0, 255, 0, 10);
    h = (unsigned char)(h * faktoren[column]);
    if (h < hs[column]){
        hs[column]--;
    }
    else if (h > hs[column]){
        hs[column] = h;
    }
   if (height > 250){
      hue+=2;                     //CHANGE THIS VALUE IF YOU WANT THE DIFFERENCE BETWEEN THE COLORS TO BE BIGGER
      if(hue > 25) hue=0;
   }

    for(unsigned char y = 0; y < 10; y++){                          //set colors of pixels according to column and hue
       if(hs[column] > y){ 
        leds[y+(column*10)] = CHSV((hue*10)+(column*10), 255, 200);
       } else {
        leds[y+(column*10)] = CRGB::Black;
       }
    }
}

unsigned char grenzen[11] = {0,3,5,7,9,11,13,16,24,32,69};          //borders of the frequency areas

void setup() {
  FastLED.addLeds<WS2812B, DATA_PIN, GRB> (leds, NUM_LEDS);
  Serial.begin(115200);                                             //use the serial port
  TIMSK0 = 0;                                                       //turn off timer0 for lower jitter
  ADCSRA = 0xe5;                                                    //set the adc to free running mode
  ADMUX = 0b01000111;                                               //use pin A7
  DIDR0 = 0x01;                                                     //turn off the digital input for 
  analogReference(EXTERNAL);                                        //set aref to external
}

void loop() {
  while(1) {                                                        //reduces jitter
    cli();                                                          //UDRE interrupt slows this way down on arduino1.0
    for (int i = 0 ; i < 512 ; i += 2) {                            //save 256 samples
      while(!(ADCSRA & 0x10));                                      //wait for adc to be ready
      ADCSRA = 0xf5;                                                //restart adc
      byte m = ADCL;                                                //fetch adc data
      byte j = ADCH;
      int k = (j << 8) | m;                                         //form into an int
      k -= 0x0200;                                                  //form into a signed int
      k <<= 6;                                                      //form into a 16b signed int
      fft_input[i] = k;                                             //put real data into even bins
    }

    fft_window();                                                   // window the data for better frequency response
    fft_reorder();                                                  // reorder the data before doing the fft
    fft_run();                                                      // process the data in the fft
    fft_mag_lin();                                                  // take the output of the fft
    sei();

    fft_lin_out[0] = 0;
    fft_lin_out[1] = 0;

    for(unsigned char i = 0; i < 11; i++){
      unsigned char maxW = 0;
        for(unsigned char x = grenzen[i]; x < grenzen[i+1];x++){
 
           if((unsigned char)fft_lin_out[x] > maxW){
            maxW = (unsigned char)fft_lin_out[x];
           }
        }

      setBalken(i, maxW);
      Serial.print(maxW);
      Serial.print(" ");
    }
    Serial.println("");
    TIMSK0 = 1;
    FastLED.show();
    TIMSK0 = 0;
  }
}
unsigned char grenzen[11] = {0,3,5,7,9,11,13,16,24,32,69};          //borders of the frequency areas

In your outer “i” loop, “i” can reach 10. You used [i+1] in your inner loop, thus addressing grenzen[11]. The last valid index to grenzen is 10, due to zero based indexing. You are addressing memory outside of the array:

    for(unsigned char i = 0; i < 11; i++){
      unsigned char maxW = 0;
        for(unsigned char x = grenzen[i]; x < grenzen[i+1];x++){

now:

In file included from C:\Users\kaspe\Desktop\kodmuzyka\kodmuzyka.ino:15:0:

C:\Users\kaspe\Documents\Arduino\libraries\FastLED/FastLED.h:12:2: warning: #warning FastLED version 3.001.000 (Not really a warning, just telling you here.) [-Wcpp]

 #warning FastLED version 3.001.000  (Not really a warning, just telling you here.)

  ^

C:\Users\kaspe\Desktop\kodmuzyka\kodmuzyka.ino: In function 'void setBalken(unsigned char, unsigned char)':

kodmuzyka:48: error: 'grenzen' was not declared in this scope

         for(unsigned char x = grenzen[i]; x < grenzen[i+1];x++)

                               ^

kodmuzyka:49: error: expected primary-expression before '}' token

     }

     ^

C:\Users\kaspe\Desktop\kodmuzyka\kodmuzyka.ino: In function 'void loop()':

kodmuzyka:87: error: 'grenzen' was not declared in this scope

         for(unsigned char x = grenzen[i]; x < grenzen[i+1];x++){

                               ^

exit status 1
'grenzen' was not declared in this scope

Bez_tytu_u

Please post your altered code, otherwise we have no idea what changes you made that cause the error.

roryyy i forgot

/*
Written by FischiMc and SupaStefe

This sketch uses a 10x10 RGB LED-Matrix as a spectrum analyzer
It uses a FTT Library to analyze an audio signal connected to the
pin A7 of an Arduino nano. Everytime a column gets higher than
10 pixels the color of each column changes.
*/

#define LOG_OUT 0         //set output of FFT library to linear not logarithmical
#define LIN_OUT 1
#define FFT_N 256         //set to 256 point fft

#include <FFT.h>          //include the FFT library
#include <FastLED.h>      //include the FastLED Library
#include <math.h>         //include library for mathematic funcions
#define DATA_PIN 3        //DATA PIN WHERE YOUR LEDS ARE CONNECTED
#define NUM_LEDS 100      //amount of LEDs in your matrix
CRGB leds[NUM_LEDS];
float faktoren[10] = {1, 1.1, 1.15, 1.25, 1.45, 1.55, 1.75, 1.8, 2, 3};       //factors to increase the height of each column
unsigned char hs[10] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0};                        //height of each column
float hue = 0;                                                                //hue value of the colors

void setBalken(unsigned char column, unsigned char height){                   //calculation of the height of each column
    unsigned char h = (unsigned char)map(height, 0, 255, 0, 10);
    h = (unsigned char)(h * faktoren[column]);
    if (h < hs[column]){
        hs[column]--;
    }
    else if (h > hs[column]){
        hs[column] = h;
    }
   if (height > 250){
      hue+=2;                     //CHANGE THIS VALUE IF YOU WANT THE DIFFERENCE BETWEEN THE COLORS TO BE BIGGER
      if(hue > 25) hue=0;
   }

    for(unsigned char y = 0; y < 10; y++){                          //set colors of pixels according to column and hue
       if(hs[column] > y){ 
        leds[y+(column*10)] = CHSV((hue*10)+(column*10), 255, 200);
       } else {
        leds[y+(column*10)] = CRGB::Black;
       }
    }

    for(unsigned char i = 0; i < 11; i++){
      unsigned char maxW = 0;
        for(unsigned char x = grenzen[i]; x < grenzen[i+1];x++)
    }
}

void setup() {
  FastLED.addLeds<WS2812B, DATA_PIN, GRB> (leds, NUM_LEDS);
  Serial.begin(115200);                                             //use the serial port
  TIMSK0 = 0;                                                       //turn off timer0 for lower jitter
  ADCSRA = 0xe5;                                                    //set the adc to free running mode
  ADMUX = 0b01000111;                                               //use pin A7
  DIDR0 = 0x01;                                                     //turn off the digital input for 
  analogReference(EXTERNAL);                                        //set aref to external
}

void loop() {
  while(1) {                                                        //reduces jitter
    cli();                                                          //UDRE interrupt slows this way down on arduino1.0
    for (int i = 0 ; i < 512 ; i += 2) {                            //save 256 samples
      while(!(ADCSRA & 0x10));                                      //wait for adc to be ready
      ADCSRA = 0xf5;                                                //restart adc
      byte m = ADCL;                                                //fetch adc data
      byte j = ADCH;
      int k = (j << 8) | m;                                         //form into an int
      k -= 0x0200;                                                  //form into a signed int
      k <<= 6;                                                      //form into a 16b signed int
      fft_input[i] = k;                                             //put real data into even bins
    }

    fft_window();                                                   // window the data for better frequency response
    fft_reorder();                                                  // reorder the data before doing the fft
    fft_run();                                                      // process the data in the fft
    fft_mag_lin();                                                  // take the output of the fft
    sei();

    fft_lin_out[0] = 0;
    fft_lin_out[1] = 0;

    for(unsigned char i = 0; i < 11; i++){
      unsigned char maxW = 0;
        for(unsigned char x = grenzen[i]; x < grenzen[i+1];x++){
           if((unsigned char)fft_lin_out[x] > maxW){
            maxW = (unsigned char)fft_lin_out[x];
           }
        }

      setBalken(i, maxW);
      Serial.print(maxW);
      Serial.print(" ");
    }
    Serial.println("");
    TIMSK0 = 1;
    FastLED.show();
    TIMSK0 = 0;
  }
}

It's telling you what is wrong...

'grenzen' was not declared

You deleted the declaration of grenzen.

Oki, could you help me, how should I fix it? I'm sorry, but I do not know much about it

KingArty:
Oki, could you help me, how should I fix it? I'm sorry, but I do not know much about it

For the second problem, just undo what you did. For the first problem, contact the authors for a solution. I don't play with undocumented, uncommented code. Not even my own. :slight_smile: