Millis() question? ads1115 trials

nzmxp · March 16, 2023, 7:11am

ads1115 voltage reading is working.
I make its output like a voltage comparator but millis() compiles correctly. it doesn't actually work on the board.

validTime - h2 > 100

and this is currentTime - out > 500
i want it to work

unsigned long currentTime ;  // millis tanımlama :
unsigned long  h2,out = 0;   // millis tanımlama:


#include "ADS1X15.h"
ADS1115 ADS(0x48);  
 int rdtx=0;
 int rdtmax=900;
const byte trp=2; // pnp tr out: 
const byte trn=3; //  npn tr cıkış :
const byte kazancled=4; //  led flosör output:
const byte npoutled=5; //   led pnp / npn cıkısı: 
const byte pwrled=6; //   led gırıs  :
const byte hdt = 13; // flas gırış:
const byte outcompv=8; // ao-a1 karsılastırma cıkış :
const byte inptpp = 9; // 8 out koprusu 1-0 gırış:
const byte setswic=10; //   pwm  cıkısı: 
const byte incompz = 12; // buton 0 pot gırış:
const byte outcompb=11; // out cıkış :




void setup(void) {

pinMode  ( kazancled , OUTPUT ); //  s  cıkıs :
pinMode (rdtx , INPUT); 
pinMode  ( trp, OUTPUT );  // s :
pinMode  ( trn , OUTPUT ); //  s  cıkıs :
pinMode  (npoutled,OUTPUT);  //   sinyal cıkış NPN ve PNP out  :
pinMode  (pwrled,OUTPUT);  //  power ve rdt flaşör   :
pinMode(hdt, OUTPUT);   //  modlar :
pinMode(incompz, INPUT);   //  0 gırıs pot :
pinMode  ( outcompb , OUTPUT ); //  s :
pinMode  ( outcompv , OUTPUT ); //  s :
pinMode( inptpp, INPUT);   //  modlar :
pinMode  ( setswic, OUTPUT );  // s :
digitalWrite(setswic,LOW);




  // ADS1115
  ADS.begin();        
  ADS.setGain(0);      
  ADS.setMode(1);    
  ADS.setDataRate(6);  
  ADS.readADC(0);
  ADS.readADC(1);    
}

void loop(void) {

   
  unsigned long currentTime = millis();
  int16_t tension_A0 = ADS.readADC(0);         
  int16_t tension_A1 = ADS.readADC(1); 
          
 byte val0 = map(tension_A0, 0, 32767, 0, 255);
 analogWrite(setswic, val0);     
  
 { int  rdtx = analogRead(A6); 
    if (rdtx <= rdtmax )
    {analogWrite(pwrled, 200);}
     else
     {analogWrite(pwrled, 0);}
     

{  int incompz = digitalRead(12);
    if (digitalRead(12) == 0)
     {digitalWrite(outcompb, 1);}
    else 
    {digitalWrite(outcompb, 0);} 

{    int incompz = digitalRead(12);
    if  (digitalRead(12) == 1 && currentTime  - h2 > 100 )   
     {digitalWrite(hdt, 1); }
      else
     {digitalWrite(hdt, 0);   h2=currentTime ;  }  // flaş out on to mıllıs of :

    {
       int16_t tension_A0 = ADS.readADC(0);       
 int16_t tension_A1 = ADS.readADC(1); 
  ADS.setGain(0);      
  ADS.setMode(1);    
  ADS.setDataRate(6);

       if (tension_A0 <=  tension_A1  && incompz ==0  )
   {digitalWrite (outcompv ,0); } 
      else 
      {digitalWrite (outcompv ,1);}
  
   bool inptpp = digitalRead(9);  bool incompz = digitalRead(12);
  if (inptpp  == 1 && incompz ==0 && currentTime  - out > 500 ) 
  {digitalWrite(trp, 1); digitalWrite(trn, 1);digitalWrite(npoutled, 1);   out =currentTime; }  
  else 
  {digitalWrite(trp, 0);  digitalWrite(trn, 0);  digitalWrite(npoutled, 0);  delay (1);}

 }
  }
}
} 
}

nzmxp · March 16, 2023, 7:20am

delay() is running.
millis() not working

this code is working
I try to do this with millis()

 if (inptpp  == 1 && incompz ==0 ) 
  {digitalWrite(trp, 1); digitalWrite(trn, 1);digitalWrite(npoutled, 1);   delay (500); }  
  else 
  {digitalWrite(trp, 0);  digitalWrite(trn, 0);  digitalWrite(npoutled, 0);  delay (1);}

b707 · March 16, 2023, 7:21am

Your code is a mess.
Please use CTRL -T in the IDE before posting code to the forum

b707 · March 16, 2023, 7:24am

Please explain what you try to achieve in this lines:

b707 · March 16, 2023, 7:30am

Your problem is absolutely the same as in your thread 1,5 months ago.

At the end of that thread you said you understand how to use millis...

nzmxp · March 16, 2023, 7:36am

I want a 100ms run alert.
digitalRead(12)
I hooked up a buzzer like an alert when 1 or zero.

basically yes, but I'm confused, I'm constantly uploading the codes and compiling them again.

nzmxp · March 16, 2023, 7:40am

sometimes i seem so confused A person freezes when confused, even simple things seem difficult. insomnia vs.

b707 · March 16, 2023, 7:44am

Then your code that I cited in post#4 is absolutely un logical. Look at the first part:

~~If signal on pin 12 is HIGH - then make it HIGH... WHY ??? isn't it like that anymore?~~

added - sorry, the whole message was wrong

b707 · March 16, 2023, 7:50am

I think it would be better to you start from learning a basic principles of programming - conditions, loops, program blocks. Then you can learn how to work with millis using "blink without delay" IDE example.
This project is too complex for you at this stage

nzmxp · March 16, 2023, 7:56am

Yes that is right
I'm going through a classic style compilation. You know there are different ways. I mean, I haven't fully grasped the codes yet. I'll spread the time and wait, I can't do anything else.

I understand you have some great ideas on this.
Actually, I can't say that I am very good at anything.
Developing constantly, even if we don't understand, reading will get better one day

nzmxp · March 16, 2023, 7:59am

I have to find a way to get it working. with millis()

  if (inptpp  == 1 && incompz ==0 && currentTime  - out > 500 ) 
  {digitalWrite(trp, 1); digitalWrite(trn, 1);digitalWrite(npoutled, 1);   out

b707 · March 16, 2023, 8:04am

i don't think so.
You forget to reset previous millis time after timer expire

nzmxp · March 16, 2023, 8:25am

I have done

gcjr · March 16, 2023, 10:56am

don't understand the need for the subsections delimited by the extra braces and redundant re-declarations of variables and reads.

the following is a more conventional coding with redundancies commented out

unsigned long currentTime ;  // millis tan─▒mlama :
unsigned long  h2, out = 0;   // millis tan─▒mlama:

#undef MyHW
#ifdef MyHW
# include "sim.hh"
struct ADS1115 {
    ADS1115 (int a) { }
    void begin  (void) {}
    void setGain (int a) {}
    void setMode (int a) {}
    void setDataRate (int a) {}
    int  readADC (int a) { return 0; }
};
#else
# include "ADS1X15.h"
#endif

ADS1115 ADS (0x48);
int rdtx=0;
int rdtmax=900;
const byte trp=2; // pnp tr out:
const byte trn=3; // npn tr c─▒k─▒┼ƒ :

const byte kazancled    = 4;  // led flos├╢r output:
const byte npoutled     = 5;  // led pnp / npn c─▒k─▒s─▒:
const byte pwrled       = 6;  // led g─▒r─▒s  :
const byte hdt          = 13; // flas g─▒r─▒┼ƒ:
const byte outcompv     = 8;  // ao-a1 kars─▒last─▒rma c─▒k─▒┼ƒ :
const byte inptpp       = 9;  // 8 out koprusu 1-0 g─▒r─▒┼ƒ:
const byte setswic      = 10; // pwm  c─▒k─▒s─▒:
const byte incompz      = 12; // buton 0 pot g─▒r─▒┼ƒ:
const byte outcompb     = 11; // out c─▒k─▒┼ƒ :

void setup (void) {

    pinMode (kazancled, OUTPUT ); // s  c─▒k─▒s :
    pinMode (rdtx, INPUT);
    pinMode (trp, OUTPUT );  // s :
    pinMode (trn, OUTPUT ); // s  c─▒k─▒s :
    pinMode (npoutled, OUTPUT);  // sinyal c─▒k─▒┼ƒ NPN ve PNP out  :
    pinMode (pwrled, OUTPUT);  // power ve rdt fla┼ƒ├╢r   :
    pinMode (hdt, OUTPUT);   // modlar :
    pinMode (incompz, INPUT);   // 0 g─▒r─▒s pot :
    pinMode (outcompb, OUTPUT ); // s :
    pinMode (outcompv, OUTPUT ); // s :
    pinMode (inptpp, INPUT);   // modlar :
    pinMode (setswic, OUTPUT );  // s :
    digitalWrite (setswic, LOW);

    // ADS1115
    ADS.begin ();
    ADS.setGain (0);
    ADS.setMode (1);
    ADS.setDataRate (6);
    ADS.readADC (0);
    ADS.readADC (1);
}


void loop (void) {

    unsigned long currentTime = millis ();
    int16_t tension_A0 = ADS.readADC (0);
    int16_t tension_A1 = ADS.readADC (1);

    byte val0 = map (tension_A0, 0, 32767, 0, 255);
    analogWrite (setswic, val0);

    int  rdtx = analogRead (A6);
    if (rdtx <= rdtmax ) {
        analogWrite (pwrled, 200);
    }
    else {
        analogWrite (pwrled, 0);
    }

    int incompz = digitalRead (12);
    if (digitalRead (12) == 0) {
        digitalWrite (outcompb, 1);
    }
    else {
        digitalWrite (outcompb, 0);
    }

 // int incompz = digitalRead (12);
    if (digitalRead (12) == 1 && currentTime  - h2 > 100 ) {
        digitalWrite (hdt, 1);
    }
    else {
        digitalWrite (hdt, 0);
        h2=currentTime ;
    }  // fla┼ƒ out on to m─▒ll─▒s of :

 // int16_t tension_A0 = ADS.readADC (0);
 // int16_t tension_A1 = ADS.readADC (1);
    ADS.setGain (0);
    ADS.setMode (1);
    ADS.setDataRate (6);

    if (tension_A0 <=  tension_A1  && incompz ==0  ) {
        digitalWrite (outcompv, 0);
    }
    else {
        digitalWrite (outcompv, 1);
    }

    bool inptpp = digitalRead (9);
 // bool incompz = digitalRead (12);
    if (inptpp  == 1 && incompz ==0 && currentTime  - out > 500 ) {
        digitalWrite (trp, 1);
        digitalWrite (trn, 1);
        digitalWrite (npoutled, 1);
        out =currentTime;
    }
    else {
        digitalWrite (trp, 0);
        digitalWrite (trn, 0);
        digitalWrite (npoutled, 0);
        delay (1);
    }
}

the following doesn't seem right, "h2" is constantly reset when "h2" <= 100 meaning that the "h2" > 100 case can never be true

    if (digitalRead (12) == 1 && currentTime  - h2 > 100 ) {
        digitalWrite (hdt, 1);
    }
    else {
        digitalWrite (hdt, 0);
        h2=currentTime ;
    }

some more complete explanation of the code may help

nzmxp · March 16, 2023, 11:24am

(digital Reading (12)
It is the entry key. located in the one and zero positions. in one position it will light the hdt output 100ms and go out
Follows the switch every time it is turned on and off

nzmxp · March 16, 2023, 2:38pm

right, this (12)read code didn't work as I wanted, it's constantly on, or vice versa, it stays off. I will share the drawing tomorrow and I wanted to make it will be understood. Thanks

gcjr · March 16, 2023, 5:08pm

what is pin 12 connected to?

nzmxp · March 17, 2023, 10:15am

I am not hiding anything, I will share what I have done openly.

In addition, the eeprom I added provides gain control. but my codes are in an old and messy way again (gcjr) you're right, I added a lot of unnecessary parentheses, your arrangement is better, I'll upload a picture, I couldn't upload it somehow. But I have to succeed

#include <EEPROM.h>  // kayıt:
unsigned int kayit_adress,kaydelicek_veri;  // kayıt:
unsigned int okunacak_adress,okunacak_veri;  // kayıt :
unsigned long currentTime ;  // millis tanımlama :
unsigned long  k1,k2,k3,k4,k5,k6,k7,k8,h2,out = 0;   // millis tanımlama:
unsigned int sayac ;  //  sayıcı buton :
const byte ButtonPin = 7;  // buton gırıs :

#include "ADS1X15.h"
ADS1115 ADS(0x48);  
 int rdtx=0;
 int rdtmax=900;
const byte trp=2; // pnp tr out: 
const byte trn=3; //  npn tr cıkış :
const byte kazancled=4; //  led flosör output:
const byte npoutled=5; //   led pnp / npn cıkısı: 
const byte pwrled=6; //   led gırıs  :
const byte hdt = 13; // hdt gırış:
const byte outcompv=8; // ao-a1 karsılastırma cıkış :
const byte inptpp = 9; // 8 out koprusu 1-0 gırış:
const byte setswic=10; //   pwm  cıkısı: 
const byte incompz = 12; // buton 0 pot gırış:
const byte outcompb=11; // lazer cıkış :
const byte a1=A0;  // kazanc :
const byte a2 =A1;  // kazanc :
const byte a3=A2;    // kazanc : 
const byte a4 =A3;  //  kazanc :



void setup(void) {
pinMode   ( a1, OUTPUT );  // GAİN :
pinMode   ( a2, OUTPUT );  // GAİN :
pinMode   ( a3, OUTPUT );  // GAİN :
pinMode   ( a4, OUTPUT );  // GAİN :
pinMode  ( kazancled , OUTPUT ); //  s  cıkıs :
pinMode (rdtx , INPUT); 
pinMode  ( trp, OUTPUT );  // s :
pinMode  ( trn , OUTPUT ); //  s  cıkıs :
pinMode  (npoutled,OUTPUT);  //   sinyal cıkış NPN ve PNP out  :
pinMode  (pwrled,OUTPUT);  //  power ve rdt flaşör   :
pinMode(hdt, OUTPUT);   //  modlar :
pinMode(incompz, INPUT);   //  0 gırıs pot :
pinMode  ( outcompb , OUTPUT ); //  s :
pinMode  ( outcompv , OUTPUT ); //  s :
pinMode( inptpp, INPUT);   //  modlar :
pinMode  ( setswic, OUTPUT );  // s :
digitalWrite(setswic,LOW);




  // ADS1115
  ADS.begin();        
  ADS.setGain(0);      
  ADS.setMode(1);    
  ADS.setDataRate(6);  
  ADS.readADC(0);
  ADS.readADC(1);    
}

void loop(void) {



  unsigned long currentTime = millis();
  static boolean buttonWasPressed = false;      // son düğme durumunu hatırlamak için değişken:
  boolean buttonIsPressed = digitalRead(ButtonPin) == HIGH;
  static unsigned long lastStateChangeTime = 0;
  if (buttonIsPressed != buttonWasPressed && currentTime - lastStateChangeTime > 25)
  {   
    buttonWasPressed = buttonIsPressed;  
    lastStateChangeTime = currentTime;
    if (buttonIsPressed)   
            
          sayac++;
      delay (2);
      if (sayac>7)
  {
    sayac= 0;   // set modları kayıt:
  }
    
      kayit_adress = 10;
      kaydelicek_veri= sayac ;
        EEPROM.write  (kayit_adress,kaydelicek_veri);   
        delay(10);
  }
          okunacak_adress =10 ;
     okunacak_veri= EEPROM.read (okunacak_adress);   sayac =  okunacak_veri ; 
     delay (10);
    
  if (okunacak_veri==0) {
        if  ( (okunacak_veri==0)&& (currentTime  - k1 >  200) )
       { digitalWrite(4, !digitalRead(4)); k1 =currentTime  ;}  // flasör led gain sellector time :
    digitalWrite(a1,HIGH); // 1000//:  gain  // 128 //
    digitalWrite(a2,LOW);
    digitalWrite(a3,LOW);         // 0 //:
    digitalWrite(a4,LOW);
      } 
   else if (okunacak_veri==1) {
      if  ( (okunacak_veri==1)&& (currentTime  - k2 >  500) )
       { digitalWrite(4, !digitalRead(4)); k2 = currentTime  ;}   // flasör led gain sellector time :
    digitalWrite(a1,LOW);  // 0100 //: gain  // 256 //
    digitalWrite(a2,HIGH);
    digitalWrite(a3,LOW);           // 1 // :
    digitalWrite(a4,LOW);
       } 
   else if (okunacak_veri==2) {
        if  ( (okunacak_veri==2)&& (currentTime - k3 >  700) )
       { digitalWrite(4, !digitalRead(4)); k3 = currentTime  ;}  // flasör led gain sellector time :
    digitalWrite(a1,HIGH);   // 1100//:  gain 512 //
    digitalWrite(a2,HIGH);
    digitalWrite(a3,LOW);         // 2 //:
    digitalWrite(a4,LOW);            
        }   
    else if (okunacak_veri==3) {
         if  ( (okunacak_veri==3)&& (currentTime  - k4 > 950) )
       { digitalWrite(4, !digitalRead(4)); k4 =  currentTime ;}  // flasör led gain sellector time :
    digitalWrite(a1,LOW);  // 0010//:  gain 1024 //
    digitalWrite(a2,LOW);
    digitalWrite(a3,HIGH);         // 3 //:
    digitalWrite(a4,LOW);
       }  
  else if (okunacak_veri==4) {
        if  ( (okunacak_veri==4)&& (currentTime  - k5 >  1050) )
       { digitalWrite(4, !digitalRead(4)); k5 = currentTime ;}   // flasör led gain sellector time :
    digitalWrite(a1,HIGH);   // 1010 //:  gain 2048 //
    digitalWrite(a2,LOW);
    digitalWrite(a3,HIGH);       // 4 //:
    digitalWrite(a4,LOW);
      }   
  else if (okunacak_veri==5) {
     if  ( (okunacak_veri==5)&& (currentTime  - k6 >  1550) )
       { digitalWrite(4, !digitalRead(4)); k6 = currentTime ;}   // flasör led gain sellector time :
    digitalWrite(a1,LOW);   // 0110 //:  gain 2048 //
    digitalWrite(a2,HIGH);
    digitalWrite(a3,HIGH);      // 5 //:
    digitalWrite(a4,LOW);
         }   
   else if (okunacak_veri==6) {
        if  ( (okunacak_veri==6)&& (currentTime  - k7 >  2550) )
       { digitalWrite(4, !digitalRead(4)); k7 = currentTime ;}   // flasör led gain sellector time :
    digitalWrite(a1,HIGH);   // 1110 //:  gain 2048 //
    digitalWrite(a2,HIGH);
    digitalWrite(a3,HIGH);        // 6 //:
    digitalWrite(a4,LOW); 
       } 
         else  
       {
   if (  (currentTime  - k8 >  3150) )
       { digitalWrite(4, !digitalRead(4)); k8 = currentTime ;}   // flasör led gain sellector time :
    digitalWrite(a1,LOW);     // 0000 // gain 12 //
    digitalWrite(a2,LOW);
    digitalWrite(a3,LOW);        // son 7//:
    digitalWrite(a4,LOW);

    }   
{  EEPROM.update( kayit_adress , kaydelicek_veri );}

 
{  int16_t tension_A0 = ADS.readADC(0);         
  int16_t tension_A1 = ADS.readADC(1); 
          
 byte val0 = map(tension_A0, 0, 32767, 0, 255);
 analogWrite(setswic, val0);     
  
 { int  rdtx = analogRead(A6); 
    if (rdtx <= rdtmax )
    {analogWrite(pwrled, 200);}
     else
     {analogWrite(pwrled, 0);}
     

{  int incompz = digitalRead(12);
    if (digitalRead(12) == 0)
     {digitalWrite(outcompb, 1);}
    else 
    {digitalWrite(outcompb, 0);} 

{    int incompz = digitalRead(12);
    if  (digitalRead(12) == 1 && currentTime  - h2 > 200 )   
     {digitalWrite(hdt, 0); }
   else
     {digitalWrite(hdt, 1);   h2=currentTime ;  }

    {
       int16_t tension_A0 = ADS.readADC(0);       
 int16_t tension_A1 = ADS.readADC(1); 
  ADS.setGain(0);      
  ADS.setMode(1);    
  ADS.setDataRate(6);

       if (tension_A0 <=  tension_A1  && incompz ==0  )
   {digitalWrite (outcompv ,0); } 
      else 
      {digitalWrite (outcompv ,1);}
  
   bool inptpp = digitalRead(9);  bool incompz = digitalRead(12);
  if (inptpp  == 1 && incompz ==0 ) 
  {digitalWrite(trp, 1); digitalWrite(trn, 1);digitalWrite(npoutled, 1);  delay (400); }  
  else 
  {digitalWrite(trp, 0);  digitalWrite(trn, 0);  digitalWrite(npoutled, 0);  delay (1);}

 }
  }
}
} 
}
}

nzmxp · March 17, 2023, 10:24am

digitalread(13) hdt and (7) pin input will send pulse as if button is pressed. 100ms and eeprom counter will advance and record gain. pot switch is normally in 0 position
Pins (8) and (9) will follow comparator1115

nzmxp · March 17, 2023, 10:34am

Thank you to everyone who will help or not. good luck to everyone.

Topic		Replies	Views
Millis() not working problem Programming	14	1016	November 30, 2021
I want to know what's wrong with my coding Programming	17	553	January 16, 2022
Hydrogen sensor project need Help Programming	8	657	October 15, 2023
Losing my mind getting ADS1015 to output mV General Guidance	11	988	May 5, 2021
Using Arduino Uno and ADS1115 for ir speed sensor General Guidance	7	1559	May 5, 2021

Millis() question? ads1115 trials

Related topics