multiple if but one cases always on

Projects General Guidance
1

so i was working on project where there is 4 switch and its working as biner number
example :
s1 0, s2 0, s3 0, s4 1 = LED1 will be on
s1 1, s2 0, s3 1, s4 1 = LED 11 will be on

i write code like this but why LED 15 always on which mean all my switch is pressed

void setup() {
  Serial.begin(9600);
  pinMode(0,INPUT);
  pinMode(1,INPUT);
  pinMode(2,INPUT);
  pinMode(3,INPUT);
  pinMode(4,OUTPUT);
  pinMode(5,OUTPUT);
  pinMode(6,OUTPUT);
  pinMode(7,OUTPUT);
  pinMode(8,OUTPUT);
  pinMode(9,OUTPUT);
  pinMode(10,OUTPUT);
  pinMode(11,OUTPUT);
  pinMode(12,OUTPUT);
  pinMode(13,OUTPUT);
  pinMode(14,OUTPUT);
  pinMode(15,OUTPUT);
  pinMode(16,OUTPUT);
  pinMode(17,OUTPUT);
  pinMode(18,OUTPUT);
  pinMode(19,OUTPUT);
}

void loop()  {

if ( (digitalRead(0) == LOW) && (digitalRead(1) == LOW) && (digitalRead(2) == LOW) && (digitalRead(3) == LOW)){
    Serial.println("0");
    digitalWrite(4,LOW);
    digitalWrite(5,LOW);
    digitalWrite(6,LOW);
    digitalWrite(7,LOW);
    digitalWrite(8,LOW);
    digitalWrite(9,LOW);
    digitalWrite(10,LOW);
    digitalWrite(11,LOW);
    digitalWrite(12,LOW);
    digitalWrite(13,LOW);
    digitalWrite(14,LOW);
    digitalWrite(15,LOW);
    digitalWrite(16,LOW);
    digitalWrite(17,LOW);
    digitalWrite(18,LOW);
    
    }
  
else if ( (digitalRead(0) == LOW) && 
       (digitalRead(1) == LOW) &&
       (digitalRead(2) == LOW) && 
       (digitalRead(3) == HIGH)){
  Serial.println("1");
    digitalWrite(4,HIGH);
    digitalWrite(5,LOW);
    digitalWrite(6,LOW);
    digitalWrite(7,LOW);
    digitalWrite(8,LOW);
    digitalWrite(9,LOW);
    digitalWrite(10,LOW);
    digitalWrite(11,LOW);
    digitalWrite(12,LOW);
    digitalWrite(13,LOW);
    digitalWrite(14,LOW);
    digitalWrite(15,LOW);
    digitalWrite(16,LOW);
    digitalWrite(17,LOW);
    digitalWrite(18,LOW);
    
    }

else if ( (digitalRead(0) == LOW) && 
       (digitalRead(1) == LOW) &&
       (digitalRead(2) == HIGH) && 
       (digitalRead(3) == LOW)){
        Serial.println("2");
    digitalWrite(4,LOW);
    digitalWrite(5,HIGH);
    digitalWrite(6,LOW);
    digitalWrite(7,LOW);
    digitalWrite(8,LOW);
    digitalWrite(9,LOW);
    digitalWrite(10,LOW);
    digitalWrite(11,LOW);
    digitalWrite(12,LOW);
    digitalWrite(13,LOW);
    digitalWrite(14,LOW);
    digitalWrite(15,LOW);
    digitalWrite(16,LOW);
    digitalWrite(17,LOW);
    digitalWrite(18,LOW);
    
    }
  
else if ( (digitalRead(0) == LOW) && 
       (digitalRead(1) == LOW) &&
       (digitalRead(2) == HIGH) && 
       (digitalRead(3) == HIGH)){
        Serial.println("3");
    digitalWrite(4,LOW);
    digitalWrite(5,LOW);
    digitalWrite(6,HIGH);
    digitalWrite(7,LOW);
    digitalWrite(8,LOW);
    digitalWrite(9,LOW);
    digitalWrite(10,LOW);
    digitalWrite(11,LOW);
    digitalWrite(12,LOW);
    digitalWrite(13,LOW);
    digitalWrite(14,LOW);
    digitalWrite(15,LOW);
    digitalWrite(16,LOW);
    digitalWrite(17,LOW);
    digitalWrite(18,LOW);
    
    }
  
else if ( (digitalRead(0) == LOW) && 
       (digitalRead(1) == LOW) &&
       (digitalRead(2) == HIGH) && 
       (digitalRead(3) == LOW)){
        Serial.println("4");
    digitalWrite(4,LOW);
    digitalWrite(5,LOW);
    digitalWrite(6,LOW);
    digitalWrite(7,HIGH);
    digitalWrite(8,LOW);
    digitalWrite(9,LOW);
    digitalWrite(10,LOW);
    digitalWrite(11,LOW);
    digitalWrite(12,LOW);
    digitalWrite(13,LOW);
    digitalWrite(14,LOW);
    digitalWrite(15,LOW);
    digitalWrite(16,LOW);
    digitalWrite(17,LOW);
    digitalWrite(18,LOW);
    
    }
  
else if ( (digitalRead(0) == LOW) && 
       (digitalRead(1) == LOW) &&
       (digitalRead(2) == HIGH) && 
       (digitalRead(3) == HIGH)){
        Serial.println("5");
    digitalWrite(4,LOW);
    digitalWrite(5,LOW);
    digitalWrite(6,LOW);
    digitalWrite(7,LOW);
    digitalWrite(8,HIGH);
    digitalWrite(9,LOW);
    digitalWrite(10,LOW);
    digitalWrite(11,LOW);
    digitalWrite(12,LOW);
    digitalWrite(13,LOW);
    digitalWrite(14,LOW);
    digitalWrite(15,LOW);
    digitalWrite(16,LOW);
    digitalWrite(17,LOW);
    digitalWrite(18,LOW);
    
    }
    
else if ( (digitalRead(0) == LOW) && 
       (digitalRead(1) == HIGH) &&
       (digitalRead(2) == HIGH) && 
       (digitalRead(3) == LOW)){
        Serial.println("6");
    digitalWrite(5,LOW);
    digitalWrite(6,LOW);
    digitalWrite(7,LOW);
    digitalWrite(8,LOW);
    digitalWrite(9,HIGH);
    digitalWrite(10,LOW);
    digitalWrite(11,LOW);
    digitalWrite(12,LOW);
    digitalWrite(13,LOW);
    digitalWrite(14,LOW);
    digitalWrite(15,LOW);
    digitalWrite(16,LOW);
    digitalWrite(17,LOW);
    digitalWrite(18,LOW);
    
    }
  
else if ( (digitalRead(0) == LOW) && 
       (digitalRead(1) == HIGH) &&
       (digitalRead(2) == HIGH) && 
       (digitalRead(3) == HIGH)){
        Serial.println("7");
    digitalWrite(4,LOW);
    digitalWrite(5,LOW);
    digitalWrite(6,LOW);
    digitalWrite(7,LOW);
    digitalWrite(8,LOW);
    digitalWrite(9,LOW);
    digitalWrite(10,HIGH);
    digitalWrite(11,LOW);
    digitalWrite(12,LOW);
    digitalWrite(13,LOW);
    digitalWrite(14,LOW);
    digitalWrite(15,LOW);
    digitalWrite(16,LOW);
    digitalWrite(17,LOW);
    digitalWrite(18,LOW);
    
    }

sub.ino (9.59 KB)

2

If you post your code as described in the how to use his forum sticky more members will see it and you may get more and faster help.

3

else if ( (digitalRead(0) == HIGH) &&
(digitalRead(1) == LOW) &&
(digitalRead(2) == LOW) &&
(digitalRead(3) == LOW)){
Serial.println("8");
digitalWrite(4,LOW);
digitalWrite(5,LOW);
digitalWrite(6,LOW);
digitalWrite(7,LOW);
digitalWrite(8,LOW);
digitalWrite(9,LOW);
digitalWrite(10,LOW);
digitalWrite(11,HIGH);
digitalWrite(12,LOW);
digitalWrite(13,LOW);
digitalWrite(14,LOW);
digitalWrite(15,LOW);
digitalWrite(16,LOW);
digitalWrite(17,LOW);
digitalWrite(18,LOW);

}

else if ( (digitalRead(0) == HIGH) &&
(digitalRead(1) == LOW) &&
(digitalRead(2) == LOW) &&
(digitalRead(3) == HIGH)){
Serial.println("9");
digitalWrite(4,LOW);
digitalWrite(5,LOW);
digitalWrite(6,LOW);
digitalWrite(7,LOW);
digitalWrite(8,LOW);
digitalWrite(9,LOW);
digitalWrite(10,LOW);
digitalWrite(11,LOW);
digitalWrite(12,HIGH);
digitalWrite(13,LOW);
digitalWrite(14,LOW);
digitalWrite(15,LOW);
digitalWrite(16,LOW);
digitalWrite(17,LOW);
digitalWrite(18,LOW);

}

else if ( (digitalRead(0) == HIGH) &&
(digitalRead(1) == LOW) &&
(digitalRead(2) == HIGH) &&
(digitalRead(3) == LOW)){
Serial.println("10");
digitalWrite(4,LOW);
digitalWrite(5,LOW);
digitalWrite(6,LOW);
digitalWrite(7,LOW);
digitalWrite(8,LOW);
digitalWrite(9,LOW);
digitalWrite(10,LOW);
digitalWrite(11,LOW);
digitalWrite(12,LOW);
digitalWrite(13,HIGH);
digitalWrite(14,LOW);
digitalWrite(15,LOW);
digitalWrite(16,LOW);
digitalWrite(17,LOW);
digitalWrite(18,LOW);

}

else if ( (digitalRead(0) == HIGH) &&
(digitalRead(1) == LOW) &&
(digitalRead(2) == HIGH) &&
(digitalRead(3) == HIGH)){
Serial.println("11");
digitalWrite(4,LOW);
digitalWrite(5,LOW);
digitalWrite(6,LOW);
digitalWrite(7,LOW);
digitalWrite(8,LOW);
digitalWrite(9,LOW);
digitalWrite(10,LOW);
digitalWrite(11,LOW);
digitalWrite(12,LOW);
digitalWrite(13,LOW);
digitalWrite(14,HIGH);
digitalWrite(15,LOW);
digitalWrite(16,LOW);
digitalWrite(17,LOW);
digitalWrite(18,LOW);

}

else if ( (digitalRead(0) == HIGH) &&
(digitalRead(1) == LOW) &&
(digitalRead(2) == HIGH) &&
(digitalRead(3) == LOW)){
Serial.println("12");
digitalWrite(4,LOW);
digitalWrite(5,LOW);
digitalWrite(6,LOW);
digitalWrite(7,LOW);
digitalWrite(8,LOW);
digitalWrite(9,LOW);
digitalWrite(10,LOW);
digitalWrite(11,LOW);
digitalWrite(12,LOW);
digitalWrite(13,LOW);
digitalWrite(14,LOW);
digitalWrite(15,HIGH);
digitalWrite(16,LOW);
digitalWrite(17,LOW);
digitalWrite(18,LOW);

}

else if ( (digitalRead(0) == HIGH) &&
(digitalRead(1) == LOW) &&
(digitalRead(2) == HIGH) &&
(digitalRead(3) == HIGH)){
Serial.println("13");
digitalWrite(4,LOW);
digitalWrite(5,LOW);
digitalWrite(6,LOW);
digitalWrite(7,LOW);
digitalWrite(8,LOW);
digitalWrite(9,LOW);
digitalWrite(10,LOW);
digitalWrite(11,LOW);
digitalWrite(12,LOW);
digitalWrite(13,LOW);
digitalWrite(14,LOW);
digitalWrite(15,LOW);
digitalWrite(16,HIGH);
digitalWrite(17,LOW);
digitalWrite(18,LOW);

}

else if ( (digitalRead(0) == HIGH) &&
(digitalRead(1) == HIGH) &&
(digitalRead(2) == HIGH) &&
(digitalRead(3) == LOW)){
Serial.println("14");
digitalWrite(4,LOW);
digitalWrite(5,LOW);
digitalWrite(6,LOW);
digitalWrite(7,LOW);
digitalWrite(8,LOW);
digitalWrite(9,LOW);
digitalWrite(10,LOW);
digitalWrite(11,LOW);
digitalWrite(12,LOW);
digitalWrite(13,LOW);
digitalWrite(14,LOW);
digitalWrite(15,LOW);
digitalWrite(16,LOW);
digitalWrite(17,HIGH);
digitalWrite(18,LOW);

}

else{
Serial.println("15");
digitalWrite(4,LOW);
digitalWrite(5,LOW);
digitalWrite(6,LOW);
digitalWrite(7,LOW);
digitalWrite(8,LOW);
digitalWrite(9,LOW);
digitalWrite(10,LOW);
digitalWrite(11,LOW);
digitalWrite(12,LOW);
digitalWrite(13,LOW);
digitalWrite(14,LOW);
digitalWrite(15,LOW);
digitalWrite(16,LOW);
digitalWrite(17,LOW);
digitalWrite(18,HIGH);

}

delay(1000);

}

4

Please read the 'how to post' sticky again.

Which Arduino are you using.
Pin0 and pin1 can't be used on most Arduinos, because they are already used by the USB<>Serial chip.
And pin 14, 15, etc are different pins on different Arduinos.

Most blocks in your code can be replaced by one line.
Example:

for(int i = 4; i <= 18; i++) digitalWrite(i, HIGH); // set pin4-18 HIGH

Leo..

5

Perhaps if the conditions for 12 and 13 weren't the same as for 10 and 11 it would help.

Steve