Multiple TMP36 Use Code check

Projects Programming
1

So currently I am using an Uno to design a controller for my beer brewing bench. Eventually I will be using my Yun for the final. I will require using three temp sensors in the whole scheme of things. Currently I am working with TMP36's. I will also be playing with Dallas sensors later. The following code is what I am using:

//TMP36 Pin Variables
int temperaturePin1 = 0; 
int temperaturePin2 = 1;
int temperaturePin3 = 2;

void setup()
{
  Serial.begin(9600); 
}
 
void loop()                   
{
 float temperature1 = getVoltage(temperaturePin1); 
 temperature1 = (((temperature1 - .5) * 100) * 1.8) + 32;
 ((volatge - 500mV) times 100)
 Serial.print(temperature1); 
 Serial.println(" Degrees Fahrenheit Pin 1");    
 delay(5000);  

float temperature2 = getVoltage(temperaturePin2); 
 temperature2 = (((temperature2 - .5) * 100) * 1.8) + 32;  ((volatge - 500mV) times 100)
 Serial.print(temperature2); 
 Serial.println(" Degrees Fahrenheit Pin 2");    
 delay(5000); 
 
 float temperature3 = getVoltage(temperaturePin3); 
 temperature3 = (((temperature3 - .5) * 100) * 1.8) + 32;
 ((volatge - 500mV) times 100)
 Serial.print(temperature3); 
 Serial.println(" Degrees Fahrenheit Pin 3");    
 delay(5000);  
}

float getVoltage(int pin){
 return (analogRead(pin) * .004882814); 
}

Its the ardx.com/code10 modified by me. The results I am experiencing seem fine so far but I have not done any calibrating yet.

My question is, does anyone see any problem that I would have using the code that I currently am using? Meaning currently this will run efficient? As I go along I will add smoothing code after calibrating the sensors.

I have less than 1500 hours of coding experience and that was with Visual Basic. I make my way but takes a while. Thanks in advance!

2

Please use more code lines.
This code

analogRead(pin) * .004882814

That is a number, and you can't tell what it is. If by mistake that number changes from .004882814 into .00482814, you would never see the problem.

Let the compiler (or Arduino) do that for you, that doesn't require more memory.
Use it like this:

(float) analogRead(pin) * 5.0 / 1023.0

What about a function that returns the temperature ?
As you can see, I use more variables to calculcate temporary values. That is what I like. The source code should be readable, and let the compiler and Arduino do the work. In the end the code is probably not larger, since the compiler can optimize these things.

float getTemperature(int pin){
  // the raw ADC value is 0 to 2023 for a range of 5 Volt.
  float voltage = (float) analogRead(pin) * 5.0 / 1023.0;
  // Convert to temperature.
  float celsius = (voltage - 0.5 ) * 100.0;
  float fahrenheit = (celsius * 1.8 ) + 32.0;
  return (fahrenheit);
}
3

+1 for the function

cast to (float) is not needed, will be done automatically as it is multiplied by a float.
(It might even be preferred to keep it an int, never tested)

Alert: conflict between code and comment
// the raw ADC value is 0 to 2023 for a range of 5 Volt.
float voltage = (float) analogRead(pin) * 5.0 / 1023.0;

4

I always use it like that.
The raw value of the ADC is an integer up to 1023.
The calculation is written for float calculation. I write everything as float, so both me and the compiler know that it is calculated with float.

5

if it is by choice , OK