i run my code and when it gets to the void checkStartingPin() it calls a function that turns on a light but it only does it 80% of the time is it skipping the part of the code for some reason?
/*
_________ __ __
\_ ___ \ ____ ____ _______/ |______ _____/ |_ ______
/ \ \/ / _ \ / \ / ___/\ __\__ \ / \ __\/ ___/
\ \___( <_> ) | \\___ \ | | / __ \| | \ | \___ \
\______ /\____/|___| /____ > |__| (____ /___| /__| /____ >
\/ \/ \/ \/ \/ \/
*/
// Pin values for Lights
const byte LEDWhite1 = 2;
const byte LEDWhite2 = 5;
const byte ARDUINOoutput = 50;
const byte ARDUINOInput = 51;
const byte LEDYellow1 = 6;
const byte LEDYellow2 = 8;
const byte LEDYellow3 = 10;
const byte LEDGreen = 11;
const byte LEDRed = 12;
const byte WinnerOut = 7;
const byte WinnerIn = 9;
// Pin values for Lasers
const byte StagingLinePin = 22;
const byte StartingLinePin = 23;
const byte EightMileLinePin = 28;
const byte FinishLinePin = 24;
//handicap timer
unsigned long Handicapvalue = 0;
// Delay between the countdoown lights
const unsigned InitialDelay = 1000; // between Stage and first Yellow
const unsigned YellowDelay = 500; // between each Yellow and Green
const unsigned HandicapDelay = Handicapvalue; // Handicap
/*
____ ____ .__ ___. .__
\ \ / /____ _______|__|____ \_ |__ | | ____ ______
\ Y /\__ \\_ __ \ \__ \ | __ \| | _/ __ \ / ___/
\ / / __ \| | \/ |/ __ \| \_\ \ |_\ ___/ \___ \
\___/ (____ /__| |__(____ /___ /____/\___ >____ >
\/ \/ \/ \/ \/
*/
// State Flags
bool RaceHasStarted = false; // Set 'true' when Green light is turned on
bool RaceHasFinished = false; // Set 'true' when Finish Line is crossed
// Timers for Race
unsigned long RaceStartTime = 0; // Set to micros() when Green light is turned on
unsigned long RaceFinishTime = 0; // Set to micros() when Finish Line is crossed
unsigned long RaceEightMile = 0; // Set to micros() when 1/8 Finish Line is crossed
unsigned long ReactionTimer = 0; // This will contain the reaction time
unsigned long HandicapTimer = 0;
// Timer for Light Countdown
unsigned long CountdownStart = 0; // Note: Doubles as a state flag: if != 0, countdown is in progress; Set to millis() when Start Line is crossed
// Time since start of program
unsigned long now;
/*
___________ __ .__
\_ _____/_ __ ____ _____/ |_|__| ____ ____ ______
| __)| | \/ \_/ ___\ __\ |/ _ \ / \ / ___/
| \ | | / | \ \___| | | ( <_> ) | \\___ \
\___ / |____/|___| /\___ >__| |__|\____/|___| /____ >
\/ \/ \/ \/ \/
*/
// Turns on Light on pin 'lightPin'
void turnOnLight(byte lightPin) {
digitalWrite (lightPin, HIGH);
}
// Turns off Light on pin 'lightPin'
void turnOffLight(byte lightPin) {
digitalWrite (lightPin, LOW);
}
// turn on Red LED, turn off all others
void falseStart() {
// turn on Red LED
turnOnLight(LEDRed);
// turn off all other LEDs
turnOffLight(LEDWhite1);
turnOffLight(LEDWhite2);
turnOffLight(LEDYellow1);
turnOffLight(LEDYellow2);
turnOffLight(LEDYellow3);
turnOffLight(LEDGreen);
}
void checkStagingPin() {
if (digitalRead(StagingLinePin) == HIGH) {
turnOnLight(LEDWhite1);
}
else if (digitalRead(StagingLinePin) == LOW) {
turnOffLight(LEDWhite1);
}
}
void checkStartingPin() {
if (digitalRead(StartingLinePin) == HIGH) {
turnOffLight(LEDRed); // Turn off the red light again. We are back at the start.
//digitalWrite(LEDWhite2, HIGH);
turnOnLight(LEDWhite2);
//Serial.print("this is wheer light s supposed to go on");
digitalWrite (ARDUINOoutput, HIGH);
} else if (StartingLinePin == LOW) {
turnOffLight(LEDWhite2);
digitalWrite(ARDUINOoutput, LOW);
}
if ((digitalRead(ARDUINOInput) == HIGH) && (digitalRead(StartingLinePin) == HIGH)) { // if Starting Line sensor is blocked turn on white led 2 and check other arduino for car stage
CountdownStart = millis(); // Start the countdown to GREEN
}
}
void RaceInPreStage() {
checkStagingPin();
checkStartingPin();
}
void RaceInCountdown() {
unsigned long elapsedCountdown = now - CountdownStart;
checkStagingPin();
// The car has left the Starting Line before the countdown ended!
if (digitalRead(StartingLinePin) == LOW) {
falseStart();
CountdownStart = 0; // DO NOT CONTINUE COUNTDOWN!
return;
}
if (elapsedCountdown >= (InitialDelay + HandicapDelay)) {
turnOnLight(LEDYellow1);
}
if (elapsedCountdown >= (InitialDelay + YellowDelay + HandicapDelay)) {
turnOnLight(LEDYellow2);
}
if (elapsedCountdown >= (InitialDelay + YellowDelay + YellowDelay + HandicapDelay)) {
turnOnLight(LEDYellow3);
}
if (elapsedCountdown >= (InitialDelay + YellowDelay + YellowDelay + YellowDelay + HandicapDelay)) {
turnOnLight(LEDGreen);
turnOffLight(LEDWhite1);
turnOffLight(LEDWhite2);
turnOffLight(LEDYellow1);
turnOffLight(LEDYellow2);
turnOffLight(LEDYellow3);
digitalWrite(WinnerOut, LOW);
RaceHasStarted = true;
RaceStartTime = micros(); // Measure race in microseconds
CountdownStart = 0; // Countdown is done
}
}
void RaceInProgress() {
//HandicapTimer = (Handicapvalue * 1000);
if ( ReactionTimer == 0 && (digitalRead(StartingLinePin) == LOW)) {
ReactionTimer = micros() - RaceStartTime; // When the car leaves the starting line after we turned green, capture the reaction time
Serial.print("Reaction Time: ");
Serial.println(ReactionTimer / 1000000.0, 4);
}
if (digitalRead(FinishLinePin) == HIGH ) {
RaceFinishTime = micros(); // Time of Finish
RaceHasFinished = true;
Serial.print("Finish time: ");
Serial.println((RaceFinishTime - RaceStartTime - ReactionTimer) / 1000000.0, 4);
Serial.print("Total time: ");
Serial.println(((RaceFinishTime - RaceStartTime) ) / 1000000.0, 4);
}
}
void RaceDone() {
digitalWrite(WinnerOut, HIGH);
if (digitalRead(WinnerIn) == HIGH) {
Serial.print("Done Second ");
}
else if (digitalRead(WinnerIn) == LOW) {
Serial.print("Done First");
}
while (1);
}
/*
_____ .___ .__
/ _ \_______ __| _/_ __|__| ____ ____
/ /_\ \_ __ \/ __ | | \ |/ \ / _ \
/ | \ | \/ /_/ | | / | | ( <_> )
\____|__ /__| \____ |____/|__|___| /\____/
\/ \/ \/
*/
void setup() {
Serial.begin(9600);
// Initialize Lights On Drag Tree
pinMode(LEDWhite1, OUTPUT); // Pre-stage light
pinMode(LEDWhite2, OUTPUT); // Stage light
pinMode(LEDYellow1, OUTPUT); // Turns on 'InitialDelay' milliseconds after White2
pinMode(LEDYellow2, OUTPUT); // Turns on 'YellowDelay' milliseconds after Yellow1
pinMode(LEDYellow3, OUTPUT); // Turns on 'YellowDelay' milliseconds after Yellow2
pinMode(LEDGreen, OUTPUT); // Start: Turns on 'YellowDelay' milliseconds after Yellow3
pinMode(LEDRed, OUTPUT); // Fault: Leaving Staging Line between White2 and Green
//Initialize pins that tells who finished first
pinMode(WinnerOut, OUTPUT);
pinMode(WinnerIn, OUTPUT);
// Initialize Input Lasers
pinMode(StagingLinePin, INPUT); //checks stage light laser
pinMode(StartingLinePin, INPUT); //checks stage light laser
pinMode(FinishLinePin, INPUT); //checks finish line light laser
pinMode(EightMileLinePin, INPUT); //checks 1/8 mile line pin
// Initialize communications between the two arduinos
pinMode(ARDUINOoutput, OUTPUT); // Arduino sends out signal to other arduino saying car is staged
pinMode(ARDUINOInput, INPUT); // Arduino recieves signal from other arduino saying car is staged
}
void loop()
{
now = millis(); // Get current time
if (RaceHasFinished) {
RaceDone();
}
else if (RaceHasStarted) {
RaceInProgress();
}
else if (CountdownStart != 0) {
RaceInCountdown();
}
else {
RaceInPreStage();
}
}
You're just moving too fast and not vetting your code. Look at the form of the 'if' condition...