My first sketch, did i do it right?

AWOL:

a, does it look correct for arduino code? h

You could make more use of the "const" qualified for things like your pin identifiers.

Ah yes, that will save memory! thanks

 Serial.println"display digits 1000,100,10,1";

That's not good

That's just a debug line to tell me that the next lines through will be in order of thousands, hundreds, tens, units?

Thanks I will use "const" for non-changing variables from now on, I didn't even know I could!