Need help with char command

Projects Programming
1

I want to sent data from dht11 sensor, and control fan speed - via bluetooth to my app.

i have the code of both - but i don't know how to conected it to one project.

while (Serial.available()) {
delay(3);

char c = Serial.read();
readString += c;
outputValue = map(readString.toInt(), 0, 1023, 0, 255);

if (readString.length() >0) {
Serial.println(readString.toInt());
analogWrite(FAN,outputValue );
readString="";
return;

if (c == 't'){

int t = (int)dht.readTemperature();
Serial.println(String(t) + "C");

if (c == 'h'){

int h = (int)dht.readHumidity();
Serial.println(String(h) + "%");

thanking you in advance,

Shai

2 
  if (c == 't'){

           int t = (int)dht.readTemperature();
           Serial.println(String(t) + "C");

           if (c == 'h'){

You've already decided that c is a 't', so it is utterly pointless checking to see if it a 'h'.

3

i have the code of both

Or, some of it, horribly indented and posted incorrectly.

but i don't know how to conected it to one project.

You start with some requirements. What is the program to do?

4

char is not a command. It is a data type

Have a look at Serial Input Basics - simple reliable ways to receive data.

...R

5

AWOL:

  if (c == 't'){

int t = (int)dht.readTemperature();
          Serial.println(String(t) + "C");

if (c == 'h'){



You've already decided that c is a 't', so it is utterly pointless checking to see if it a 'h'.

AWOL:

  if (c == 't'){

int t = (int)dht.readTemperature();
          Serial.println(String(t) + "C");

if (c == 'h'){



You've already decided that c is a 't', so it is utterly pointless checking to see if it a 'h'.

if i use only this part of the code:

if (Serial.available()) {
// Read command
byte c = Serial.read ();
// If a measurement is required, measure data and send it back
if (c == 't'){

int t = (int)dht.readTemperature();
Serial.println(String(t) + "c");
}

if (c == 'h'){

int h = (int)dht.readHumidity();
Serial.println(String(h) + "%");

it's work fine - send me the data from dht11....

but if i add this part :

char c = Serial.read();
readString += c;
outputValue = map(readString.toInt(), 0, 1023, 0, 255);

if (readString.length() >0) {
Serial.println(readString.toInt());
analogWrite(FAN,outputValue );
readString="";

the both part of the code didt work at all (together) - conflict?

I will need to know how to combine the 2 parts of the code.

thanks again
shai

6

PaulS:
Or, some of it, horribly indented and posted incorrectly.
You start with some requirements. What is the program to do?

read data from multi sensors and send it to lcd 16X2, and smart phone via bt, and control via relay. and (i hope) addto this - fan speed control via bt (slider):slight_smile:

all this work fine - but because the both are a char - i dno't know how to combine it in 1 code.

if i need to change all this part of the code - go for it :slight_smile:

7

if i need to change all this part of the code - go for it

You have program one. You posted some snippet, incorrectly, that may, or may not, have been part of program one.

You have program two. You posted some snippet, incorrectly, that may, or may not, have been part of program two.

You want to know how to combine them into one program. So, I suggest that you take the odd numbered lines from program one, and paste them in program three. Then, take the even number lines from program two, and add them to the end of program three, in reverse order. Throw away the rest of program one, and paste the rest of program two onto the end of program three.

If that doesn't result in a program that does what you want, you might try posting ALL of program one and ALL of program two, after using Tools + Auto Format on both of them, AND reading the stickies at the top of the forum that describe how to post code PROPERLY.

8

PaulS:
You have program one. You posted some snippet, incorrectly, that may, or may not, have been part of program one.

You have program two. You posted some snippet, incorrectly, that may, or may not, have been part of program two.

You want to know how to combine them into one program. So, I suggest that you take the odd numbered lines from program one, and paste them in program three. Then, take the even number lines from program two, and add them to the end of program three, in reverse order. Throw away the rest of program one, and paste the rest of program two onto the end of program three.

If that doesn't result in a program that does what you want, you might try posting ALL of program one and ALL of program two, after using Tools + Auto Format on both of them, AND reading the stickies at the top of the forum that describe how to post code PROPERLY.

Thank you again - for your comment :slight_smile:

the project work fine - until i add the "fan speed lines into my full code.

because are both char (char = c), also if i change one to byte.
the data that sending from dht11 to my app (via bt) - working fine .

but if i trying to control the fan speed from my app (via bt) - nonworking - only if i delete the dht11 data sending lines.

you now what - if you have (or you know how) a simple code to let me control the speed of the fan via (button in my app. - you help my a lot :slight_smile:

thanks again,

shai

9

the project work fine - until i add the "fan speed lines into my full code.

If you share the code, explain what it actually does (if it even compiles) and what you expect it to do, maybe we could offer more than insincere sympathy.

10

PaulS:
If you share the code, explain what it actually does (if it even compiles) and what you expect it to do, maybe we could offer more than insincere sympathy.

The code work fine (i uplouded it to my nano) is sent a data to my app via bt - i got the data by pressed on a button into my app.

the lines of the data and the fan are both char = c (as a separate code).

if i add the "fan speed lines" into the code with the data store - is upload the code but dont let my control the speed. if i delete the data "char = c" lines, the code worked with "fan speed ".

I need to know how continue the char = c code, that combine or included the data from dht11 and let my control the fan speed, or if you can save your time and help my - i need small code that let my to control fan speed by "pressed a button" into my app (via bt).

p.s if i use not char = c , to control the fan speed, is worked - but no so well (i dont know how to add a button to my code).

for now is a slider but a button is better option.

yours,

shai

11

The code work fine

The code you did not share works. Well, then, there is no reason to share it, and we can consider the problem solved. Glad to be able to help.

12

PaulS:
The code you did not share works. Well, then, there is no reason to share it, and we can consider the problem solved. Glad to be able to help.
[/quote

I share the relevant part of the code.

the cod desnt work with the fan speed part :frowning:

if you can help my - ok, but dont be cynical :slight_smile:

:slight_smile:

13

I share the relevant part of the code.

But none of the code that was your attempt to combine two discrete programs.

It is simple to POST YOUR CODE. ALL of it.

It is simple to describe what the code actually does, and how that differs from what you want it to do.

if you can help my - ok

Well, I can't. You've given us nothing to work with, so I'm done trying.