I'm programming an Arduino Uno board to act as a pump/valve controller. So far I've gotten it to turn my pump on and sequence the valves but am stuck at getting it to turn pump off and pause for the night. Could someone take a look and point me in a direction. I'm good until after " digitalWrite (7, HIGH); //Turn pump on " If the other two lines that are commented out are add in, the program crashes.
I don't know how to get the program to turn pump off, pause for 6 hrs then start over.
// the setup function runs once when you press reset or power the board
unsigned long time;
oid setup() {
Serial.begin (9600);
for (int thisPin = 2; thisPin < 7; thisPin++) { //use for loop to initialize each pin2thru8 as solenoidvalve output
// initialize digital pin 13,7 as an output.
pinMode(13, OUTPUT); pinMode(7, OUTPUT); pinMode(thisPin, OUTPUT);
}
}
// the loop function runs over and over again forever
void loop() {
Serial.print("Time: ");
time = millis();
Serial.println(time); //prints time since program started
delay(1000); // wait a second so as not to send massive amounts of data
digitalWrite(13, HIGH); // turn the heartbeat led on
delay (1000); // wait for a second
digitalWrite(13, LOW); // turn the heartbeat LED
delay(1000); // wait for a second
//Turn pump on
digitalWrite (7, HIGH);
//Check time
//if (time >= 60000);(time,0);else{ //value to be replaced with 64800000 (18hrs) final program.
//digitalWrite (7, LOW);
for (int thisPin = 2; thisPin < 7; thisPin++) { //loop from lowest pin to highest
digitalWrite(thisPin, HIGH);
delay(1000); //Turn Valves on one minute each(insert 60000 for 1 minute on)
digitalWrite(thisPin, LOW); // turn the valve off
delay(1000);
}
}
Please do us and yourself a favour.
Remove the multiple blank lines in the code, in the IDE use Auto Format then paste the code here, select it and click the code tags icon (</>) top/left of the forum editor and save the post.
Much better thanks. Easier to read and copy to an editor.
When you say that the program crashes, how does that manifest itself ?
if (time >= 60000);(time,0);else{ //value to be replaced with 64800000 (18hrs) final program.
digitalWrite (7, LOW);
This is not going to work. For one thing time,0 does not set the time variable to zero and for another you set it back to millis() each time through loop() anyway. millis() will not rollover to zero for 49 and a bit days so for most of the time it, and therefore the time variable, will exceed 60000.
To use millis() for timing, which is a valuable technique, you need to save the start time of an event then each time through loop() compare the current value of millis() with the start time to determine whether the required period has elapsed as in the BlinkWithoutDelay example and Several things at the same time
Your code is currently not structured to do that.
Here's error message when I try to compile:
Arduino: 1.6.9 (Mac OS X), Board: "Arduino/Genuino Uno"
/Users/okeymccomis/Documents/Arduino/Okeypumpcontroller_may18c/Okeypumpcontroller_may18c.ino: In function 'void loop()':
Okeypumpcontroller_may18c:24: error: 'else' without a previous 'if'
if (time >= 60000);(time,0);else{ //value to be replaced with 64800000 (18hrs) final program.
^
Okeypumpcontroller_may18c:32: error: expected '}' at end of input
}
^
exit status 1
'else' without a previous 'if'
This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.
The error message is caused by the semicolon on the end of the if
if (time >= 60000);(time,0);else{ //value to be replaced with 64800000 (18hrs) final program.
digitalWrite (7, LOW);
This code restructured to make it easier to read would be
if (time >= 60000);
(time,0); // why the parentheses ?
else
{
digitalWrite (7, LOW);
The code executed when the test is true is only the semicolon. The (time,0), which is wrong anyway, is then unconditionally executed hence the subsequent else has no matching if.
A suggestion. Use this form of if/else
if (this is true)
{
//execute the code here
}
else
{
//execute the code here
}
This code
for (int thisPin = 2; thisPin < 7; thisPin++) { //use for loop to initialize each pin2thru8 as solenoidvalve output
// initialize digital pin 13,7 as an output.
pinMode(13, OUTPUT); pinMode(7, OUTPUT); pinMode(thisPin, OUTPUT);
}
has a comment that says that it initializes pins 2 through 8. Actually, it initializes pins 2 through 6, and repeatedly initializes pins 7 and 13.