/*************************************************
* Public Constants define notes
*************************************************/
#define NOTE_B0 31
#define NOTE_C1 33
#define NOTE_CS1 35
#define NOTE_D1 37
#define NOTE_DS1 39
#define NOTE_E1 41
#define NOTE_F1 44
#define NOTE_FS1 46
#define NOTE_G1 49
#define NOTE_GS1 52
#define NOTE_A1 55
#define NOTE_AS1 58
#define NOTE_B1 62
#define NOTE_C2 65
#define NOTE_CS2 69
#define NOTE_D2 73
#define NOTE_DS2 78
#define NOTE_E2 82
#define NOTE_F2 87
#define NOTE_FS2 93
#define NOTE_G2 98
#define NOTE_GS2 104
#define NOTE_A2 110
#define NOTE_AS2 117
#define NOTE_B2 123
#define NOTE_C3 131
#define NOTE_CS3 139
#define NOTE_D3 147
#define NOTE_DS3 156
#define NOTE_E3 165
#define NOTE_F3 175
#define NOTE_FS3 185
#define NOTE_G3 196
#define NOTE_GS3 208
#define NOTE_A3 220
#define NOTE_AS3 233
#define NOTE_B3 247
#define NOTE_C4 262
#define NOTE_CS4 277
#define NOTE_D4 294
#define NOTE_DS4 311
#define NOTE_E4 330
#define NOTE_F4 349
#define NOTE_FS4 370
#define NOTE_G4 392
#define NOTE_GS4 415
#define NOTE_A4 440
#define NOTE_AS4 466
#define NOTE_B4 494
#define NOTE_C5 523
#define NOTE_CS5 554
#define NOTE_D5 587
#define NOTE_DS5 622
#define NOTE_E5 659
#define NOTE_F5 698
#define NOTE_FS5 740
#define NOTE_G5 784
#define NOTE_GS5 831
#define NOTE_A5 880
#define NOTE_AS5 932
#define NOTE_B5 988
#define NOTE_C6 1047
#define NOTE_CS6 1109
#define NOTE_D6 1175
#define NOTE_DS6 1245
#define NOTE_E6 1319
#define NOTE_F6 1397
#define NOTE_FS6 1480
#define NOTE_G6 1568
#define NOTE_GS6 1661
#define NOTE_A6 1760
#define NOTE_AS6 1865
#define NOTE_B6 1976
#define NOTE_C7 2093
#define NOTE_CS7 2217
#define NOTE_D7 2349
#define NOTE_DS7 2489
#define NOTE_E7 2637
#define NOTE_F7 2794
#define NOTE_FS7 2960
#define NOTE_G7 3136
#define NOTE_GS7 3322
#define NOTE_A7 3520
#define NOTE_AS7 3729
#define NOTE_B7 3951
#define NOTE_C8 4186
#define NOTE_CS8 4435
#define NOTE_D8 4699
#define NOTE_DS8 4978
//define ledpins
const int rLed1 = 0;
const int rLed2 = 1;
const int rLed3 = 2;
const int rLed4 = 3;
const int rLed5 = 4;
const int rLed6 = 5;
const int wLed1 = 6;
const int wLed2 = 7;
const int wLed3 = 8;
const int wLed4 = 9;
const int wLed5 = 12;
const int wLed6 = 13;
const int buttonPin = 10;
const int buzzerPin = 11;
//define intervals
const int blinkDuration = 2000;
const int buttonInterval = 300;
const int wLedInterval = 2000;
const int wLedInterval2 = 6000;
const int rLedInterval = 4000;
const int rLedInterval2 = 8000;
const int aLedInterval = 10000;
//define millis
unsigned long currentMillis = 0;
unsigned long previousRLedMillis = 0;
unsigned long previousRLedMillis2 = 0;
unsigned long previousWLedMillis = 0;
unsigned long previousWLedMillis2 = 0;
unsigned long previousALedMillis = 0;
unsigned long previousButtonMillis = 0;
unsigned long previousMelodyMillis = 0;
//define pinstates
byte rLedState = LOW;
byte wLedState = LOW;
byte aLedState = LOW;
byte buttonState = LOW;
// melody of the song
int melody[] = {
NOTE_E5, NOTE_E5, NOTE_E5,
NOTE_E5, NOTE_E5, NOTE_E5,
NOTE_E5, NOTE_G5, NOTE_C5, NOTE_D5,
NOTE_E5,
NOTE_F5, NOTE_F5, NOTE_F5, NOTE_F5,
NOTE_F5, NOTE_E5, NOTE_E5, NOTE_E5, NOTE_E5,
NOTE_E5, NOTE_D5, NOTE_D5, NOTE_E5,
NOTE_D5, NOTE_G5
};
// tempo of the song
int tempo[] = {
8, 8, 4,
8, 8, 4,
8, 8, 8, 8,
2,
8, 8, 8, 8,
8, 8, 8, 16, 16,
8, 8, 8, 8,
4, 4
};
// make pins input/output
void setup() {
Serial.begin(6900);
Serial.println("Starting kerstboomprog.ino");
Serial.print("buttonState = ");
Serial.println(buttonState);
pinMode(rLed1, OUTPUT);
pinMode(rLed2, OUTPUT);
pinMode(rLed3, OUTPUT);
pinMode(rLed4, OUTPUT);
pinMode(rLed5, OUTPUT);
pinMode(rLed6, OUTPUT);
pinMode(wLed1, OUTPUT);
pinMode(wLed2, OUTPUT);
pinMode(wLed3, OUTPUT);
pinMode(wLed4, OUTPUT);
pinMode(wLed5, OUTPUT);
pinMode(wLed6, OUTPUT);
pinMode(buttonPin, INPUT_PULLUP);
pinMode(buzzerPin, OUTPUT);
}
void loop() {
//define currentmillis and calls functions
currentMillis = millis();
readButton();
updatewLedState();
updatewLedState2();
updaterLedState();
updaterLedState2();
switchLeds();
song();
}
//updates ledstate of white leds
void updatewLedState() {
if (buttonState == LOW){
if (wLedState == LOW){
if (currentMillis - previousWLedMillis >= wLedInterval){
wLedState = HIGH;
previousWLedMillis += wLedInterval;
}
}
else {
if (currentMillis - previousWLedMillis >= blinkDuration) {
wLedState = LOW;
previousWLedMillis += blinkDuration;
}
}
}
}
//second update of white leds
void updatewLedState2() {
if (buttonState == LOW){
if (wLedState == LOW){
if (currentMillis - previousWLedMillis2 >= wLedInterval2){
wLedState = HIGH;
previousWLedMillis2 += wLedInterval2;
}
}
else {
if (currentMillis - previousWLedMillis2 >= blinkDuration) {
wLedState = LOW;
previousWLedMillis2 += blinkDuration;
}
}
}
}
//update red leds
void updaterLedState() {
if (buttonState == LOW){
if (rLedState == LOW){
if (currentMillis - previousRLedMillis >= rLedInterval){
rLedState = HIGH;
previousRLedMillis += rLedInterval;
}
}
else {
if (currentMillis - previousRLedMillis >= blinkDuration) {
rLedState = LOW;
previousRLedMillis += blinkDuration;
}
}
}
}
//updates second red led state
void updaterLedState2() {
if (buttonState == LOW){
if (rLedState == LOW){
if (currentMillis - previousRLedMillis2 >= rLedInterval2){
rLedState = HIGH;
previousRLedMillis2 += rLedInterval2;
}
}
else {
if (currentMillis - previousRLedMillis2 >= blinkDuration) {
rLedState = LOW;
previousRLedMillis2 += blinkDuration;
}
}
}
}
//updates state for all leds
void updateaLedState() {
if (buttonState == LOW){
if (aLedState == LOW){
if (currentMillis - previousALedMillis >= aLedInterval){
aLedState = HIGH;
previousALedMillis += aLedInterval;
}
}
else {
if (currentMillis - previousALedMillis >= blinkDuration) {
wLedState = LOW;
previousALedMillis += blinkDuration;
}
}
}
}
// turns on the leds
void switchLeds() {
digitalWrite(rLed1, rLedState);
digitalWrite(rLed2, rLedState);
digitalWrite(rLed3, rLedState);
digitalWrite(rLed4, rLedState);
digitalWrite(rLed5, rLedState);
digitalWrite(rLed6, rLedState);
digitalWrite(wLed1, wLedState);
digitalWrite(wLed2, wLedState);
digitalWrite(wLed3, wLedState);
digitalWrite(wLed4, wLedState);
digitalWrite(wLed5, wLedState);
digitalWrite(wLed6, wLedState);
digitalWrite(rLed1, aLedState);
digitalWrite(rLed2, aLedState);
digitalWrite(rLed3, aLedState);
digitalWrite(rLed4, aLedState);
digitalWrite(rLed5, aLedState);
digitalWrite(rLed6, aLedState);
digitalWrite(wLed1, aLedState);
digitalWrite(wLed2, aLedState);
digitalWrite(wLed3, aLedState);
digitalWrite(wLed4, aLedState);
digitalWrite(wLed5, aLedState);
digitalWrite(wLed6, aLedState);
}
//checks for button
void readButton(){
if(millis() - previousButtonMillis >= buttonInterval){
if(digitalRead(buttonPin) == LOW){
buttonState = ! buttonState;
Serial.print ("buttonState = ");
Serial.println (buttonState);
}
}
}
//define the pausebetween notes and note duration
void song(){
if(buttonState == LOW){
int size = sizeof(melody) / sizeof(int);
for (int thisNote = 0; thisNote < size; thisNote++) {
// to calculate the note duration, take one second
// divided by the note type.
//e.g. quarter note = 1000 / 4, eighth note = 1000/8, etc.
int noteDuration = 1000 / tempo[thisNote];
tone(buzzerPin, melody[thisNote], noteDuration);
// to distinguish the notes, set a minimum time between them.
// the note's duration + 30% seems to work well:
unsigned long pauseBetweenNotes = noteDuration * 1.30;
if (currentMillis - previousMelodyMillis >= pauseBetweenNotes) {
previousMelodyMillis = currentMillis;
noTone(buzzerPin);
}
}
}
}
// make buzzer play note
void buzzer(int targetPin, long frequency, long length) {
if(buttonState == LOW){
digitalWrite(buzzerPin, HIGH);
long delayValue = 1000 / frequency / 2; // calculate the delay value between transitions
unsigned long previousMillis2 = 0;
//// 1 second's worth of microseconds, divided by the frequency, then split in half since
//// there are two phases to each cycle
long numCycles = frequency * length / 1000; // calculate the number of cycles for proper timing
//// multiply frequency, which is really cycles per second, by the number of seconds to
//// get the total number of cycles to produce
for (long i = 0; i < numCycles; i++) { // for the calculated length of time...
if(currentMillis - previousMillis2>= delayValue){
previousMillis2 = currentMillis;
digitalWrite(targetPin, HIGH); // write the buzzer pin high to push out the diaphram
}
if(currentMillis - previousMillis2>= delayValue){
previousMillis2 = currentMillis;
digitalWrite(targetPin, LOW); // write the buzzer pin high to push out the diaphram
}
}
digitalWrite(buzzerPin, LOW);
}
}
I'm stuck now. The code compiles but when I try it out it just does nothing close to what I want (turn white leds on for 2s then red for 2 then white for 2 then red for 2 then all for 2 repeat, and play the song at the same time once the button is pressed)
I stole the song from someone else but I feel this might be what is destroying the code. I'll have to write the song myself just using the tone function for simplicitys sake
does someone see what I did wrong here?