OneButton click to change functions

porosis · February 9, 2021, 1:11am

I'm using an Arduino Nano with a breadboard and a Gikfun tactile momentary push button with 10k resistor added. I was able to get the pushbutton to work with sample OneButton library examples and am trying to alter the sample code to work for my situation. I'm also using the FastLED library that currently works for my outdoor LED lights.

I want to cycle through LED pattern functions with a single click on the button. I eventually want to add more features to the program, but can't seem to crack my current problem.

I think I probably am having issues with my selection of ReturnTypes? Either way, I've tried to get it to Print the running function name, but it continues to Print "Off".

porosis · February 9, 2021, 1:17am

I must have done something wrong to post my code. I'm using the Web editor and thought it would share my code in a frame, but I failed. I added a link but for the future I'd like to post the code as others have, any ideas what I did wrong here?

Railroader · February 9, 2021, 1:43am

The best result is when You start in the Arduino IDE by using the "Autoformat', or Ctrl + T. Then mark and copy the code.
In this windiw, the Quick Reply, there is a symbol up to the left. Click on that and then paste the code.

Fine You do try!
.

porosis · February 9, 2021, 1:46am

Let's try this for my code:

#include "OneButton.h"
#include "FastLED.h"
#define LED_PIN 2
#define BTN_PIN A1
#define NUM_LEDS 170
#define Color1 CRGB::Red;
#define Color2 CRGB::Green;
#define Color3 CRGB::Yellow;
#define Color4 CRGB::Pink;
#define Color5 CRGB::LimeGreen;
#define Color6 CRGB::White;
#define Color7 CRGB::Navy;
#define Color8 CRGB::Orange;
#define Color9 CRGB::Brown;
#define Color10 CRGB::Black;

CRGB leds[NUM_LEDS];

// The function I can do...
typedef enum {
  ACTION_OFF,
  CHRISTMAS,
  SUPERBOWL_CHIEFS,
  SUPERBOWL_BRONCOS,
  VALENTINE
}
  
MyActions;
  
void Christmas();   
void Superbowl_Chiefs(); 
void Superbowl_Broncos();  
void Valentine();



// Setup a new OneButton on pin A1.  
OneButton button(A1, true);

MyActions nextPattern = ACTION_OFF; // no action when starting


// setup code here, to run once.
void setup() {
    // link the myClickFunction function to be called on a click event.   
  button.attachClick(myClickFunction);

  // set 80 msec. debouncing time. Default is 50 msec.
  button.setDebounceTicks(80);
  Serial.begin(9600);
  
  FastLED.addLeds<WS2812B, LED_PIN, GRB>(leds, NUM_LEDS);
  FastLED.setBrightness(255);
  FastLED.setCorrection(TypicalSMD5050);
  FastLED.clear();
} // setup


// main code here, to run repeatedly: 
void loop() {

  // keep watching the push button:
  button.tick();

  if (nextPattern == ACTION_OFF) {
    // do nothing.
    Serial.println("Off");
    delay(1000);
    
  } else if (nextPattern == CHRISTMAS) {
      Christmas();
      Serial.println("CHRISTMAS");
      delay(1000);
    
  } else if (nextPattern == SUPERBOWL_CHIEFS) {
      Superbowl_Chiefs();
      Serial.println("SUPERBOWL_CHIEFS");
      delay(1000);
      
  } else if (nextPattern == SUPERBOWL_BRONCOS) {
      Superbowl_Broncos();
      Serial.println("SUPERBOWL_BRONCOS");
      delay(1000);
      
  } else if (nextPattern == VALENTINE); {
      Valentine();
      Serial.println("VALENTINE");
      delay(1000);
  } 
    
} // loop


// this function will be called when the button was pressed 1 time and them some time has passed.
String myClickFunction() {
  if (nextPattern == ACTION_OFF)
    nextPattern = CHRISTMAS;
  else if (nextPattern == CHRISTMAS)
    nextPattern = SUPERBOWL_CHIEFS;
  else if (nextPattern == SUPERBOWL_CHIEFS)
    nextPattern = SUPERBOWL_BRONCOS;
  else if (nextPattern == SUPERBOWL_BRONCOS)
    nextPattern = VALENTINE;
  else if (nextPattern == VALENTINE)
    nextPattern = ACTION_OFF;
} // myClickFunction

//Functions to cycle with button click
void Christmas() {
  for (int i = 0; i < NUM_LEDS; i += 20) {
      leds[i] = Color1;
      leds[i + 1] = Color1;
      leds[i + 2] = Color1;
      leds[i + 3] = Color1;
      leds[i + 4] = Color1;
      leds[i + 5] = Color10;
      leds[i + 6] = Color10;
      leds[i + 7] = Color10;
      leds[i + 8] = Color10;
      leds[i + 9] = Color10;
      leds[i + 10] = Color2;
      leds[i + 11] = Color2;
      leds[i + 12] = Color2;
      leds[i + 13] = Color2;
      leds[i + 14] = Color2;
      leds[i + 15] = Color10;
      leds[i + 16] = Color10;
      leds[i + 17] = Color10;
      leds[i + 18] = Color10;
      leds[i + 19] = Color10;
      FastLED.show();
      Serial.println("CHRISTMAS Running");
      delay(1000);
      }
}


void Superbowl_Chiefs() {
  for (int i = 0; i < NUM_LEDS; i += 20) {
      leds[i] = Color1;
      leds[i + 1] = Color1;
      leds[i + 2] = Color1;
      leds[i + 3] = Color1;
      leds[i + 4] = Color1;
      leds[i + 5] = Color10;
      leds[i + 6] = Color10;
      leds[i + 7] = Color10;
      leds[i + 8] = Color10;
      leds[i + 9] = Color10;
      leds[i + 10] = Color3;
      leds[i + 11] = Color3;
      leds[i + 12] = Color3;
      leds[i + 13] = Color3;
      leds[i + 14] = Color3;
      leds[i + 15] = Color10;
      leds[i + 16] = Color10;
      leds[i + 17] = Color10;
      leds[i + 18] = Color10;
      leds[i + 19] = Color10;
      FastLED.show();
      }
}


void Superbowl_Broncos() {
  for (int i = 0; i < NUM_LEDS; i += 20) {
      leds[i] = Color1;
      leds[i + 1] = Color1;
      leds[i + 2] = Color1;
      leds[i + 3] = Color1;
      leds[i + 4] = Color1;
      leds[i + 5] = Color10;
      leds[i + 6] = Color10;
      leds[i + 7] = Color10;
      leds[i + 8] = Color10;
      leds[i + 9] = Color10;
      leds[i + 10] = Color7;
      leds[i + 11] = Color7;
      leds[i + 12] = Color7;
      leds[i + 13] = Color7;
      leds[i + 14] = Color7;
      leds[i + 15] = Color10;
      leds[i + 16] = Color10;
      leds[i + 17] = Color10;
      leds[i + 18] = Color10;
      leds[i + 19] = Color10;
      FastLED.show();
      }
}


void Valentine() {
  for (int i = 0; i < NUM_LEDS; i += 20) {
      leds[i] = Color1;
      leds[i + 1] = Color1;
      leds[i + 2] = Color1;
      leds[i + 3] = Color1;
      leds[i + 4] = Color1;
      leds[i + 5] = Color6;
      leds[i + 6] = Color6;
      leds[i + 7] = Color6;
      leds[i + 8] = Color6;
      leds[i + 9] = Color6;
      leds[i + 10] = Color4;
      leds[i + 11] = Color4;
      leds[i + 12] = Color4;
      leds[i + 13] = Color4;
      leds[i + 14] = Color4;
      leds[i + 15] = Color6;
      leds[i + 16] = Color6;
      leds[i + 17] = Color6;
      leds[i + 18] = Color6;
      leds[i + 19] = Color6;
      FastLED.show();
      }
}


// End

Railroader · February 9, 2021, 1:55am

Bingo!
Be careful, rather, awoid using strings. The carbage collection is poor in this environment.
What works and what does not?

porosis · February 9, 2021, 2:28am

At the moment, I'm trying to get the Serial Monitor to cycle between Off, Christmas, Superbowl_Chiefs, Superbowl_Broncos, and Valentines changing on to the next with each button click. That should, then, select a different color pattern based on the like named function.

Railroader · February 9, 2021, 2:33am

Good. Keep on working until it works.

porosis · February 9, 2021, 3:52pm

We still haven't had any suggestions on how to fix my button click not running the functions that I have set up.

dougp · February 9, 2021, 7:27pm

First, debounce the switch - there are myriad threads on this and an example in IDE-> file/examples/digital. Take the debounced switch state (boolean) and feed it to a bit of code which senses a change of state (example in same place in IDE). Take the state change, also boolean, and increment a counter. Reset the counter when it's past the last pattern. Use the counter value to a: select from an array; select one of 'n' in a switch/case construct.

This recent tutorial may be of some use - timer counter state change toggle FSM tutorial

Railroader · February 9, 2021, 7:45pm

porosis:
We still haven't had any suggestions on how to fix my button click not running the functions that I have set up.

You have not answered reply #4. We are waiting.....

porosis · February 10, 2021, 12:02am

The switch is debounced within OneButton and I've extended from 50 to 80 ms within the setup.

Pushing the button does not cycle the println from off to Christams to Superbowl_Chiefs to Superbowl_Broncos to Valentine to indicate which function is active. It continuously prints "off" indefinitely.

The myClickFunction function should be changing the serial monitor output above through the nextPattern value. It will not change. This is standard programming from the OneButton library samples that I've tried to change to work. It is not and I'm not sure why.

Railroader · February 10, 2021, 6:55pm

Now using IDE in a Pc, I say: No surprice things go wrong. Look a collection of code lines:

#define NUM_LEDS 170
.
.
CRGB leds[NUM_LEDS];
.
.

  for (int i = 0; i < NUM_LEDS; i += 20) {
    leds[i] = Color1;
    leds[i + 1] = Color1;
    leds[i + 2] = Color1;
    leds[i + 3] = Color1;
    leds[i + 4] = Color1;
    leds[i + 5] = Color10;
    leds[i + 6] = Color10;
    leds[i + 7] = Color10;
    leds[i + 8] = Color10;
    leds[i + 9] = Color10;
    leds[i + 10] = Color2;
    leds[i + 11] = Color2;
    leds[i + 12] = Color2;
    leds[i + 13] = Color2;
    leds[i + 14] = Color2;
    leds[i + 15] = Color10;
    leds[i + 16] = Color10;
    leds[i + 17] = Color10;
    leds[i + 18] = Color10;
    leds[i + 19] = Color10;[b]Indexed 169 + 19, way outside the array./b]

You are writing data 19 byte/int.. beyond the limit of the array. That means that You crasch totaly 19 unknown data......

porosis · February 10, 2021, 8:37pm

The lighting functions are working just fine on their own. My problem, once again, is that trying to set the button to cycle between these lighting functions does not seem to be working.

Railroader · February 10, 2021, 8:42pm

porosis:
The lighting functions are working just fine on their own. My problem, once again, is that trying to set the button to cycle between these lighting functions does not seem to be working.

Your code runs like a lunartic in the memory, as I see it.
That gives unpredictable execution disturbance. It's fully possible that the code You show ruins the stack, other variables like the button variable for example.

Correct the way Your code access the arrays. Until then, all other work is useless.

porosis · February 10, 2021, 11:01pm

Okay, to bypass the lunatic run I've commented out the LED functions. Now it start (in the serial monitor) with alternating "off" and "Valentine", when I press the button it then prints "Valentine" and "Christmas", another press prints "Valentine" and "Superbowl_Chiefs". What in the code is making it insert "Valentine" in there before nextPattern is set to VALENTINE on the forth button press? On the forth press it prints "Valentine" and "Valentine"

Revised code:

#include "OneButton.h"
#include "FastLED.h"
#define LED_PIN 2
#define BTN_PIN A1
#define NUM_LEDS 170
#define Color1 CRGB::Red;
#define Color2 CRGB::Green;
#define Color3 CRGB::Yellow;
#define Color4 CRGB::Pink;
#define Color5 CRGB::LimeGreen;
#define Color6 CRGB::White;
#define Color7 CRGB::Navy;
#define Color8 CRGB::Orange;
#define Color9 CRGB::Brown;
#define Color10 CRGB::Black;

CRGB leds[NUM_LEDS];

// The function I can do...
typedef enum {
  ACTION_OFF,
  CHRISTMAS,
  SUPERBOWL_CHIEFS,
  SUPERBOWL_BRONCOS,
  VALENTINE
}
  
MyActions;
  
void Christmas();   
void Superbowl_Chiefs(); 
void Superbowl_Broncos();  
void Valentine();



// Setup a new OneButton on pin A1.  
OneButton button(A1, true);

MyActions nextPattern = ACTION_OFF; // no action when starting


// setup code here, to run once.
void setup() {
    // link the myClickFunction function to be called on a click event.   
  button.attachClick(myClickFunction);

  // set 80 msec. debouncing time. Default is 50 msec.
  button.setDebounceTicks(80);
  Serial.begin(9600);
  
  FastLED.addLeds<WS2812B, LED_PIN, GRB>(leds, NUM_LEDS);
  FastLED.setBrightness(255);
  FastLED.setCorrection(TypicalSMD5050);
  FastLED.clear();
} // setup


// main code here, to run repeatedly: 
void loop() {

  // keep watching the push button:
  button.tick();

  if (nextPattern == ACTION_OFF) {
    // do nothing.
    Serial.println("Off");
    delay(1000);
    
  } else if (nextPattern == CHRISTMAS) {
      Christmas();
      Serial.println("CHRISTMAS");
      delay(1000);
    
  } else if (nextPattern == SUPERBOWL_CHIEFS) {
      Superbowl_Chiefs();
      Serial.println("SUPERBOWL_CHIEFS");
      delay(1000);
      
  } else if (nextPattern == SUPERBOWL_BRONCOS) {
      Superbowl_Broncos();
      Serial.println("SUPERBOWL_BRONCOS");
      delay(1000);
      
  } else if (nextPattern == VALENTINE); {
      Valentine();
      Serial.println("VALENTINE");
      delay(1000);
  } 
    
} // loop


// this function will be called when the button was pressed 1 time and them some time has passed.
uint8_t myClickFunction() {
  if (nextPattern == ACTION_OFF)
    nextPattern = CHRISTMAS;
  else if (nextPattern == CHRISTMAS)
    nextPattern = SUPERBOWL_CHIEFS;
  else if (nextPattern == SUPERBOWL_CHIEFS)
    nextPattern = SUPERBOWL_BRONCOS;
  else if (nextPattern == SUPERBOWL_BRONCOS)
    nextPattern = VALENTINE;
  else if (nextPattern == VALENTINE)
    nextPattern = ACTION_OFF;
} // myClickFunction

//Functions to cycle with button click
void Christmas() {
//   for (int i = 0; i < NUM_LEDS; i += 20) {
//       leds[i] = Color1;
//       leds[i + 1] = Color1;
//       leds[i + 2] = Color1;
//       leds[i + 3] = Color1;
//       leds[i + 4] = Color1;
//       leds[i + 5] = Color10;
//       leds[i + 6] = Color10;
//       leds[i + 7] = Color10;
//       leds[i + 8] = Color10;
//       leds[i + 9] = Color10;
//       leds[i + 10] = Color2;
//       leds[i + 11] = Color2;
//       leds[i + 12] = Color2;
//       leds[i + 13] = Color2;
//       leds[i + 14] = Color2;
//       leds[i + 15] = Color10;
//       leds[i + 16] = Color10;
//       leds[i + 17] = Color10;
//       leds[i + 18] = Color10;
//       leds[i + 19] = Color10;
//       FastLED.show();
//       Serial.println("CHRISTMAS Running");
//       delay(1000);
//       }
}


void Superbowl_Chiefs() {
//   for (int i = 0; i < NUM_LEDS; i += 20) {
//       leds[i] = Color1;
//       leds[i + 1] = Color1;
//       leds[i + 2] = Color1;
//       leds[i + 3] = Color1;
//       leds[i + 4] = Color1;
//       leds[i + 5] = Color10;
//       leds[i + 6] = Color10;
//       leds[i + 7] = Color10;
//       leds[i + 8] = Color10;
//       leds[i + 9] = Color10;
//       leds[i + 10] = Color3;
//       leds[i + 11] = Color3;
//       leds[i + 12] = Color3;
//       leds[i + 13] = Color3;
//       leds[i + 14] = Color3;
//       leds[i + 15] = Color10;
//       leds[i + 16] = Color10;
//       leds[i + 17] = Color10;
//       leds[i + 18] = Color10;
//       leds[i + 19] = Color10;
//       FastLED.show();
//       }
}


void Superbowl_Broncos() {
//   for (int i = 0; i < NUM_LEDS; i += 20) {
//       leds[i] = Color1;
//       leds[i + 1] = Color1;
//       leds[i + 2] = Color1;
//       leds[i + 3] = Color1;
//       leds[i + 4] = Color1;
//       leds[i + 5] = Color10;
//       leds[i + 6] = Color10;
//       leds[i + 7] = Color10;
//       leds[i + 8] = Color10;
//       leds[i + 9] = Color10;
//       leds[i + 10] = Color7;
//       leds[i + 11] = Color7;
//       leds[i + 12] = Color7;
//       leds[i + 13] = Color7;
//       leds[i + 14] = Color7;
//       leds[i + 15] = Color10;
//       leds[i + 16] = Color10;
//       leds[i + 17] = Color10;
//       leds[i + 18] = Color10;
//       leds[i + 19] = Color10;
//       FastLED.show();
//       }
}


void Valentine() {
//   for (int i = 0; i < NUM_LEDS; i += 20) {
//       leds[i] = Color1;
//       leds[i + 1] = Color1;
//       leds[i + 2] = Color1;
//       leds[i + 3] = Color1;
//       leds[i + 4] = Color1;
//       leds[i + 5] = Color6;
//       leds[i + 6] = Color6;
//       leds[i + 7] = Color6;
//       leds[i + 8] = Color6;
//       leds[i + 9] = Color6;
//       leds[i + 10] = Color4;
//       leds[i + 11] = Color4;
//       leds[i + 12] = Color4;
//       leds[i + 13] = Color4;
//       leds[i + 14] = Color4;
//       leds[i + 15] = Color6;
//       leds[i + 16] = Color6;
//       leds[i + 17] = Color6;
//       leds[i + 18] = Color6;
//       leds[i + 19] = Color6;
//       FastLED.show();
//       }
}


// End

PaulRB · February 10, 2021, 11:41pm

} else if (nextPattern == VALENTINE); {

Semi-colon on this line.

Railroader · February 10, 2021, 11:49pm

Can You post a copy of Serial Monitor?
I don't understand what You tell about the printouts. Printing "this" and that. What do You mean by the "and"? I don't find how in the code.
Each printout is a .println, printing one text on one line, "Off", "CHRISTMAS", "SUPERBOWL_CHIEFS", "SUPERBOWL_BRONCOS" or "VALENTINE".

Would You need the action "Off" in the code below? I don't see how the definition of enums is connected to myClickFunction.

typedef enum {
  ACTION_OFF,
  CHRISTMAS,
  SUPERBOWL_CHIEFS,
  SUPERBOWL_BRONCOS,
  VALENTINE
}

MyActions;

void Christmas();
void Superbowl_Chiefs();
void Superbowl_Broncos();
void Valentine();

Railroader · February 10, 2021, 11:50pm

PaulRB:
} else if (nextPattern == VALENTINE); {
Semi-colon on this line.

You really have the sharp eye engaged. However, the brutal access to the arrays still needs consideration.

porosis · February 10, 2021, 11:59pm

I tried commenting out the typedef enum lines and the compiler tells me that the Actions are not defined in the scope. Could I save a lot of the confusion by assigning int for these actions?

As far as the LED patterns; this is the only way I've found to run a repeating pattern to my LED string lights so far, any suggestions on how to limit the data confusion for these?

PaulRB · February 11, 2021, 12:09am

Maybe like this:

void Christmas() {
   for (int i = 0; i < NUM_LEDS; i += 20) {
       leds[i] = Color1;
       leds[i + 1] = Color1;
       leds[i + 2] = Color1;
       leds[i + 3] = Color1;
       leds[i + 4] = Color1;
       leds[i + 5] = Color10;
       leds[i + 6] = Color10;
       leds[i + 7] = Color10;
       leds[i + 8] = Color10;
       leds[i + 9] = Color10;
	   if (i < NUM_LEDS - 10) {
		   leds[i + 10] = Color2;
		   leds[i + 11] = Color2;
		   leds[i + 12] = Color2;
		   leds[i + 13] = Color2;
		   leds[i + 14] = Color2;
		   leds[i + 15] = Color10;
		   leds[i + 16] = Color10;
		   leds[i + 17] = Color10;
		   leds[i + 18] = Color10;
		   leds[i + 19] = Color10;
		   }
       FastLED.show();
       Serial.println("CHRISTMAS Running");
       delay(1000);
       }
}

Topic		Replies	Views
OneButton library help Programming	48	26682	May 5, 2021
Change to next code with the help of a button Programming	11	1131	May 5, 2021
Need help with code for the OneButton.h library Programming	4	917	March 30, 2023
Adding double click to my program Programming	5	53	December 31, 2024
Control LED Strip functions using SINGLE Push Button Help! LEDs and Multiplexing	6	1010	May 6, 2021

OneButton click to change functions

Related topics