Please help some basic switch code not working?

Is the OP's name meant to be ironic? No indentation and strange use of white space, doesn't seem tidy to me.