POV LED-ARDUINO UNO-HELP

Using Arduino LEDs and Multiplexing
#1

hello, I’m trying to make a LED POV, I try to draw a circle, but this
never closes. that I can be doing wrong?

Thank you!

volatile long timeold;
volatile unsigned long new_time = 0;
volatile float refreshEnd = 0;
volatile  float Refresh = 0;
volatile float milliperrevolution = 0;

volatile uint8_t revolutions=0;
volatile boolean interruptHit = false;
void setup() {
 pinMode(2, INPUT); // 
  attachInterrupt(0, rpm, FALLING);//    attachInterrupt(0, rpm, FALLING) pin 2 Arduino----     : hall sensor
 pinMode(13, OUTPUT);     
 digitalWrite(13, 0);   // set the LED off
}

void loop() {
  if( interruptHit ==true){
      digitalWrite(13, HIGH);   // set the LED 
    new_time = millis();
    refreshEnd=new_time;
    while((millis() - refreshEnd)<= (Refresh  ) ) {;}
  
               interruptHit =false;
  }else{
        digitalWrite(13, LOW);   // set the LED 

  
  }  
}


void rpm(){
 revolutions++;
 interruptHit=true;
 


     
  
 if (revolutions == 2)                                     // RPM gets updated for every two complete rotations
    {
     new_time=millis();
      milliperrevolution = (( new_time - timeold)/2);
      
      timeold =  new_time;
      revolutions = 0;
      Refresh = milliperrevolution/1;  
    }
 
 
}
#2

Did you mean to increment 'revolutions' twice in rpm()?

You should not be using 'float' values for millisecond counters. They should all be unsigned long.

#3

johnwasser:
Did you mean to increment 'revolutions' twice in rpm()?

You should not be using 'float' values for millisecond counters. They should all be unsigned long.

I take the average of two revolutions, this time is to paint a complete turn, a circle. but not completely painted, the circle is always open. means?

#4