Short description:
When I press the right button, it skips over the middle LED - most of the time - sometimes even when I press the left button. Soft press at the right: skip (90%), hard press at left: normal (70%).
Scroll down for picture and code. (Skip the "Long description if you don't want to waste time.)
Long description:
I have come to a new problem in my programming, or maybe it's the circuit that screws things up.
Everything works as intended, but not perfect when it comes to the buttons. What seems to happen is that when I press one of the buttons, it may skip over the middle LED - but mostly when I press the button hard... When I press softly, it may work as it should. What's making me confused, is that the left button rarely skips the middle LED, I have to press it hard to make it work, but when it comes to the right button, it skips most of the time.
Circuit:
Click for image
"Hints": Did I use wrong type of resistors for the buttons?
Since it sends "high - low - high" (it gets two presses, at least), I can only imagine some circuit fail somewhere.
Main program:
// Variables
const int LED1 = 13; // Left LED
const int LED2 = 12; // Middle LED
const int LED3 = 11; // Right LED
const int bLeft = 10; // Left button
const int bRight = 9; // Right Button
short int playerX = 1; // This is for the movement of the LED (set to start in the middle)
int milli = 0; // Milliseconds counter
int sec = 0; // Second counter
int curTime = millis(); // Check the current millisecond
int prevTime = 0; // Check if curTime changes, then increase "mill"
#include <Nfunctions.h> // Our own function header
void setup()
{
pinMode(LED1, OUTPUT); // Left LED
pinMode(LED2, OUTPUT); // Middle LED
pinMode(LED3, OUTPUT); // Right LED
pinMode(bLeft, INPUT); // Left button
pinMode(bRight, INPUT); // Right button
checkLED(); // Lit up the middle LED at the start-up
Serial.begin(9600); // This is used to print "sec" to the Serial Monitor
}
void loop()
{
movement();
}
Nfunctions.h:
#ifndef NFUNCTIONS_H
#define NFUNCTIONS_H
// Check which LED should be lit
void checkLED()
{
playerX = constrain(playerX,0,2);
digitalWrite(LED1, playerX == 0); digitalWrite(LED2, playerX == 1); digitalWrite(LED3, playerX == 2);
}
//Time check
void checkTime()
{
curTime = millis();
if(milli >= 975) { milli = 0; sec++; Serial.println(sec); }
if(prevTime != curTime) { prevTime = curTime; milli++; }
}
// The controls
void checkButton (int bDir)
{
if (digitalRead(bDir) == HIGH)
{
if(bDir == bRight) { playerX++; } else { playerX--; }
checkLED(); // Update player's LED
// Don't check for further presdown until button is released
while (digitalRead(bDir) == HIGH) { checkTime(); }
}
checkTime();
}
// The movement
void movement()
{
checkButton(bRight);
checkButton(bLeft);
}
#endif
I over-commented just so you could follow easily.
I also want to inform you that the counting is vital for further programming - when I set up the "screen" with moving LEDs, without using "delay()".