Problem with void function

In what way does it not work, exactly?