Pulse Sensor Amped Code

I received the following error message when I tried to upload the Pulse Sensor Amped code from this website (https://github.com/WorldFamousElectronics/PulseSensor_Amped_Arduino/blob/master/PulseSensorAmped_Arduino_1dot4/Interrupt.ino) to my Arduino Uno:

Arduino: 1.6.7 (Windows 7), Board: "Arduino/Genuino Uno"

C:\Users\Owner\Documents\Arduino\ISR_PulseSensor\ISR_PulseSensor.ino: In function 'void setup()':

ISR_PulseSensor:24: error: a function-definition is not allowed here before '{' token

void interruptSetup(){

^

In file included from C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino/Arduino.h:30:0,

from sketch\ISR_PulseSensor.ino.cpp:1:

ISR_PulseSensor:36: error: expected unqualified-id before string constant

ISR(TIMER2_COMPA_vect){ // triggered when Timer2 counts to 124

^

ISR_PulseSensor:36: error: a function-definition is not allowed here before '{' token

ISR(TIMER2_COMPA_vect){ // triggered when Timer2 counts to 124

^

ISR_PulseSensor:117: error: expected '}' at end of input

}

^

exit status 1

a function-definition is not allowed here before '{' token

This report would have more information with

"Show verbose output during compilation"

enabled in File > Preferences.


This line of code was highlighted:

ISR(TIMER2_COMPA_vect){ // triggered when Timer2 counts to 124


Here is the code in its entirety:

int pulsePin = 0;

int blinkPin = 13;

volatile int rate[10]; // array to hold last ten IBI values

volatile unsigned long sampleCounter = 0; // used to determine pulse timing

volatile unsigned long lastBeatTime = 0; // used to find IBI

volatile int P =512; // used to find peak in pulse wave, seeded

volatile int T = 512; // used to find trough in pulse wave, seeded

volatile int thresh = 525; // used to find instant moment of heart beat, seeded

volatile int amp = 100; // used to hold amplitude of pulse waveform, seeded

volatile boolean firstBeat = true; // used to seed rate array so we startup with reasonable BPM

volatile boolean secondBeat = false; // used to seed rate array so we startup with reasonable BPM

volatile int BPM;

volatile int Signal;

volatile int IBI = 600;

volatile boolean Pulse = false;

volatile boolean QS = false;

void setup(){

pinMode(13,OUTPUT);

void interruptSetup(){

// Initializes Timer2 to throw an interrupt every 2mS. (CTC mode: clear Timer on compare match)

TCCR2A = 0x02; // DISABLE PWM ON DIGITAL PINS 3 AND 11, AND GO INTO CTC MODE (Timer/Counter Control Register: the prescaler can be configured here)

TCCR2B = 0x06; // DON'T FORCE COMPARE, 256 PRESCALER (Timer/Counter Control Register: the prescaler can be configued here)

OCR2A = 0X7C; // SET THE TOP OF THE COUNT TO 124 FOR 500Hz SAMPLE RATE (Output Compare Register: Timer2 output compare register A)

TIMSK2 = 0x02; // ENABLE INTERRUPT ON MATCH BETWEEN TIMER2 AND OCR2A (Timer1/Counter Interrupt Mask Register: to enable/disable timer interrupts)

sei(); // MAKE SURE GLOBAL INTERRUPTS ARE ENABLED

}

// THIS IS THE TIMER 2 INTERRUPT SERVICE ROUTINE.

// Timer 2 makes sure that we take a reading every 2 miliseconds

ISR(TIMER2_COMPA_vect){ // triggered when Timer2 counts to 124

cli(); // disable interrupts while we do this

Signal = analogRead(pulsePin); // read the Pulse Sensor

sampleCounter += 2; // keep track of the time in mS with this variable

int N = sampleCounter - lastBeatTime; // monitor the time since the last beat to avoid noise

// find the peak and trough of the pulse wave

if(Signal < thresh && N > (IBI/5)*3){ // avoid dichrotic noise by waiting 3/5 of last IBI

if (Signal < T){ // T is the trough

T = Signal; // keep track of lowest point in pulse wave

}

}

if(Signal > thresh && Signal > P){ // thresh condition helps avoid noise

P = Signal; // P is the peak

} // keep track of highest point in pulse wave

// NOW IT'S TIME TO LOOK FOR THE HEART BEAT

// signal surges up in value every time there is a pulse

if (N > 250){ // avoid high frequency noise

if ( (Signal > thresh) && (Pulse == false) && (N > (IBI/5)*3) ){

Pulse = true; // set the Pulse flag when we think there is a pulse

digitalWrite(blinkPin,HIGH); // turn on pin 13 LED

IBI = sampleCounter - lastBeatTime; // measure time between beats in mS

lastBeatTime = sampleCounter; // keep track of time for next pulse

if(secondBeat){ // if this is the second beat, if secondBeat == TRUE

secondBeat = false; // clear secondBeat flag

for(int i=0; i<=9; i++){ // seed the running total to get a realisitic BPM at startup

rate = IBI;

}

}

if(firstBeat){ // if it's the first time we found a beat, if firstBeat == TRUE

firstBeat = false; // clear firstBeat flag

secondBeat = true; // set the second beat flag

sei(); // enable interrupts again

return; // IBI value is unreliable so discard it

}

// keep a running total of the last 10 IBI values

word runningTotal = 0; // clear the runningTotal variable

for(int i=0; i<=8; i++){ // shift data in the rate array

rate = rate[i+1]; // and drop the oldest IBI value

runningTotal += rate; // add up the 9 oldest IBI values

}

rate[9] = IBI; // add the latest IBI to the rate array

runningTotal += rate[9]; // add the latest IBI to runningTotal

runningTotal /= 10; // average the last 10 IBI values

BPM = 60000/runningTotal; // how many beats can fit into a minute? that's BPM!

QS = true; // set Quantified Self flag

// QS FLAG IS NOT CLEARED INSIDE THIS ISR

}

}

if (Signal < thresh && Pulse == true){ // when the values are going down, the beat is over

digitalWrite(blinkPin,LOW); // turn off pin 13 LED

Pulse = false; // reset the Pulse flag so we can do it again

amp = P - T; // get amplitude of the pulse wave

thresh = amp/2 + T; // set thresh at 50% of the amplitude

P = thresh; // reset these for next time

T = thresh;

}

if (N > 2500){ // if 2.5 seconds go by without a beat

thresh = 512; // set thresh default

P = 512; // set P default

T = 512; // set T default

lastBeatTime = sampleCounter; // bring the lastBeatTime up to date

firstBeat = true; // set these to avoid noise

secondBeat = false; // when we get the heartbeat back

}

sei(); // enable interrupts when youre done!

}// end isr

void loop (){

}

}


Right now, I am just trying to get the pin 13 LED to blink in accordance with my heart beat. Once I am able to do that, then I will manipulate some of the volatile variables in my loop() function. Any advice that anyone could offer as to what the problem is would be greatly appreciated. I have posted in the pulsesensor.com website, but I am unfortunately getting no replies.

void setup(){

pinMode(13,OUTPUT);





void interruptSetup(){

You can not define a function (interruptSetup()) in a function (setup()).
That is the 1st thing you must resolve.

BryAB:
I received the following error message when I tried to upload the Pulse Sensor Amped code from this website (https://github.com/WorldFamousElectronics/PulseSensor_Amped_Arduino/blob/master/PulseSensorAmped_Arduino_1dot4/Interrupt.ino) to my Arduino Uno:

Arduino: 1.6.7 (Windows 7), Board: "Arduino/Genuino Uno"
C:\Users\Owner\Documents\Arduino\ISR_PulseSensor\ISR_PulseSensor.ino: In function 'void setup()':

That project has no "ISR_PulseSensor.ino" file. The four files in the project are:
Arduino/PulseSensorAmped_Arduino_1dot4/Timer_Interrupt_Notes.ino
Arduino/PulseSensorAmped_Arduino_1dot4/Interrupt.ino
Arduino/PulseSensorAmped_Arduino_1dot4/PulseSensorAmped_Arduino_1dot4.inof
Arduino/PulseSensorAmped_Arduino_1dot4/AllSerialHandling.ino

The project compiles fine for me. Where did the "ISR_PulseSensor.ino" come from?

You are right; it does compile; I failed to include the other files that you specified. Because of my own inexperience, I thought that I could just use the "Interrupt.ino" file, and then write my own loop() function (to print BPM values). Boy was I wrong! I apologize for my ignorance. I am new to much of this.

Thanks for your help! It means a lot to me.

BryAB:
You are right; it does compile; I failed to include the other files that you specified. Because of my own inexperience, I thought that I could just use the "Interrupt.ino" file, and then write my own loop() function (to print BPM values). Boy was I wrong! I apologize for my ignorance. I am new to much of this.

Thanks for your help! It means a lot to me.

No problem. I was surprised, myself, to find that those four .ino files were one sketch. Usually that's only done with very large sketches.