Pump Turn on Code Help

Other Hardware Motors, Mechanics, Power and CNC
1

I'm completely new with coding and programming. I know this is a super simple task, but I am having trouble with it. The goal is to have 1 button turn on 2 pumps at the same time for a set number of seconds for each pump. This is what I have so far and i'm wondering if anyone can check to see if it looks alright. All help and CONSTRUCTIVE criticism is appropriated. Thanks

//define the input/output pins
//pump/relay pins
#define PUMP_1_PIN 7
#define PUMP_2_PIN 8

//pushbutton pin
#define BUTTON_1_PIN 2

//Time for pumps to turn on in milliseconds
#define PUMP_1_TIME 2500
#define PUMP_2_TIME 5000

//setup() runs once
void setup()
{
//setup output pins for relays/pumps
pinMode(PUMP_1_PIN, OUTPUT);
pinMode(PUMP_2_PIN, OUTPUT);

//setup input pins for button
pinMode(BUTTON_1_PIN, INPUT);
}

//loop() runs indefinitely
void loop()
{
//check pushbutton on pin BUTTON_1_PIN to see if it is HIGH
if(digitalRead(BUTTON_1_PIN) == HIGH)
{
digitalWrite(PUMP_1_PIN, HIGH); //turn pump 1 on
delay(PUMP_1_TIME); //wait PUMP_1_TIME milliseconds
digitalWrite(PUMP_1_PIN, LOW); //turn pump 1 off
}

//check pushbutton on pin BUTTON_1_PIN to see if it is HIGH
if(digitalRead(BUTTON_1_PIN) == HIGH)
{
digitalWrite(PUMP_2_PIN, HIGH); //turn pump 2 on
delay(PUMP_2_TIME); //wait PUMP_2_TIME milliseconds
digitalWrite(PUMP_2_PIN, LOW); //turn pump 2 off
}
}

2 
delay(PUMP_1_TIME);             //wait PUMP_1_TIME milliseconds

That will prevent pump2 turning ON until pump1 has timed out and turned OFF. Do you have a pulldown resistor (10k) connected from pin 2 to GND so the pin is not "floating" when the button is not pressed and causing false HIGHs?
Compiles but UNTESTED!

//define the input/output pins
//pump/relay pins
#define PUMP_1_PIN 7
#define PUMP_2_PIN 8

//pushbutton pin
#define BUTTON_1_PIN 2

//Time for pumps to turn on in milliseconds
#define PUMP_1_TIME 2500
#define PUMP_2_TIME 2500

//setup() runs once
void setup()
{
  //setup output pins for relays/pumps
  pinMode(PUMP_1_PIN, OUTPUT);
  pinMode(PUMP_2_PIN, OUTPUT);
 
  //setup input pins for button
  pinMode(BUTTON_1_PIN, INPUT);
}

//loop() runs indefinitely
void loop()
{
  //check pushbutton on pin BUTTON_1_PIN to see if it is HIGH
  if(digitalRead(BUTTON_1_PIN) == HIGH)
  {
     digitalWrite(PUMP_1_PIN, HIGH); //turn pump 1 on
     digitalWrite(PUMP_2_PIN, HIGH); //turn pump 2 on
     delay(PUMP_1_TIME);             //wait PUMP_1_TIME milliseconds
     digitalWrite(PUMP_1_PIN, LOW);  //turn pump 1 off
     delay(PUMP_2_TIME);             //wait PUMP_2_TIME milliseconds
     digitalWrite(PUMP_2_PIN, LOW);  //turn pump 2 off
  }
}
3

Please use code tags to post code.

For two or more different tasks running at the same time, avoid using delay().

Instead use millis() for timing, as described in this Blink without Delay tutorial, or in this How to do Several Things tutorial.

4

Yes I will have a resistor, thanks so much for your help.