Push Button #number of pushes and select

Projects Programming
1

I got 2 Push button, the first button selects divisibility of a number,

First button
1st Push - > Select to count divisibility of 2's
2nd Push -> Select to count divisibility of 5's
3rd Push -> Cancel

then the second button selects the number to start count

2nd Button
1st Push -> if 2's it starts to count from 0 - 2, if it 5's start to count from 0 - 5
2nd Push -> if 2's it starts to count from 0 - 4, if it 5's start to count from 0 - 10
3rd Push -> Cancel, back to First Button

there's no output in the serial monitor,

Thanks for the help.

void setup() {
  Serial.begin(9600);
  pinMode(6, INPUT_PULLUP);
  pinMode(7, INPUT_PULLUP);
}

void loop() {
  PushButton1 ();
}
int PushButton1 () {
  int Counter;
  int State;
  int LastState;
  int pb1, pb2;
  Counter = digitalRead(6);
  if (State != LastState) {
    if (State == LOW) {
      Counter++;
      Serial.println(Counter);
      // Select to count divisible by 2's
      if (Counter == 1) {
        PushButton2 ();
        menu (pb1, pb2);
      }
      // Select to count divisible by 5's
      if (Counter == 2) {
        PushButton2 ();
        menu (pb1, pb2);
      }
      //cancel
      if (Counter > 2) {
        Counter = 0;
      }
    }
    else {

    }
    delay(50);
  }
  LastState = State;
}

//2nd Button
int PushButton2 () {
  int Counter;
  int State;
  int LastState;
  int pb1, pb2;
  Counter = digitalRead(7);
  if (State != LastState) {
    if (State == LOW) {
      Counter++;
      Serial.println(Counter);
      if (Counter == 1) {
        menu (pb1, pb2);
      }
      if (Counter == 2) {
        menu (pb1, pb2);
      }
      //cancel
      if (Counter > 2) {
        Counter = 0;
      }
    }
    else {
    }
    delay(50);
  }
  LastState = State;
}
void menu (int pb1, int pb2) {
  switch (pb1) {
    case 0: switch (pb2) {
        case 0: twocounts ();
          break;
        case 1: fourcounts ();
          break;
      }
      break;
    case 1: switch (pb2) {
        case 0: fivecounts ();
          break;
        case 1: tencounts ();
          break;
      }
      break;
  }
}
void twocounts () {
  for (int x = 0; x > 3 ; x++) {
    Serial.print(x);
    delay(100);
  }
}
void fourcounts () {
  for (int x = 0; x > 5 ; x++) {
    Serial.print(x);
    delay(100);
  }
}
void tencounts () {
  for (int x = 0; x > 11 ; x++) {
    Serial.print(x);
    delay(100);
  }
}
void fivecounts () {
  for (int x = 0; x > 6 ; x++) {
    Serial.print(x);
    delay(100);
  }
}
2

One thing jumps out for optimization, I'll look at the rest when I have time.

Bottom two functions - consolidate to:

void menu (int pb1, int pb2) {
  switch (pb1) {
    case 0: switch (pb2) {
        case 0: counts (2); // twocounts
          break;
        case 1: counts (4);
          break;
      }
      break;
    case 1: switch (pb2) {
        case 0: counts (5);
          break;
        case 1: counts (10);
          break;
      }
      break;
  }
}

void counts (int numCounts) {
// since you're using a signed variable, you need to check for that
  if (numCounts>0)
  {
 for (int x = 0; x > numCounts+1 ; x++) {
 Serial.print(x);
 }
  }
  delay(100);
}
3 
  int State;
  int LastState;
  int pb1, pb2;
  Counter = digitalRead(6);
  if (State != LastState) {

You have no idea what is in the memory location that State is assigned to. You have no idea what is in the memory location that LastState is assigned to. It makes no sense to be comparing them.

     Counter++;

You have no idea what is in the memory location that Counter is assigned to. It makes no sense to be incrementing that value.

You probably want some of these variables to be global, so you DO have an idea what is assigned to them, and so that changes are persisted when PushButton1() ends.

4

After it incremented i want it to carry out to the next button . I want to create like a lcd and keypad menu, but only with 2 buttons and a serial monitor.

Im trying to understand to Save the incremented Number