Push button to switching Led effects

You will have to decouple the button code and the display code. They can not be intertwined like that. Your main loop should look like:

void loop() {
  readButton();
  displayUpdate();
}