Push buttons always showing '1'

Projects Programming
1

I am trying to turn ON a LED when either of two push buttons are pressed. But the problem is, button states of both push buttons show to be '1' even when I did not press anything. Please help!

This is my circuit : https://drive.google.com/file/d/18fsPnaaDxo9asE-DUh2sPlcEWGCRdqs-/view?usp=sharing

This is my code.

int button_state_1 = 0;
int button_state_2 = 0;

const int button_1 = 2;
const int button_2 = 3;
const int led = 4;
  
void setup()
{
  Serial.begin(9600);
  pinMode(led, OUTPUT);
  pinMode(button_1, INPUT);
  pinMode(button_2, INPUT);
}

void loop()
{
  delay(500);
  button_state_1 = digitalRead(button_1);
  button_state_2 = digitalRead(button_2);
  
  Serial.print("Button states for 1 and 2 are : ");
  Serial.print(button_state_1);
  Serial.println(button_state_2);
  
  if ((button_state_1 == HIGH) || (button_state_2 == HIGH))
  {
    digitalWrite(led, HIGH);
  }
  
  else
  {
    digitalWrite(led, LOW);
  }
  delay(1000);
  
}
2

Do you have pulldown resistors holding the inputs LOW when the buttons are not pressed ?

Consider changing the wring and program logic and using INPUT_PULLUP in pinMode() to activate the built in pullup resistors to avoid adding extra components

3

Thank you for your reply.
The error happened because I did not ground the resistors connected to the push button. It is solved now and the program works well. Thank you!

4

Hello coder_212,

Welcome.

You might find this helpful Buttons and other electro-mechanical inputs (introduction) - General Electronics - Arduino Forum

5

coder_212:
Thank you for your reply.
The error happened because I did not ground the resistors connected to the push button. It is solved now and the program works well. Thank you!

I am glad that you got it working but I still suggest that you investigate the use of INPUT_PULLUP to remove the need for extra components