Question about Arduino Leonardo: Average Lifespan?

Nah. You correctly identify the most likely component to fail: the connectors!
Neglecting for the moment that these are often used with not-quite-matching "shield" connectors, or bare wires, which makes them relatively suspicious from the beginning, this sort of connector is usually specified for a rather small number of insert/remove cycles...