re-read millis() or use a variable?

Using a variable has the advantage of always using the small number for the tests.
Reading millis every time has the advantage of always using the latest value, potentially doing a function lone iteration round the loop sooner.
All in all there is not much to choose between them.