Relay 12 volt single channel module connections to Arduino

I'd probably have connected it same as you.

Presumably the green led, marked SW for switch? is meant to indicate activity- what's it doing?

And is the red on to indicate power to the coil?