Rfid tags not being stored in eeprom

stevefoxuk · June 2, 2020, 8:28pm

Hi, i am trying to set up a door opener which uses a keypad or Rfid.

After scouring the net for days i could only find one project which did this, absolutely everything else out there expects you to use an Rfid tag and then input a passcode on the keypad, not one or the other.

The creator of this code actually made two almost identical versions, the second just adding Bluetooth.

The first displayed correctly on the lcd but both the keypad and rfid functions were broken.

The second version which is what im trying to get working is sort of working.

The passcode on the keypad works and triggers the output pin to trigger the relay and the led outputs work correctly.

The Display is broken, it only displays the first character of messages but for some reason it displays all of the 'x' characters correctly when inputting the passcode?

it would be nice if i could get it displaying the messages in full instead of just the first character but its not something i need as i only intended to have the lcd on the inside of the door to display status when pairing Rfid tags ect and will be using two leds with the keypad outside.

The Bluetooth is broken, it does not respond to codes being sent but the arduino is being sent the data as you can see the rx led on the board blink but i really dont care about the Bluetooth as i have no intention of using it or even having a module connected and just thought id have a play with it in testing.

Now for the important part, the Rfid is broken.

The module (RC522) sees tags just fine, the arduino responds and tag numbers are displayed in serial monitor.

putting in the keypad code to enter pairing mode works fine and when you present a tag the it says its been paired (well one character on the lcd but i know what it means lol) and it also says its been paired in serial monitor but it does not store the tag and subsequent reads of that tag will generate the 'invalid NFC code' message and does not trigger the relay output pin.

The code has a section about storing tags to the eeprom but this is clearly not happening but i cannot code Arduino, i just about manage to read existing codes and modify certain things for slightly different behaviour and this is beyond my ability.

Please could someone read though the code (its not huge) and see if they can figure out why its not storing tags please?

If the messages not being displayed is a simple thing then that would be great too but that's not really important, i just want the physical side working.

ive looked at the lcd code and its baffled me as the original sketch where none of the physical functions worked, the lcd code worked fine and messages were correctly displayed, ive examined and compared the code between the two different sketches and cant see any difference so no idea why it would only display the first character

The Rfid tags being stored is the only thing i really want to fix, anything else is a bonus, ive looked at the code to see if i can manually input tag numbers and ive tried a couple of places that looked like code sections but nothing worked.

Your help would be really appreciated!

Ive attached the ino file to this post, thanks, Steve.

softfinal_door_opener.ino (7.92 KB)

stevefoxuk · June 2, 2020, 8:35pm

Heres the sketch in text format so you dont have to open it in IDE

#include <EEPROM.h>
#include <SPI.h>
#include <MFRC522.h>
#include <Wire.h>
#include <LiquidCrystal_I2C.h>
#include <Keypad.h>

int state_bt=1;
int relPin;
int stare=0;
byte COD[10];
byte AUX[10];
int k=0;
String codacces="*123456#";
String codpairing="*654321#";
//nfc
#define RST_PIN 9 // Configurable, see typical pin layout above
#define SS_PIN 10 // Configurable, see typical pin layout above
MFRC522 mfrc522(SS_PIN, RST_PIN); // Create MFRC522 instance
#define NEW_UID {0xDE, 0xAD, 0xBE, 0xEF}
MFRC522::MIFARE_Key key;
//lcd

LiquidCrystal_I2C lcd(0x27,16,2);

//TASTATURA
const byte numRows= 4; //number of rows on the keypad

const byte numCols= 3; //number of columns on the keypad

//keymap defines the key pressed according to the row and columns just as appears on the keypad
char keymap[numRows][numCols]=
{
{'1', '2', '3',},

{'4', '5', '6',},

{'7', '8', '9',},

{'*', '0', '#',}
};

//Code that shows the the keypad connections to the arduino terminals
byte rowPins[numRows] = {5, A0, 7, 8}; //Rows 0 to 3

byte colPins[numCols]= {2, 3, 4}; //Columns 0 to 3

//initializes an instance of the Keypad class
Keypad myKeypad= Keypad(makeKeymap(keymap), rowPins, colPins, numRows, numCols);

void setup() {
pinMode(A0,OUTPUT);
digitalWrite(A0,HIGH);
pinMode(A3,OUTPUT);
digitalWrite(A3,HIGH);
pinMode(A1,OUTPUT);
digitalWrite(A1,HIGH);
pinMode(A2,OUTPUT);
digitalWrite(A2,LOW);
pinMode(6,OUTPUT);
digitalWrite(6,LOW);
//nfc
Serial.begin(9600); // Initialize serial communications with the PC
Serial.println("What did you say?:");
while (!Serial); // Do nothing if no serial port is opened (added for Arduinos based on ATMEGA32U4)
SPI.begin(); // Init SPI bus
mfrc522.PCD_Init(); // Init MFRC522 card

for (byte i = 0; i < 6; i++) {
key.keyByte = 0xFF;

}*
lcd.init();*
lcd.backlight();*
lcd.setCursor(0,0);*
lcd.clear();*
lcd.print( "LOCKED" );*
}
void citireNFC(){
for (byte i =0; i<(mfrc522.uid.size); i++) {*
COD_=mfrc522.uid.uidByte*;
}
Serial.print("COD");
Serial.print(COD[0]);
Serial.print(COD[1]);
Serial.print(COD[2]);
Serial.print(COD[3]);*_

}
void pairNFC(){
* Serial.println("COD in pair");*
* Serial.print(COD[0]);*
* Serial.print(COD[1]);*
* Serial.print(COD[2]);*
* Serial.print(COD[3]);*
* long r=0;*
* int c=0;*
* for(int i=1;i<=EEPROM.read(0);i++){*
* switch(i%4){*
* case 1 :{AUX[0]=EEPROM.read(i); break;}*
* case 2 :{AUX[1]=EEPROM.read(i); break;}*
* case 3 :{AUX[2]=EEPROM.read(i); break;}*
* case 0 :{AUX[3]=EEPROM.read(i); break;}*
* }*
* if((i)%4==0)*
* {Serial.println(r);*
* if( AUX[0]==COD[0] && AUX[1]==COD[1] && AUX[2]==COD[2] && AUX[3]==COD[3] ){*
* lcd.clear();*
* lcd.setCursor(0,0);*
* lcd.print("CODE ALREADY IN");*
* lcd.setCursor(0,1);*
* lcd.print("SYSTEM");*
* delay(2000);*
* c=1;*
* break;} *
* }*
* }*
* if(c==0){int ttt=EEPROM.read(0);*
* Serial.println("CODE PAIRED");*
* Serial.print(COD[0]);*
* Serial.print(COD[1]);*
* Serial.print(COD[2]);*
* Serial.print(COD[3]);*
* EEPROM.write(ttt+1,COD[0]);*
* EEPROM.write(ttt+2,COD[1]);*
* EEPROM.write(ttt+3,COD[2]);*
* EEPROM.write(ttt+4,COD[3]);*
* ttt=ttt+4;*
* Serial.println("ttt");*
* Serial.println(ttt);*
* EEPROM.write(0,0);*
* EEPROM.write(0,ttt); *
* lcd.clear();*
* lcd.setCursor(0,0);*
* lcd.print("CODE PAIRED");*
* delay(2000);} *
* }*

boolean validareNFC(){
* boolean c=false;*
* for(int i=1;i<=EEPROM.read(0);i++){*
* switch(i%4){*
* case 1 :{AUX[0]=EEPROM.read(i); break;}*
* case 2 :{AUX[1]=EEPROM.read(i); break;}*
* case 3 :{AUX[2]=EEPROM.read(i); break;}*
* case 0 :{AUX[3]=EEPROM.read(i); break;}*
* }*
* if((i)%4==0)*
* {*
* if( AUX[0]==COD[0] && AUX[1]==COD[1] && AUX[2]==COD[2] && AUX[3]==COD[3])*
* c=true;*
* }} *
* return c; *
}
int comparareCOD(String a)
{
* if(a.equals(codacces))*
* return 1;*
* else if(a.equals(codpairing)) return 2;*
* else return 0; *
}
String iaCOD(char x)
{ char vec[10];
* vec[0]=x;*
* lcd.setCursor(0,0);*
* lcd.clear();*
* lcd.print('X');*
* for(int i=1;i<8;i++)*
_ {vec*=myKeypad.waitForKey();
lcd.print('X');}
vec[8]=NULL;
String str(vec);
return str;
} *
void loop() {_

* //Start BT autentification*
* if(Serial.available())*
* {*
* char c=Serial.read();*
* switch (state_bt) {*

* case 1:*
if(c=='') state_bt=2;
else state_bt=1;
_ break;*_

* case 2:*
* if(c=='1') state_bt=3;
else state_bt=1;
_ break;*_

* case 3:*
* if(c=='2') state_bt=4;
else state_bt=1;
_ break;*_

* case 4:*
* if(c=='3') state_bt=5;
else state_bt=1;
_ break;*_

* case 5:*
* if(c=='4') state_bt=6;
else state_bt=1;
_ break;*_

* case 6:*
* if(c=='5') state_bt=7;
else state_bt=1;
_ break;*_

* case 7:*
* if(c=='6') state_bt=8;
else state_bt=1;
_ break;*_

* case 8:*
* if(c=='#') state_bt=9;
else state_bt=1;
_ break;*_

* case 9:*
* lcd.init(); *
* lcd.backlight();*
* lcd.print("OPEN");*
* digitalWrite(6,LOW);*
* delay(5000);*
* digitalWrite(6,HIGH);*
* lcd.init(); *
* lcd.backlight();*
* lcd.print("BLOCKED");*
* state_bt=1;
_ break;*_

* default:*

* break;*
* }*
* }*

* //////////END BT Autentification*

* switch(stare){*
* case 0: {*
* mfrc522.PCD_Init();
if ( mfrc522.PICC_IsNewCardPresent() && mfrc522.PICC_ReadCardSerial() ){*

* citireNFC();*
* if(validareNFC()) *
* {stare=1;*
* lcd.clear();*
* lcd.setCursor(0,0);*
* lcd.print("VALID NFC CODE");*
* delay(1000);*
* return; *
* }*
* else{*
* lcd.clear();*
* lcd.setCursor(0,0);*
* lcd.print("INVALID NFC CODE");*
* delay(1000);*
* lcd.setCursor(0,0);*
* lcd.clear();*
* lcd.print("BLOCKED");*
* return;*
* }*
* }*
* char c=myKeypad.getKey();*
* if(c != NO_KEY){*

* String codcurent=iaCOD(c);*
* int A=comparareCOD(codcurent);*
* if(A==0)*
* {lcd.clear();*
* lcd.print("INVALID CODE");*
* delay(2000);*
* lcd.setCursor(0,0);*
* lcd.clear();*
* lcd.print("BLOCKED");*
* return;}*
* if(A==1)*
* {lcd.setCursor(0,0);*
* lcd.clear();*
* lcd.print("VALID CODE");*
* delay(2000);*
* stare = 1;*
* return;}*
* if(A==2);*
* {stare=2;*
* lcd.clear();*
* lcd.setCursor(0,0);*
* lcd.print("Pairing...");*
* delay(2000);*
* return;}*
* } break;*
* }*
* case 1:{*
* lcd.clear();*
* lcd.setCursor(0,0);*
* lcd.print("UNLOCKED");*
* digitalWrite(A3,LOW);*
* digitalWrite(A1,LOW);*
* digitalWrite(A2,HIGH);*
* //tone(6,3000,5010);*
* digitalWrite(6,HIGH);*
* delay(2000);*
* digitalWrite(6,LOW);*
* digitalWrite(A3,HIGH);*
* digitalWrite(A1,HIGH);*
* digitalWrite(A2,LOW);*
* stare=0;*
* lcd.setCursor(0,0);*
* lcd.clear();*
* lcd.print("BLOCKED");*

* return;*
* }*
* case 2:{*

* mfrc522.PCD_Init();
if ( mfrc522.PICC_IsNewCardPresent() && mfrc522.PICC_ReadCardSerial() ){
_ citireNFC();
pairNFC();
stare=0;
delay(2000);
lcd.clear();
lcd.setCursor(0,0);
lcd.print("BLOCKED"); }*_

* break;*

* }*

* }*
}

idv7 · June 3, 2020, 4:48am

hey stevefoxuk,

first of all, would you please put your code in a code block which is a bit easier to read!
like this:

#include <EEPROM.h>
#include <SPI.h>
#include <MFRC522.h>
#include <Wire.h>
#include <LiquidCrystal_I2C.h>
#include <Keypad.h>


int state_bt=1;
int relPin;
int stare=0;
byte  COD[10];
byte  AUX[10];
int k=0;
String codacces="*123456#";
String codpairing="*654321#";
//nfc
#define RST_PIN   9     // Configurable, see typical pin layout above
#define SS_PIN    10    // Configurable, see typical pin layout above
MFRC522 mfrc522(SS_PIN, RST_PIN);   // Create MFRC522 instance
#define NEW_UID {0xDE, 0xAD, 0xBE, 0xEF}
MFRC522::MIFARE_Key key;
//lcd

LiquidCrystal_I2C  lcd(0x27,16,2);

//TASTATURA
const byte numRows= 4; //number of rows on the keypad
 
const byte numCols= 3; //number of columns on the keypad

//keymap defines the key pressed according to the row and columns just as appears on the keypad
char keymap[numRows][numCols]=
{
{'1', '2', '3',},
 
{'4', '5', '6',},
 
{'7', '8', '9',},
 
{'*', '0', '#',}
};

//Code that shows the the keypad connections to the arduino terminals
byte rowPins[numRows] = {5, A0, 7, 8}; //Rows 0 to 3
 
byte colPins[numCols]= {2, 3, 4}; //Columns 0 to 3
 

//initializes an instance of the Keypad class
Keypad myKeypad= Keypad(makeKeymap(keymap), rowPins, colPins, numRows, numCols);


void setup() {
   pinMode(A0,OUTPUT);
   digitalWrite(A0,HIGH);
   pinMode(A3,OUTPUT);
   digitalWrite(A3,HIGH);
   pinMode(A1,OUTPUT);
   digitalWrite(A1,HIGH);
   pinMode(A2,OUTPUT);
   digitalWrite(A2,LOW);
   pinMode(6,OUTPUT);
   digitalWrite(6,LOW);
   //nfc
  Serial.begin(9600);  // Initialize serial communications with the PC
  Serial.println("What did you say?:");
  while (!Serial);     // Do nothing if no serial port is opened (added for Arduinos based on ATMEGA32U4)
  SPI.begin();         // Init SPI bus
  mfrc522.PCD_Init();  // Init MFRC522 card
 
    for (byte i = 0; i < 6; i++) {
    key.keyByte = 0xFF;
  }

    lcd.init();
    lcd.backlight();
    lcd.setCursor(0,0);
    lcd.clear();
    lcd.print( "LOCKED" );

}

void  citireNFC(){
  for (byte i =0; i<(mfrc522.uid.size); i++) {
    COD=mfrc522.uid.uidByte;
  }
  Serial.print("COD");
  Serial.print(COD[0]);
  Serial.print(COD[1]);
  Serial.print(COD[2]);
  Serial.print(COD[3]);
 
}

void pairNFC(){
  Serial.println("COD in pair");
  Serial.print(COD[0]);
  Serial.print(COD[1]);
  Serial.print(COD[2]);
  Serial.print(COD[3]);
   long  r=0;
   int c=0;
  for(int i=1;i<=EEPROM.read(0);i++){
    switch(i%4){
          case 1 :{AUX[0]=EEPROM.read(i); break;}
          case 2 :{AUX[1]=EEPROM.read(i); break;}
          case 3 :{AUX[2]=EEPROM.read(i); break;}
          case 0 :{AUX[3]=EEPROM.read(i); break;}
    }
    if((i)%4==0)
       {Serial.println(r);
        if( AUX[0]==COD[0] && AUX[1]==COD[1] && AUX[2]==COD[2] && AUX[3]==COD[3] ){
          lcd.clear();
          lcd.setCursor(0,0);
          lcd.print("CODE ALREADY IN");
          lcd.setCursor(0,1);
          lcd.print("SYSTEM");
          delay(2000);
           c=1;
          break;}   
      }
      }
  if(c==0){int ttt=EEPROM.read(0);
              Serial.println("CODE PAIRED");
              Serial.print(COD[0]);
              Serial.print(COD[1]);
              Serial.print(COD[2]);
              Serial.print(COD[3]);

          EEPROM.write(ttt+1,COD[0]);
          EEPROM.write(ttt+2,COD[1]);
          EEPROM.write(ttt+3,COD[2]);
          EEPROM.write(ttt+4,COD[3]);

          ttt=ttt+4;
          Serial.println("ttt");
          Serial.println(ttt);
          EEPROM.write(0,0);
          EEPROM.write(0,ttt);   
          lcd.clear();
          lcd.setCursor(0,0);
          lcd.print("CODE PAIRED");
          delay(2000);}   
  }
 

boolean validareNFC(){
   boolean c=false;
      for(int i=1;i<=EEPROM.read(0);i++){
          switch(i%4){
          case 1 :{AUX[0]=EEPROM.read(i); break;}
          case 2 :{AUX[1]=EEPROM.read(i); break;}
          case 3 :{AUX[2]=EEPROM.read(i); break;}
          case 0 :{AUX[3]=EEPROM.read(i); break;}
        }
    if((i)%4==0)
       {
        if( AUX[0]==COD[0] && AUX[1]==COD[1] && AUX[2]==COD[2] && AUX[3]==COD[3])
          c=true;
         }}       
   return c;     
}

int comparareCOD(String a)
 {
  if(a.equals(codacces))
     return 1;
  else if(a.equals(codpairing)) return 2;
  else return 0;   
 }


String iaCOD(char x)
{ char vec[10];
  vec[0]=x;
  lcd.setCursor(0,0);
  lcd.clear();
  lcd.print('X');
  for(int i=1;i<8;i++)
     {vec=myKeypad.waitForKey();
      lcd.print('X');}
  vec[8]=NULL;
  String str(vec);
  return str;
}   



void loop() {
 
  //Start BT autentification
   if(Serial.available())
  {
  char c=Serial.read();
  switch (state_bt) {
 
  case 1:
  if(c=='*') state_bt=2;
  else state_bt=1;
  break;
 
  case 2:
  if(c=='1') state_bt=3;
  else state_bt=1;
  break;
 
  case 3:
  if(c=='2') state_bt=4;
  else state_bt=1;
  break;
 
  case 4:
  if(c=='3') state_bt=5;
  else state_bt=1;
  break;
 
  case 5:
  if(c=='4') state_bt=6;
  else state_bt=1;
  break;
 
  case 6:
  if(c=='5') state_bt=7;
  else state_bt=1;
  break;
 
  case 7:
  if(c=='6') state_bt=8;
  else state_bt=1;
  break;
 
  case 8:
  if(c=='#') state_bt=9;
  else state_bt=1;
  break;
 
  case 9:

  lcd.init();   
  lcd.backlight();
  lcd.print("OPEN");
  digitalWrite(6,LOW);
  delay(5000);
  digitalWrite(6,HIGH);
  lcd.init();   
  lcd.backlight();
  lcd.print("BLOCKED");
  state_bt=1;
  break;
 
  default:
 
  break;
  }
  }
 
 
  //////////END BT Autentification
       
      switch(stare){
      case 0: {
        mfrc522.PCD_Init();
        if (  mfrc522.PICC_IsNewCardPresent() && mfrc522.PICC_ReadCardSerial() ){
       
        citireNFC();
        if(validareNFC()) 
           {stare=1;
            lcd.clear();
            lcd.setCursor(0,0);
            lcd.print("VALID NFC CODE");
            delay(1000);
            return;   
           }
        else{
             lcd.clear();
             lcd.setCursor(0,0);
             lcd.print("INVALID NFC CODE");
             delay(1000);
             lcd.setCursor(0,0);
             lcd.clear();
             lcd.print("BLOCKED");
             return;
            }
        }
      char c=myKeypad.getKey();
      if(c != NO_KEY){
       
      String codcurent=iaCOD(c);
      int A=comparareCOD(codcurent);
      if(A==0)
      {lcd.clear();
       lcd.print("INVALID CODE");
       delay(2000);
        lcd.setCursor(0,0);
        lcd.clear();
        lcd.print("BLOCKED");
       return;}
      if(A==1)
      {lcd.setCursor(0,0);
       lcd.clear();
       lcd.print("VALID CODE");
       delay(2000);
       stare = 1;
       return;}
      if(A==2);
       {stare=2;
          lcd.clear();
          lcd.setCursor(0,0);
          lcd.print("Pairing...");
          delay(2000);
        return;}
      } break;
       }
      case 1:{
        lcd.clear();
        lcd.setCursor(0,0);
        lcd.print("UNLOCKED");
        digitalWrite(A3,LOW);
        digitalWrite(A1,LOW);
        digitalWrite(A2,HIGH);
        //tone(6,3000,5010);
        digitalWrite(6,HIGH);
        delay(2000);
        digitalWrite(6,LOW);
        digitalWrite(A3,HIGH);
        digitalWrite(A1,HIGH);
        digitalWrite(A2,LOW);
        stare=0;
        lcd.setCursor(0,0);
        lcd.clear();
        lcd.print("BLOCKED");
       
       
     
        return;
        }
        case 2:{
         
          mfrc522.PCD_Init();
          if (  mfrc522.PICC_IsNewCardPresent() && mfrc522.PICC_ReadCardSerial() ){
          citireNFC();
          pairNFC();
          stare=0;
          delay(2000);
          lcd.clear();
          lcd.setCursor(0,0);
          lcd.print("BLOCKED");   }
                   
       
       
         
         
          break;
         
        }
         
       }

}

I don't have the time to test the program etc ...
but here i have a similar tutorial ...
it uses an rfid master card (regular normal card) it has the ability to add and remove cards!
everything is stored in the eeprom of the arduino so that when you turn off your project not all added cards are lost.
I was very pleased with the result!

here is the link:

if you have any questions just ask them!
Isaak

stevefoxuk · June 3, 2020, 2:25pm

idv7:
hey stevefoxuk,

first of all, would you please put your code in a code block which is a bit easier to read!
like this:

if you have any questions just ask them!
Isaak

I had a look at your project and it's not what I'm looking for unfortunately as it's just an rfid and no keypad project and additionally (I'm sure it's easy to change) it triggers a pwm outputs to a servo, I want to drive a relay to operate a solenoid based door release.

I want both a keypad and rfid access but also want them independent to each other so one or the other can be used and this project which I'm trying to get working is the only one I can find which works that way, all others want a rfid tag and then a passcode on the keypad.

I dont don't need to get this project storing tags by the pairing mode, if there is somewhere in the code where I can manually enter tag I.d's I'm fine with that.

If you or anyone else can help with just getting tags recognised I really don't care about the other things being broken.

Steve.

stevefoxuk · June 4, 2020, 7:25pm

Can anyone help please?

im really keen to get this working and has hard as ive searched, i cant find the solution or another project which does the same, ive looked for days!

i really dont care about tags pairing automatically if there is a place in the code where i can maually enter the tags serial numbers, all i care about is just getting the tags triggering an unlock.

Topic		Replies	Views
Arduino RFID and Keypad Lock not working Programming	13	2395	May 5, 2021
RFID in my project Programming	5	1180	May 5, 2021
Program Alteration Programming	7	1695	May 5, 2021
Door Lock using RFID+I2C-LCD+Keypad General Guidance	1	3332	May 5, 2021
Problems at the time of reading a rfid card Programming	2	970	May 5, 2021

Rfid tags not being stored in eeprom

Related topics